publicdata/j40-cejst-2
1
0
Fork 0
mirror of https://github.com/DOI-DO/j40-cejst-2.git synced 2025-07-31 14:31:18 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

hotfix wrong score tile csv path (#671)

Browse source 
* hotfix wrong score tile csv path

* updating test

* forcing update

* triggering action
This commit is contained in:
Jorge Escobar 2021-09-14 07:27:48 -04:00 • committed by GitHub
commit 879cb7d022
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
data/data-pipeline/README.md
View file

@ -311,7 +311,7 @@ ETL unit tests are typically organized into three buckets:
- Transform Tests, and - Transform Tests, and
- Load Tests - Load Tests
These are tested using different strategies, explained below. These are tested using different strategies explained below.
#### Extract Tests #### Extract Tests

7
data/data-pipeline/data_pipeline/etl/score/constants.py
View file

@ -31,9 +31,12 @@ FULL_SCORE_CSV_FULL_PLUS_COUNTIES_FILE_PATH = (
DATA_SCORE_CSV_FULL_DIR / "usa_counties.csv" DATA_SCORE_CSV_FULL_DIR / "usa_counties.csv"
) )
## Score Tile paths # Score Tile CSV source path
DATA_SCORE_CSV_TILES_PATH = DATA_SCORE_CSV_DIR / "tiles"
DATA_SCORE_CSV_TILES_FILE_PATH = DATA_SCORE_CSV_TILES_PATH / "usa.csv"
## Tile path
DATA_SCORE_TILES_DIR = DATA_SCORE_DIR / "tiles" DATA_SCORE_TILES_DIR = DATA_SCORE_DIR / "tiles"
DATA_SCORE_TILES_FILE_PATH = DATA_SCORE_TILES_DIR / "usa.csv"
# Downloadable paths # Downloadable paths
SCORE_DOWNLOADABLE_DIR = DATA_SCORE_DIR / "downloadable" SCORE_DOWNLOADABLE_DIR = DATA_SCORE_DIR / "downloadable"

4
data/data-pipeline/data_pipeline/etl/score/etl_score_post.py
View file

@ -201,7 +201,7 @@ class PostScoreETL(ExtractTransformLoad):
] ]
def transform(self) -> None: def transform(self) -> None:
logger.info("Transforming data sources for Score + County CSV") logger.info("Transforming data sources for Score + County CSVs")
transformed_counties = self._transform_counties(self.input_counties_df) transformed_counties = self._transform_counties(self.input_counties_df)
transformed_states = self._transform_states(self.input_states_df) transformed_states = self._transform_states(self.input_states_df)
@ -267,7 +267,7 @@ class PostScoreETL(ExtractTransformLoad):
constants.FULL_SCORE_CSV_FULL_PLUS_COUNTIES_FILE_PATH, constants.FULL_SCORE_CSV_FULL_PLUS_COUNTIES_FILE_PATH,
) )
self._load_tile_csv( self._load_tile_csv(
self.output_score_tiles_df, constants.DATA_SCORE_TILES_FILE_PATH self.output_score_tiles_df, constants.DATA_SCORE_CSV_TILES_FILE_PATH
) )
self._load_downloadable_zip( self._load_downloadable_zip(
self.output_downloadable_df, constants.SCORE_DOWNLOADABLE_DIR self.output_downloadable_df, constants.SCORE_DOWNLOADABLE_DIR

4
data/data-pipeline/data_pipeline/etl/score/tests/test_score_post.py
View file

@ -112,9 +112,9 @@ def test_load_score_csv(etl, score_data_expected):
def test_load_tile_csv(etl, tile_data_expected): def test_load_tile_csv(etl, tile_data_expected):
reload(constants) reload(constants)
etl._load_score_csv( etl._load_score_csv(
tile_data_expected, constants.DATA_SCORE_TILES_FILE_PATH tile_data_expected, constants.DATA_SCORE_CSV_TILES_FILE_PATH
) )
assert constants.DATA_SCORE_TILES_FILE_PATH.is_file() assert constants.DATA_SCORE_CSV_TILES_FILE_PATH.is_file()
def test_load_downloadable_zip(etl, downloadable_data_expected): def test_load_downloadable_zip(etl, downloadable_data_expected):