ansible-collections/google.cloud
1
0
Fork 0
mirror of https://github.com/ansible-collections/google.cloud.git synced 2025-07-26 14:41:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Clear up error responses from gcp_secret_manager lookup

Browse source 
The wording of the raised exception wasn't great, adding a bit more
granularity to the type of error returned

Signed-off-by: Jorge Gallegos <jgallego@redhat.com>
This commit is contained in:
Jorge Gallegos 2025-06-10 17:27:26 -07:00
commit c9775be63e
No known key found for this signature in database
1 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

19
plugins/lookup/gcp_secret_manager.py
View file

@ -204,8 +204,23 @@ class LookupModule(LookupBase):
)
response = auth.get(url)
self._display.vvv(msg=f"List Version Response: {response.status_code} for {response.request.url}: {response.json()}")
if response.status_code != 200:
self.raise_error(module, f"unable to list versions of secret {response.status_code}")
if response.status_code >= 500: # generic server error
self.raise_error(
module,
f"server error encountered while looking for secret '{module.params['name']}', code: {response.status_code}"
)
elif response.status_code >= 400: # generic client request error
self.raise_error(
module,
f"client error encountered while looking for secret '{module.params['name']}', code: {response.status_code}"
)
elif response.status_code >= 300: # all other possible errors
self.raise_error(
module,
f"unable to list versions for secret '{module.params['name']}', code: {response.status_code}"
)
else:
pass
version_list = response.json()
if "versions" in version_list:
versions_numbers = []