From c9775be63ed9a2feb125591e53de1a2028c81489 Mon Sep 17 00:00:00 2001 From: Jorge Gallegos Date: Tue, 10 Jun 2025 17:27:26 -0700 Subject: [PATCH] Clear up error responses from gcp_secret_manager lookup The wording of the raised exception wasn't great, adding a bit more granularity to the type of error returned Signed-off-by: Jorge Gallegos --- plugins/lookup/gcp_secret_manager.py | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/plugins/lookup/gcp_secret_manager.py b/plugins/lookup/gcp_secret_manager.py index 14824a92..c7ef20d4 100644 --- a/plugins/lookup/gcp_secret_manager.py +++ b/plugins/lookup/gcp_secret_manager.py @@ -204,8 +204,23 @@ class LookupModule(LookupBase): ) response = auth.get(url) self._display.vvv(msg=f"List Version Response: {response.status_code} for {response.request.url}: {response.json()}") - if response.status_code != 200: - self.raise_error(module, f"unable to list versions of secret {response.status_code}") + if response.status_code >= 500: # generic server error + self.raise_error( + module, + f"server error encountered while looking for secret '{module.params['name']}', code: {response.status_code}" + ) + elif response.status_code >= 400: # generic client request error + self.raise_error( + module, + f"client error encountered while looking for secret '{module.params['name']}', code: {response.status_code}" + ) + elif response.status_code >= 300: # all other possible errors + self.raise_error( + module, + f"unable to list versions for secret '{module.params['name']}', code: {response.status_code}" + ) + else: + pass version_list = response.json() if "versions" in version_list: versions_numbers = []