Commit graph

89 commits

Author SHA1 Message Date
Andrew Klychkov
f5e48424db Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-03-22 07:46:26 +01:00
Andrew Klychkov
692cb2b0ef Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-03-22 07:46:26 +01:00
Andrew Klychkov
a6f61b5ca9 Fix 2021-03-22 07:46:26 +01:00
Andrew Klychkov
9f8fb07b4c Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-03-22 07:46:26 +01:00
Andrew Klychkov
407d348e7b Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-03-22 07:46:26 +01:00
Andrew Klychkov
915780ecc4 Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-03-22 07:46:26 +01:00
Andrew Klychkov
5983e8254d Update CONTRIBUTING.md
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
2021-03-22 07:46:26 +01:00
Andrew Klychkov
74cf0635cf Fix 2021-03-22 07:46:26 +01:00
Andrew Klychkov
8677ea1a0e
Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-03-19 07:16:14 +01:00
Andrew Klychkov
31723a504a
Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-03-19 07:15:22 +01:00
Andrew Klychkov
bbc132bc45
Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
2021-03-19 07:14:39 +01:00
Andrew Klychkov
4d3c063553 Add suggested 2021-03-19 07:11:28 +01:00
Andrew Klychkov
718082d189
Update CONTRIBUTING.md
Co-authored-by: Felix Fontein <felix@fontein.de>
2021-03-13 07:45:01 +01:00
Andrew Klychkov
46a39c840e Add git installed mentioned 2021-03-13 07:39:07 +01:00
Andrew Klychkov
8ed5223b19
Update CONTRIBUTING.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
2021-03-12 15:45:33 +01:00
Andrew Klychkov
ae8160cb74 Fix suggested 2021-03-12 09:37:16 +01:00
Andrew Klychkov
108d491b62 Fix 2021-03-11 14:54:53 +01:00
Andrew Klychkov
f98e66f855
Update CONTRIBUTING.md
Co-authored-by: Felix Fontein <felix@fontein.de>
2021-03-11 14:46:41 +01:00
Andrew Klychkov
6250c3995e
Update CONTRIBUTING.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
2021-03-11 14:41:29 +01:00
Andrew Klychkov
a852e89276 Fix 2021-03-11 14:32:11 +01:00
Andrew Klychkov
6069b26578 Add an example 2021-03-11 09:18:01 +01:00
Andrew Klychkov
4966274d19 Add an option 2021-03-11 07:52:24 +01:00
Andrew Klychkov
bbeefb4476 Change suggested 2021-03-11 07:38:36 +01:00
Andrew Klychkov
f8b954b0bf Fix 2021-03-11 07:26:09 +01:00
Andrew Klychkov
71f878b2fb
Update CONTRIBUTING.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
2021-03-10 16:21:23 +01:00
Andrew Klychkov
cf326d1bcf Fix suggested 2021-03-10 16:04:59 +01:00
Andrew Klychkov
1a923ef916 Fix suggested 2021-03-10 16:01:13 +01:00
Andrew Klychkov
6d741378fb Fix suggested 2021-03-10 15:57:08 +01:00
Andrew Klychkov
6e7a96817b Add CONTRIBUTING.md 2021-03-10 11:13:56 +01:00
Andrew Klychkov
e8cb81b30e Release 1.3.0 commit 2021-03-08 17:22:17 +01:00
Andrew Klychkov
979588e2cd
mysql_user: add proper handling of INSERT, UPDATE, REFERENCES on columns (#107)
* mysql_user: add proper handling of INSERT, UPDATE, REFERENCES on columns

* Add changelog fragment

* fix sanity

* fix CI

* fix sanity

* fix CI

* make the assertion fairer

* Improve
2021-03-08 17:18:04 +01:00
Andrew Klychkov
2694464ffb
mysql_user: when grant select on columns, the module always report the state has changed (#100)
* mysql_user: fix the module is not idempotent when there is SELECT on columns granted

* add changelog fragment

* fix

* Add unit tests for has_select_on_col function

* Add unit tests for sort_column_order function

* Add unit tests for handle_select_on_col function

* Update a comment
2021-03-03 10:58:57 +01:00
Andrew Klychkov
e8dc2f2476
mysql_replication: deprecation of slave related options, adding alternatives (#97)
* mysql_replication: deprecation of slave related options, adding alternatives

* Add changelog fragment

* Integration tests getslave -> getreplica

* Change the rest of offending choices/comments

* Add announcement about replacing SLAVE to REPLICA in messages

* Deprecate offending values
2021-03-01 10:45:35 +01:00
Michael S
faab501326
Update README.md - Update ext. documentation links (#102) 2021-02-25 17:16:44 +02:00
Tom Van Looy
24a4137982
mysql_user: remove duplicate of REPLICATION SLAVE entry from valid privs frozenset (#95) 2021-02-10 09:38:47 +03:00
Andrew Klychkov
09ac98adb8
Fix galaxy.yml (#94) 2021-02-08 18:24:19 +03:00
Andrew Klychkov
31bd2b567f Release 1.2.0: add changelog 2021-01-18 09:27:46 +03:00
Steve Teahan
b25fb5974d
mysql_user: refactor to reduce execute() calls (#76)
This module does not currently log the SQL statements that it executes.
A change was proposed to add this functionality, but it would require
modifications in many sections of the code due to how many cursor.execute()
statements there currently are. This change simply consolidates the
number of execute() calls where it is trivial to do so.
2021-01-15 13:44:03 +03:00
Steve Teahan
06907715d7
mysql_user: fixed encrypted option for MySQL 8.0 and test coverage (#79)
* mysql_user: fixed encrypted option for MySQL 8.0 and test coverage

The purpose of this change was originally to expand test coverage to
unblock #76, but an issue was detected with the encrypted parameter on
MySQL 8.0 in the process of writing the tests. Additionally,
user_password_update_test.yml had been disabled at some point, so I
opted to replace it with two new files that will focus on the password
and plugin auth paths.

* Updated tests to cover a couple of missing branches

* Skip tests that rely on sha256_password if pymysql < 0.9

* Cover the case where pymysql isn't installed for plugin tests

* Added better plugin auth checking to tests and other minor changes

* Fixed version detection to explicitly handle MariaDB

* Removed unneeded import from previous change

* Remove whitespace that was introduced by change that was removed

* Added unit tests for missing coverage
2021-01-14 08:27:05 +03:00
Andrew Klychkov
2de3a57021
mysql_user: Add SHOW_ROUTINE privilege support (#87)
* mysql_user: Add SHOW_ROUTINE privilege support

* add changelog fragment

Co-authored-by: Andrew Klychkov <andrew.klychkov@gmail.com>
2021-01-13 09:36:23 +03:00
Andrew Klychkov
9eb007969c Generating changelog for release 1.1.2, remove fragments 2020-12-18 11:29:36 +03:00
Andrew Klychkov
af0811d764 Change release version in galaxy.yml 2020-12-18 11:28:05 +03:00
Andrew Klychkov
2cf7d60976 Add release 1.1.2 changelog fragment 2020-12-18 11:26:24 +03:00
Andrew Klychkov
ebe503823a
mysql_replication: fix crashes caused by deprecated terminology (#71)
* mysql_replication: fix crashes caused by deprecated terminology

* Fix unrelated sanity errors

* Tests: mysql 8.0.21 -> 8.022

* Adjust integration tests

* Add version check to the tests

* Add debug statement

* Adjust mysql version

* Fix tests

* Add unit tests

* Add changelog fragment

* Improve code and coverage

* Get rid of extra blank line

* Improve coverage

* Change suggested
2020-12-18 11:17:18 +03:00
Andrew Klychkov
b7e828a092
mysql_db: fix false warning related to unsafe_login_password (#74) 2020-12-18 10:56:49 +03:00
steveteahan
20f9699199
mysql_user: Fixed change detection with append_privs (#69) (#72)
* mysql_user: Fixed change detection with append_privs (#69)

Prior to this change, mysql_user with append_privs would attempt to make
a change even if the current privileges were a superset of the new
privileges (shouldn't require any action).

* Fixed unrelated mysql_replication doc causing failures in CI

* Added fragments and check_mode tests

* Expanded priv append tests to cover additional case
2020-12-16 08:22:00 +03:00
Andrew Klychkov
d309d5af2d
mysql_user: fix documentation (#65)
* mysql_user: fix documentation

* Changed suggested

* Update plugins/modules/mysql_user.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/mysql_user.py

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
2020-11-26 13:51:02 +03:00
Andrew Klychkov
ea54a44c76
mysql_info: fix documentation (#67) 2020-11-26 13:12:51 +03:00
Andrew Klychkov
549c7fe15a
mysql_variables: fix documentation (#66) 2020-11-26 13:12:31 +03:00
Andrew Klychkov
504bc87a4a
mysql_db: improve documentation formatting (#64) 2020-11-26 13:12:11 +03:00