Commit graph

231 commits

Author SHA1 Message Date
Laurent Indermuehle
92e280968b
Add me as an author 2023-01-30 11:21:40 +01:00
Laurent Indermuehle
37408c8eb3
Cut condition to display any name that is return
In case of MySQLdb is renamed in mysqlclient. In that case, the
integration tests will catch this the day we update the connector
version.
2023-01-27 17:16:58 +01:00
Laurent Indermuehle
2f204eb0c6
Workaround mysqlclient whose name differs between package and pypi 2023-01-27 14:27:20 +01:00
Laurent Indermuehle
5f34a5f8b4
Rename driver to connector for consistency 2023-01-27 11:50:44 +01:00
Laurent Indermühle
776de7acc2
Rewording for consistency
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-27 11:25:02 +01:00
Laurent Indermühle
638ba054b6
Rewording for consistency
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-27 11:24:47 +01:00
Laurent Indermuehle
f5e6f3b941
Fix tests when GHA workflow rewrite connector name without spaces 2023-01-27 11:11:54 +01:00
Laurent Indermuehle
e70f87195d
Add integration tests 2023-01-27 10:35:12 +01:00
Laurent Indermuehle
41dfa8ddaf
Reformat typo 2023-01-27 09:35:52 +01:00
Laurent Indermühle
931f32cac6
Refactor to handle Unknown in the if block
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-27 08:54:12 +01:00
Laurent Indermühle
0a51d94137
Refactor to handle Unknow in the if block
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-27 08:53:44 +01:00
Laurent Indermühle
bc917b739c
Document version_added
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-27 08:43:45 +01:00
Laurent Indermühle
199f69042a
Document version_added
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-27 08:43:28 +01:00
Laurent Indermühle
9fd2e58f22
Reformat ending sentence with a dot
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-27 08:36:46 +01:00
Laurent Indermühle
a20df80acc
Update changelog link to PR
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-27 08:36:03 +01:00
Laurent Indermuehle
5e0f23b020
Add back changelog fragment deleted by accident in 03fc38a 2023-01-26 16:52:12 +01:00
Laurent Indermuehle
302aa11a3c
Add back line from PR489 removed by accident 2023-01-26 16:51:10 +01:00
Laurent Indermuehle
03fc38a1bd
Add missing file extension 2023-01-26 16:41:18 +01:00
Laurent Indermuehle
75c7dfb358
Add changelog fragment 2023-01-26 14:22:50 +01:00
Laurent Indermuehle
d6deb9bf8f
Add connector name and version in the returned block 2023-01-26 14:03:28 +01:00
Laurent Indermuehle
22481ed51b
Document that mysqlclient is also named MySQLdb 2023-01-26 14:01:56 +01:00
Laurent Indermuehle
16676373fa
Add methods to retrieve connector name and version 2023-01-26 14:01:16 +01:00
Andrew Klychkov
3229ce4e55
README: improve Matrix badge (#494)
* README: improve Matrix badge

* Add text
2023-01-26 09:00:45 +01:00
Jorge Rodriguez (A.K.A. Tiriel)
00fa058a18
491-CI-fix-tarball-download (#491)
* Fix mariadb test setup

* Update mysql src URL

* Add changelog fragment

* Update 491_fix_download_url.yaml

Sanity test failed because minor_changes in not an element of a list.

* Fix casing

Co-authored-by: Laurent Indermühle <laurent.indermuehle@pm.me>
2023-01-24 19:12:35 +02:00
Andrew Klychkov
930a5a5d49
mysql_user: add session_vars argument (#489)
* mysql_user: add session_vars argument

* Update tests/integration/targets/test_mysql_user/tasks/main.yml

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
2023-01-24 14:53:29 +01:00
Alexander Skiba
c242584bae
mysql_user: enabled autocommit to support MySQL 8 (#483)
* mysql_user: enabled autocommit to support MySQL 8

* Add changelog fragment

* Link to issue instead of pull request in changelog fragment

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-17 10:34:20 +01:00
Andrew Klychkov
4ad71775a6
README: update Matrix badge (#485) 2023-01-16 12:46:31 +01:00
Andrew Klychkov
3ff1fad5f3
Docs: change yes/no to true/false (#480) 2023-01-03 11:24:59 +01:00
hubiongithub
8a579b42e3
add service name to plugin pam/auth_pam usage (#445)
* add service name to plugin pam/auth_pam usage

* typo fixed

* MySLQ is using identified with auth_pam by ...  instead of identified with pam using ... like mariadb does

* a : in description lines breaks yaml syntax

* clearify documentation and add changelog fragment

* Update changelogs/fragments/445_add_service_name_to_plugin_pam_auth_pam_usage.yml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Update plugins/module_utils/user.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2023-01-03 09:47:11 +01:00
Andrew Klychkov
eade7ec1f0
CI: add PR change detection (#473) 2022-12-09 14:50:37 +01:00
Laurent Indermühle
015f58ea5a
Update CONTRIBUTORS 2022-12-08 19:32:22 +01:00
Diego Gullo
6ac89ca1f6
Display a more informative error when InvalidPrivsError is raised (#465) (#466)
* Display a more informative error when InvalidPrivsError is raised (Issue #465)

Co-authored-by: Laurent Indermühle <laurent.indermuehle@pm.me>
2022-12-06 13:12:01 +01:00
Laurent Indermühle
4dac66382a
Add fixed version of Ubuntu (#470)
This is because ubuntu-latest link to ubuntu-22.04 which includes
cgroup-v2. I thinks our tests fails because of that. See
https://github.com/ansible-collections/news-for-maintainers/issues/28
for more information.
2022-12-06 08:41:04 +01:00
Andrew Klychkov
09e02320fd
README: Add matrix room + badge (#459)
* README: Add matrix room + badge

* improve
2022-11-01 12:59:06 +01:00
Gabriel PREDA
b9a6ec4f7d
* add socket option suggestion in documentation (#437)
* * add `socket` option suggestion in documentation

* white space fix

* * move first two at the end
2022-10-04 11:08:59 +02:00
Sviatoslav Sydorenko
8107530744
Sync GHA workflow w/ the collection template (#452)
* Sync GHA workflow w/ the collection template

* Drop the trailing pre-cmd semicolon

* Recover missing `-e` flag of `sed`

* Use relative paths for version configs

* Unquote `env.connector_version_file`

* Use string formatting to fix the substitution problem
2022-10-03 14:27:55 +02:00
Andrew Klychkov
b8e2c02e89
CI: add stable-2.14 to test matrix (#449) 2022-09-22 11:24:01 +02:00
R.Sicart
2cd29207f3
Fix: devel requires python 3.9 in roles CI (#444)
* Fix: devel requires python 3.9

Package 'ansible-core' requires a different Python: 3.8.13 not in '>=3.9'

* Exclude older version of Ansible when testing Python 3.9
2022-09-16 13:38:22 +02:00
Léo_chocolat
ff9f58e8d1
changelog: fix broken link in ansible docs (#446) 2022-09-16 09:15:29 +02:00
R.Sicart
7defd8e728
Release 3.5.1 commit (#443) 2022-09-09 15:22:00 +02:00
R.Sicart
2d75bc19b8
Fix privilege changing everytime (#438)
* Compare privileges from before and after manipulation

* Add unit tests

* Fix FIXME integration tests related to this issue

* Fix sanity check

* Fix assertion when appending privs in mysql_role_initial integration tests

* Fix pylint

* [ci-skip] Add changelog fragment

* Fix: missing fragment file extension

* Replace privileges_equal() by a comparison

* Fix: sanity pylint

* Fix: forgot to remove privileges_equal import from unit tests
2022-09-08 18:26:58 +02:00
Maxwell G
ea73d408c3
Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links (#432) 2022-09-06 09:00:41 +02:00
Andrew Klychkov
3670b2adc6
Release 3.5.0 commit (#436) 2022-09-05 09:06:41 +02:00
R.Sicart
cc5cf98368
Fix: grant revoked priv (#434)
* Fix: exclude mysql 8 from test_mysql_user's 'Assert that priv did not change' test

* Add tests to verify that GRANT permission is present after user modification

* Fix: do not revoke GRANT permission when it's already allowed and present in priv parameter

* Deduplicate tests name

Easier to debug this way

* Fix assertions named 'GRANT permission is present'

* Only revoke grant option if it exists and absence is requested

* Fix assertion comments

* Fix: Only revoke grant option if it exists and absence is requested

* Avoid pointless revocations when ALL are granted

* Assert that priv did not change on mariadb also

* Fix: sanity and unity tests

* Format long lines

* Add changelog fragment

Co-authored-by: Laurent Indermühle <laurent.indermuehle@pm.me>
2022-09-02 13:40:06 +02:00
Андрей Неустроев
aef6a2040c
Add SOURCE_SSL_VERIFY_SERVER_CERT parameter (#435)
* Add SOURCE_SSL_VERIFY_SERVER_CERT parameter

* Rewiev fixs and add changelog fragment

* fix version

* Update changelogs/fragments/435-mysql_replication_verify_server_cert.yml

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2022-09-02 10:59:51 +02:00
Andrew Klychkov
f1d63e3fc8
Docs: add info how to cope with a protocol-related connection error using login_unix_socket argument (#420) 2022-08-26 11:38:41 +02:00
Laurent Indermühle
0a68bb270f
Is changed (#427)
* Refactor tests to use "is" and "is not" changed

* Refactor tests to use is succeeded or is failed

* Reformat indentation

* Add filter "bool" to prevent issues
2022-08-23 09:11:55 +02:00
Laurent Indermühle
61586ae4cc
Port stable 1 ci changes (#423)
* Add changes from stable-1 integrations tests (PR 418)

* Refactor to use connectors' info declared in setup_mysql

* Fix 2nd replication stop marked changed by mysqlclient
2022-08-16 09:15:50 +02:00
Andrew Klychkov
057f817111
MAINTAINERS file: add a new maintainer (#419) 2022-08-12 22:41:26 +02:00
Laurent Indermühle
97318559e5
Fix ci python requirements (#416)
* Add matrix for python and ansible-core versions for sanity tests

* Add python 3.9 to integrations tests

* Add python 3.9 to unit tests

* Reformat sort by python version first
2022-08-05 09:25:14 +02:00