Alexander Skiba
6bce48e771
Add documentation for privs with functions and procedures ( #169 )
2021-05-18 07:57:07 +02:00
Andrew Klychkov
ac927fdb08
Add CONTRIBUTORS file ( #166 )
2021-05-13 16:59:15 +02:00
Andrew Klychkov
158471e7ee
Remove changelog fragments after release 2.1.0 ( #161 )
2021-04-28 07:45:00 +02:00
Andrew Klychkov
738343d64c
mysql: revert changes made in PR 116 ( #153 )
...
* mysql: revert changes made in PR 116
* Add changelog fragment
* Fix CI
* Fix CI
* Fix CI
* Update CI
* Fix CI
2021-04-23 12:57:23 +02:00
Andrew Klychkov
c8f9b1cd3f
mysql_replication: Add aliases to "master" options, add alternatives to "master" state options, add announcement ( #150 )
...
* mysql_replication: Add aliases, add alternatives for the state option, announce major changes
* Change tests
* Add changelog fragment
* Fix changelog
* Update plugins/modules/mysql_replication.py
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
* Update plugins/modules/mysql_replication.py
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
2021-04-20 15:58:21 +02:00
Andrew Klychkov
853db5a2a4
mysql_replication: add deprecation warning about future replacement of Is_Slave and Is_Master return values, add alternatives ( #147 )
...
* mysql_replication: add deprecation warning about future replacement of Is_Slave and Is_Master return values, add alternatives
* Add changelog fragment
2021-04-16 06:34:35 +02:00
Andrew Klychkov
f7c84a71e5
Update main branch after branching new stable-2 branch ( #146 )
2021-04-15 10:14:34 +02:00
Andrew Klychkov
1790664c00
mysql_replication: replace the word slave with replica in messages ( #144 )
...
* mysql_replication: replace the word slave with replica in messages
* Add changelog fragment
* Add announcements
2021-04-15 09:38:32 +02:00
Jorge Rodriguez (A.K.A. Tiriel)
dc522cc5d3
Deprecate REQUIRESSL privilege ( #132 )
...
* Deprecate REQUIRESSL privilege
* Add missing whitespace
* Fix according to PR review
* Fix conditional check
* Fix privilege string parsing
* Add unit tests for the new function
* Add integration tests
* Fix parentheses indentation
* Cover alternative error message
* Fix privileges
* Limit verification of access denied to pymysql connector
* Fix REQUIRE SSL verification tests
2021-04-10 07:01:15 +02:00
Andrew Klychkov
6342fb6f23
Update README.md ( #139 )
2021-04-07 16:54:41 +02:00
Andrew Klychkov
dad555a536
Tests: add ansible 2.11 support ( #138 )
...
@Andersson007 thanks for this PR
2021-04-06 11:12:27 +03:00
Andrew Klychkov
ba791bf983
Fix REVIEW_CHECKLIST.md ( #133 )
2021-03-31 08:54:51 +02:00
Andrew Klychkov
ecd15c83f7
Add refs to the committer guidelines ( #131 )
2021-03-29 11:48:11 +02:00
Andrew Klychkov
2960748473
CONTRIBUTING.md: add a reference to REVIEW_CHECKLIST.md ( #130 )
2021-03-28 07:54:55 +02:00
Andrew Klychkov
ca963b23c0
Add review_checklist.md ( #127 )
...
* Add review_checklist.md
* Add general tips
* Improve general tips
* fix
* fix
* fix
* fix
* fix
* fix
* Fix
* Update review_checklist.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
* Fix
* Update review_checklist.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
* Update review_checklist.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
* Rename checklist
Co-authored-by: Amin Vakil <info@aminvakil.com>
* Update REVIEW_CHECKLIST.md
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
* Add suggested
* Add clarifications
Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
2021-03-27 10:03:03 +01:00
Andrew Klychkov
60646bcadb
Improve CONTRIBUTING.md ( #129 )
2021-03-26 21:20:50 +02:00
Jorge Rodriguez (A.K.A. Tiriel)
fcb459499e
Add discussions section ( #126 )
...
* Add discussions section
* Syntax improvements
Co-authored-by: Andrew Klychkov <aklychko@redhat.com>
Co-authored-by: Andrew Klychkov <aklychko@redhat.com>
2021-03-23 09:09:01 +01:00
Jorge Rodriguez (A.K.A. Tiriel)
e5bf8836fa
Add note about the contribution guide ( #125 )
...
* Add note about the contribution guide
* Update README.md
Co-authored-by: Andrew Klychkov <aklychko@redhat.com>
Co-authored-by: Andrew Klychkov <aklychko@redhat.com>
2021-03-22 09:51:57 +01:00
Andrew Klychkov
f0c917e606
Add CONTRIBUTING.md ( #112 )
...
* Add CONTRIBUTING.md
* Fix suggested
* Fix suggested
* Fix suggested
* Update CONTRIBUTING.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
* Fix
* Change suggested
* Add an option
* Add an example
* Fix
* Update CONTRIBUTING.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
* Update CONTRIBUTING.md
Co-authored-by: Felix Fontein <felix@fontein.de>
* Fix
* Fix suggested
* Update CONTRIBUTING.md
Co-authored-by: Amin Vakil <info@aminvakil.com>
* Add git installed mentioned
* Update CONTRIBUTING.md
Co-authored-by: Felix Fontein <felix@fontein.de>
* Add suggested
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Fix
* Update CONTRIBUTING.md
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Fix
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
* Update CONTRIBUTING.md
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
* Update CONTRIBUTING.md
Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Amin Vakil <info@aminvakil.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Jorge Rodriguez (A.K.A. Tiriel) <jorge.rodriguez@tiriel.eu>
2021-03-22 08:58:22 +01:00
Norbert Varzariu
0bdf9e2ee7
update docs on check_hostname corresponding to mysqls cli --ssl switch ( #123 )
...
Signed-off-by: Norbert Varzariu <loomsen@gmail.com>
2021-03-21 21:30:28 +02:00
Jorge Rodriguez (A.K.A. Tiriel)
11958ec46a
Handle divergences between MySQL and MariaDB ( #103 )
...
* Initial attempt
* First functional approach
* Remove unused imports
* Add dychotomy handling for mysql_replication
* Fix cursor lookup
* Fix sanity tests
* Cleanup implementation conditional import
* Fix unit tests
* Fix conditional import to satisfy both sanity and integration tests
* Add changelog fragment
2021-03-16 09:15:19 +01:00
Sebastian Gumprich
a5ee4b3d1a
add mysql_full_version and suffix return variable ( #115 )
...
* add mysql_full_version and suffix return variable
add changelog fragment
* rephrase changelog fragment
* Update plugins/modules/mysql_info.py
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
* Add changes as per PR review
* Add tests for new suffix output parameter
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Jorge-Rodriguez <jorge.rodriguez@futurice.com>
2021-03-16 09:10:52 +02:00
Daniel Ziegenberg
2254b29178
change deprecated parameter pw and db ( #116 )
...
* change deprecated parameter pw to password
* change deprecated parameter db to database
* add changelog fragment
2021-03-16 07:15:12 +02:00
Andrew Klychkov
bd86e249d0
mysql_replication: add a reference to how to encrypted connection options ( #118 )
...
* mysql_replication: add a reference to how to encrypted connection options
* Fix sanity
2021-03-15 09:39:14 +01:00
Felix Fontein
884310cf24
Mark master_ssl_key as no_log=False. ( #117 )
2021-03-15 07:30:53 +01:00
Andrew Klychkov
baea97d24c
mysql_user: Add REPLICA MONITOR privilege to supported ( #108 )
...
* mysql_user: Add REPLICA MONITOR privilege to supported
* Add changelog fragment
2021-03-11 16:17:49 +01:00
Andrew Klychkov
fc2dd0079f
Add .keep file to changelog/fragments to make it always present ( #113 )
2021-03-10 18:16:18 +01:00
Andrew Klychkov
e8cb81b30e
Release 1.3.0 commit
2021-03-08 17:22:17 +01:00
Andrew Klychkov
979588e2cd
mysql_user: add proper handling of INSERT, UPDATE, REFERENCES on columns ( #107 )
...
* mysql_user: add proper handling of INSERT, UPDATE, REFERENCES on columns
* Add changelog fragment
* fix sanity
* fix CI
* fix sanity
* fix CI
* make the assertion fairer
* Improve
2021-03-08 17:18:04 +01:00
Andrew Klychkov
2694464ffb
mysql_user: when grant select on columns, the module always report the state has changed ( #100 )
...
* mysql_user: fix the module is not idempotent when there is SELECT on columns granted
* add changelog fragment
* fix
* Add unit tests for has_select_on_col function
* Add unit tests for sort_column_order function
* Add unit tests for handle_select_on_col function
* Update a comment
2021-03-03 10:58:57 +01:00
Andrew Klychkov
e8dc2f2476
mysql_replication: deprecation of slave related options, adding alternatives ( #97 )
...
* mysql_replication: deprecation of slave related options, adding alternatives
* Add changelog fragment
* Integration tests getslave -> getreplica
* Change the rest of offending choices/comments
* Add announcement about replacing SLAVE to REPLICA in messages
* Deprecate offending values
2021-03-01 10:45:35 +01:00
Michael S
faab501326
Update README.md - Update ext. documentation links ( #102 )
2021-02-25 17:16:44 +02:00
Tom Van Looy
24a4137982
mysql_user: remove duplicate of REPLICATION SLAVE entry from valid privs frozenset ( #95 )
2021-02-10 09:38:47 +03:00
Andrew Klychkov
09ac98adb8
Fix galaxy.yml ( #94 )
2021-02-08 18:24:19 +03:00
Andrew Klychkov
31bd2b567f
Release 1.2.0: add changelog
2021-01-18 09:27:46 +03:00
Steve Teahan
b25fb5974d
mysql_user: refactor to reduce execute() calls ( #76 )
...
This module does not currently log the SQL statements that it executes.
A change was proposed to add this functionality, but it would require
modifications in many sections of the code due to how many cursor.execute()
statements there currently are. This change simply consolidates the
number of execute() calls where it is trivial to do so.
2021-01-15 13:44:03 +03:00
Steve Teahan
06907715d7
mysql_user: fixed encrypted option for MySQL 8.0 and test coverage ( #79 )
...
* mysql_user: fixed encrypted option for MySQL 8.0 and test coverage
The purpose of this change was originally to expand test coverage to
unblock #76 , but an issue was detected with the encrypted parameter on
MySQL 8.0 in the process of writing the tests. Additionally,
user_password_update_test.yml had been disabled at some point, so I
opted to replace it with two new files that will focus on the password
and plugin auth paths.
* Updated tests to cover a couple of missing branches
* Skip tests that rely on sha256_password if pymysql < 0.9
* Cover the case where pymysql isn't installed for plugin tests
* Added better plugin auth checking to tests and other minor changes
* Fixed version detection to explicitly handle MariaDB
* Removed unneeded import from previous change
* Remove whitespace that was introduced by change that was removed
* Added unit tests for missing coverage
2021-01-14 08:27:05 +03:00
Andrew Klychkov
2de3a57021
mysql_user: Add SHOW_ROUTINE privilege support ( #87 )
...
* mysql_user: Add SHOW_ROUTINE privilege support
* add changelog fragment
Co-authored-by: Andrew Klychkov <andrew.klychkov@gmail.com>
2021-01-13 09:36:23 +03:00
Andrew Klychkov
9eb007969c
Generating changelog for release 1.1.2, remove fragments
2020-12-18 11:29:36 +03:00
Andrew Klychkov
af0811d764
Change release version in galaxy.yml
2020-12-18 11:28:05 +03:00
Andrew Klychkov
2cf7d60976
Add release 1.1.2 changelog fragment
2020-12-18 11:26:24 +03:00
Andrew Klychkov
ebe503823a
mysql_replication: fix crashes caused by deprecated terminology ( #71 )
...
* mysql_replication: fix crashes caused by deprecated terminology
* Fix unrelated sanity errors
* Tests: mysql 8.0.21 -> 8.022
* Adjust integration tests
* Add version check to the tests
* Add debug statement
* Adjust mysql version
* Fix tests
* Add unit tests
* Add changelog fragment
* Improve code and coverage
* Get rid of extra blank line
* Improve coverage
* Change suggested
2020-12-18 11:17:18 +03:00
Andrew Klychkov
b7e828a092
mysql_db: fix false warning related to unsafe_login_password ( #74 )
2020-12-18 10:56:49 +03:00
steveteahan
20f9699199
mysql_user: Fixed change detection with append_privs ( #69 ) ( #72 )
...
* mysql_user: Fixed change detection with append_privs (#69 )
Prior to this change, mysql_user with append_privs would attempt to make
a change even if the current privileges were a superset of the new
privileges (shouldn't require any action).
* Fixed unrelated mysql_replication doc causing failures in CI
* Added fragments and check_mode tests
* Expanded priv append tests to cover additional case
2020-12-16 08:22:00 +03:00
Andrew Klychkov
d309d5af2d
mysql_user: fix documentation ( #65 )
...
* mysql_user: fix documentation
* Changed suggested
* Update plugins/modules/mysql_user.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/mysql_user.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2020-11-26 13:51:02 +03:00
Andrew Klychkov
ea54a44c76
mysql_info: fix documentation ( #67 )
2020-11-26 13:12:51 +03:00
Andrew Klychkov
549c7fe15a
mysql_variables: fix documentation ( #66 )
2020-11-26 13:12:31 +03:00
Andrew Klychkov
504bc87a4a
mysql_db: improve documentation formatting ( #64 )
2020-11-26 13:12:11 +03:00
Andrew Klychkov
09d0ce2ce0
Remove version from README ( #61 )
2020-11-17 11:22:21 +03:00
Jose Angel Munoz
bb99cf5b04
Add mysqlclient library reference in doc ( #57 )
2020-11-06 21:14:45 +03:00
