ansible-collections/community.mysql
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.mysql.git synced 2025-04-22 18:31:27 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Improve general tips

Browse source
This commit is contained in:
Andrew Klychkov 2021-03-22 10:59:19 +01:00
parent 19dfc12fdf
commit a57f743700
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
review_checklist.md
View file

@ -4,11 +4,13 @@ When reviewing, keep in mind that we follow [Ansible Code of Conduct](https://do
**General tips**
- Try create a culture of collaboration, when reviewing
- Welcome the author, thank them and other reviewers for their time and effort
- Welcome the author and thank them for the pull request
- When suggesting changes, try to use questions, not statements
- When suggesting mandatory changes, do it as politely as possible providing documentation references
- If your suggestion is optional or a matter of personal preferences, please say it explicitly
- When asking for adding tests or for complex core refactoring, say that the author is welcome to ask for clarifications and help if they need
- If somebody suggests a good idea, say about it or put a thumbs up
- After merging, thank the author and reviewers for their time and effort
**Standards and documentation**
- [ ] the pull request is not a documentation fix, it must include a [changelog fragment](https://docs.ansible.com/ansible/devel/community/development_process.html#creating-a-changelog-fragment). Please check the format carefully