From a57f74370040ece997af38158bd063a0696b3120 Mon Sep 17 00:00:00 2001 From: Andrew Klychkov Date: Mon, 22 Mar 2021 10:59:19 +0100 Subject: [PATCH] Improve general tips --- review_checklist.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/review_checklist.md b/review_checklist.md index 66e5f6c..a117945 100644 --- a/review_checklist.md +++ b/review_checklist.md @@ -4,11 +4,13 @@ When reviewing, keep in mind that we follow [Ansible Code of Conduct](https://do **General tips** - Try create a culture of collaboration, when reviewing -- Welcome the author, thank them and other reviewers for their time and effort +- Welcome the author and thank them for the pull request - When suggesting changes, try to use questions, not statements - When suggesting mandatory changes, do it as politely as possible providing documentation references - If your suggestion is optional or a matter of personal preferences, please say it explicitly - When asking for adding tests or for complex core refactoring, say that the author is welcome to ask for clarifications and help if they need +- If somebody suggests a good idea, say about it or put a thumbs up +- After merging, thank the author and reviewers for their time and effort **Standards and documentation** - [ ] the pull request is not a documentation fix, it must include a [changelog fragment](https://docs.ansible.com/ansible/devel/community/development_process.html#creating-a-changelog-fragment). Please check the format carefully