cobbler.inventory: Allow collecting fully rendered facts (#9975)
Add facts_level option to cobbler inventory plugin, cleanpu
Initialize connection in parse()
Handle rendered system data in _get_systems() so it can be cached
(cherry picked from commit 7524e74bb7)
Signed-off-by: Orion Poplawski <orion@nwra.com>
Co-authored-by: Orion Poplawski <orion@nwra.com>
Co-authored-by: Tyler Phillippe <tylerphillippe@tutamail.com>
Add xdg_mime module (#10007)
* Add version of xdg_mime module
* Fix xdg_mime_get since the command is different
* Add query parameter
* Fix order of parameters
* Add myself to BOTMETA
* Add unit tests
* Fix the way we deal when there is no handler set
* Improve documentation
* Remove unused import
* Fix documentation
* Strip xdg-mime from version string
* Fix information about version
* Add error message sample
* Add test to invalid handler
* Add support to multiple mime-types
* Change the output parameter from handlers to handler
* Change tests related to multiple mime-type support
* Small fixes
* Stop using constant to enable changed state
* Add before_handlers and after_handlers
* Change tests to use before and after structures
* Add a stronger message about using a non-installed handler
* Manage some edge cases
* Change error message to match the new value
* Add some fixes
* Change some tests
* Update plugins/modules/xdg_mime.py
* Remove a blank line
* Remove single quote
* Add xdg-mime to the version in the mocks
* Remove after_handlers and make code simpler
* Update tests to work without after_handlers
* Remove diff_params and clean output_params
* Make mime_type plural since it supports multiple items
* Move the handler check to module init
* Use anchors in the test to make yaml simpler
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Add blank line to separe examples
* Update plugins/modules/xdg_mime.py
* Add a small homage to my late grandma
* Update plugins/modules/xdg_mime.py
* Fix pep8 problem with the homage
* Remove trailing whitespace
* Update plugins/modules/xdg_mime.py
---------
(cherry picked from commit 373334d668)
Co-authored-by: Marcos Alano <mhalano@users.noreply.github.com>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Mark supervisorctl tests as unstable (#10057)
Mark supervisorctl tests as unstable.
(cherry picked from commit a720e99482)
Co-authored-by: Felix Fontein <felix@fontein.de>
Remove FreeBSD 14.0 from CI (#10051)
Remove FreeBSD 14.0 from CI.
In ansible-core it has been replaced with 14.1, but we're already testing against that.
Ref: 3546111f2d
(cherry picked from commit 4a2920b0fd)
Co-authored-by: Felix Fontein <felix@fontein.de>
Add support for addressing subgroups by paths to the keycloak_user module (#9898)
* Add support for addressing subgroups by paths to the keycloak_user module (issue #9647)
* Apply suggestions from code review.
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 6e384a1c6a)
Co-authored-by: Christian Schlichtherle <christian@schlichtherle.de>
Remove blanket skips for Python 3 in CI (#10043)
* Remove blanket skips for Python 3 in CI.
* Try to fix hg tests.
* Disable hg tests.
* Drop restriction of supervisor to <4.0.0.
This was introduced in https://github.com/ansible/ansible/pull/54935.
* Make tests work with supervisorctl 4.0.0.
According to https://supervisord.org/changes.html#id12,
"supervisorctl will now set its exit code to a non-zero value when an error condition occurs."
I'm not sure why a stopped service in 'status' constitutes an error condition,
but whatever 🤷...
* Use correct Python executable.
* Skip RHEL/macOS; diff on config write.
* Skip CentOS 7 and OpenSuSE on ansible-core 2.16.
(cherry picked from commit 2a5abab738)
Co-authored-by: Felix Fontein <felix@fontein.de>
fixed hidden warnings from extra tests - batch 3 (#10029)
* fixed hidden warnings from extra tests - batch 3
* add empty lines to separate sections of the EXAMPLE block
* Apply suggestions from code review
* Update plugins/modules/nmcli.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 73178e3d33)
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Use antsibull-nox instead of extra sanity test runner and extra workflows (#10022)
* Use antsibull-nox instead of extra sanity test runner and extra workflows.
* Avoid sys.argv[0].
(cherry picked from commit 3ee55c6828)
Allowing uppercase tags in proxmox & proxmox_kvm (#10024)
* Allowing uppercase tags in proxmox & proxmox_kvm
* Fix#9895 : fixes the 'not a valid tag' error message when the VM or container tag contains uppercase characters
* Add PR URL to changelog fragment.
---------
Co-authored-by: s1githug <sgithug@free.fr>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ce421dbd7d)
Co-authored-by: s1github <sgithub@free.fr>
fix: github_deploy_key check key exists on 422 (#10011)
* fix: github_deploy_key check key exists on 422
If we get a 422 response code as we add a key, check if it's because the key already exists or for another reason.
fixes: #6718
* chore: add changelog 10011-github_deploy_key-check-key-present
* chore: fix changelog fragment
* chore: fix changelog fragment
* Update changelog fragment.
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c248073079)
Co-authored-by: Alex Garel <alex@garel.org>
Homebrew: Emit a useful error message if brew info reports a package tap is null. (#10013)
* Fix#10012.
Homebrew: Emit a useful error message if a package tap is null. This can happen if an installed package is subsequently removed from the tap (e.g. it is withdrawn by homebrew).
* Added changelogs fragment for PR 10013
* Do not raise error when tap is null in package_detail
pylint: remove trailing whitespace
* Minor: Update plugins/modules/homebrew.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Minor: Update changelogs/fragments/10012-improve-error-handling-homebrew-missing-tap.yml
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Update plugins/modules/homebrew.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 4b9373f694)
Co-authored-by: brad2014 <brad2014@users.noreply.github.com>
add the wsl connection plugin (#9795)
* add the wsl connection plugin
* move the banner_timeout required paramiko version to its own line
* document the proxy_command required paramiko version
* document the timeout required paramiko version
* simplify the sending of the become_pass value
* add Connection.__init__ type hints
* add MyAddPolicy.missing_host_key type hints
* normalize the Connection._parse_proxy_command replacers dict values to the str type
* add the user_known_hosts_file option
* modify the private_key_file option type to path
(cherry picked from commit 96b493002c)
Co-authored-by: Rui Lopes <rgl@ruilopes.com>
param pkcs12_alias and cert_alias to be optional in java_cert module (#9970)
* changed pkcs12_alias and cert_alias to be optional when importing pkcs12 certificate in keystore
* Add changelog fragment
* Update changelogs/fragments/9970-pkcs12_alias_cert_alias_optional.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/9970-pkcs12_alias_cert_alias_optional.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 42a161abf5)
Co-authored-by: Emanuele Bernardi <e.berna@gmail.com>
improve ansible_host in proxmox inventory plugin (#9952)
* improve ansible_host in proxmox inventory plugin
I had this issue myself and found out there was already an issue thread:
https://github.com/ansible-collections/community.general/issues/5906
this fixes the issue for hope we can all benefit after this gets merged
* f string styling
* add log line for the successful address selection
* remove white space
* add changelog: 9952-proxmox-inventory-plugin-improve-ansible_host.yml
* Update changelogs/fragments/9952-proxmox-inventory-plugin-improve-ansible_host.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1243846c3a)
Co-authored-by: Stein van Broekhoven <stein@aapjeisbaas.nl>
Fix typo in rpm_ostree_pkg documentation example (#9999)
Fix typo in rpm_ostree_pkg examples
The example showing use of a delay to improve resiliency misspelled 'delay'
(cherry picked from commit 216e7dc06b)
Co-authored-by: Jeffrey Borcean <jjborcean@gmail.com>
Make ready for data tagging (#9833)
* Fix dependent lookup.
* Fix ansible_type plugin utils and adjust documentation of reveal_ansible_type filter and ansible_type test.
* Fix diy callback plugin.
* Adjust to Data Tagging.
* Vendor and use internal code from ansible-core to fix YAML callback.
Ref: https://github.com/ansible/ansible/issues/84781
(cherry picked from commit 04cfce78ea)
Co-authored-by: Felix Fontein <felix@fontein.de>
allow gitlab-project-members module to handle user level "owner" (#9953)
* fix(modules/gitlab-project-members): fix ...
... module not being able to handle owner access level
* add changelog fragment for this pr
* fix and extend integration tests
* extend parameter docu as requested by review
* also add docu for other parameters
* remove pip install break-packages flag from ...
... integration tests
---------
Co-authored-by: Mirko Wilhelmi <Mirko.Wilhelmi@sma.de>
(cherry picked from commit 1157b7102f)
Co-authored-by: morco <thegreatwiper@web.de>
hpilo_boot: fix module failing when trying to power on an already powered-on server (#9646)
* fix: fix hpilo_boot.py module failing when trying to power on an already powered-on server
For this module to be idempotent, it should be successful when trying to reach a power state which is already there.
It was already the case for "poweroff", however when running the module with "boot_once" state, it was failing if the server was already powered_on, which is not an idempotent behavior
* doc: Add changelog fragment
* fix: add flag to run boot_once idempotently without breaking the previous behavior and add deprecation warning
* doc: fix documentation fragment description
* fix unwanted format changes
seems like I had an older version of this module formatted differently or that I had a formatter that automatically ran on this file
* fix linting errors
Removed trailing whitespace line 164
* add missing dash in idempotent_boot_once parameter description
* fix doc issue
* Update changelogs/fragments/9646-hpilo-fix-idempotency.yml
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Update plugins/modules/hpilo_boot.py
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Update changelogs/fragments/9646-hpilo-fix-idempotency.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* comment out module deprecation and change idempotent boot_once parameter description
* Update plugins/modules/hpilo_boot.py
* Update plugins/modules/hpilo_boot.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Ryan BADAÏ <ryan.badai@dbi-services.com>
(cherry picked from commit d7edd34ba4)
Co-authored-by: Ryan Badaï <43403063+ryanb74@users.noreply.github.com>
Unify TLS/SSL config for Redfish modules with new common argument spec and docs fragment; add validate_certs and ca_path options (#9964)
Unify TLS/SSL config for Redfish modules with new common argument spec and docs fragment.
(cherry picked from commit 1375cb65d6)
Co-authored-by: Felix Fontein <felix@fontein.de>
proxmox_disk: fail gracefully if storage hasn't been provided by the user (#9963)
Fail gracefully if storage hasn't been provided by the user.
(cherry picked from commit 34b6fb74eb)
Co-authored-by: Felix Fontein <felix@fontein.de>
Fix payload to match Rocket Chat 7.4.1 API (#9882)
* Fix payload to match Rocket Chat 7.4 API
* Add a fallback to send payload argument in case the user still interacts with a Rocket Chat version < 7.4.0
* Fix sanity checks
* Add changelog fragment of PR #9882
* Add argument option_is_pre740 to keep backward compatibility of the payload
* Add new argument doc
* Rename new parameter, add missing pieces of information in parameter doc
* Use appropriate change label and fix change description. Description about future plans for the parameter is now set at the parameter doc level
* Fix missing punctuation in the new parameter doc block
* Improve documentation.
* Fix line length.
---------
Co-authored-by: ludovic <ludovic.petetin@aleph-networks.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c3b0354da0)
Co-authored-by: X <2465124+broferek@users.noreply.github.com>
The yarn module is Yarn Classic only at the moment (#9926)
The yarn module is Yarn Classic only.
(cherry picked from commit cb776e7cd5)
Co-authored-by: Felix Fontein <felix@fontein.de>
Unit tests: replace mock and compat with code from community.internal_test_tools (#9921)
* Replace compat with equivalent from community.internal_test_tools.
* Replace mock with equivalent from community.internal_test_tools.
(cherry picked from commit 410cf72aec)
Co-authored-by: Felix Fontein <felix@fontein.de>
Use more unit test utils from community.internal_test_tools (#9918)
* Make conftest's patch_ansible_module use the context manager from .utils.
* Fix test dependencies.
* Use module mock utils from community.internal_test_tools.
* Use DataDictLoader from community.internal_test_tools.
* Use trust util from community.internal_test_tools.
(cherry picked from commit 8ab8010b6d)
Co-authored-by: Felix Fontein <felix@fontein.de>
nmcli: fix reordering of DNS nameservers and search suffixes (#9880)
* nmcli: fix reordering of DNS nameservers and search suffixes
- Fixes#8724
* Update changelog fragment index in line with PR number
- Now I understand what that number is for
* Use correct changelog format for nmcli PR #9880
(cherry picked from commit 3922b82a57)
Co-authored-by: ashleyghooper <ashleyghooper@gmail.com>
