proxmox: fix: cannot access local variable 'identifier' where it is not associated with a value (#10155)
* fix: cannot access local variable 'identifier' where it is not associated with a value
* Add changelog fragment.
---------
(cherry picked from commit 786be88f43)
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Louis Jannett <louisjannett@icloud.com>
Allow running sanity and unit tests with antsibull-nox; impove testing documentation (#10104)
* Whitespace fixes.
* Allow to run unit and sanity tests with antsibull-nox.
* Document installation of needed collections for tests.
* Also mention other sanity tests.
(cherry picked from commit 6008e6e1a7)
Co-authored-by: Felix Fontein <felix@fontein.de>
rundeck_acl_policy: fix project acls are put/posted to the wrong endpoint (#10097)
* Fix project acls are put/posted to the wrong endpoint
* Add changelog fragment.
* Fix 2.7 sanity errors in github
* Fix fragment extension and use 2.7 syntax in test
* Update changelogs/fragments/10097-fix-rundeck_acl_policy-project-endpoint.yml
* Fix pep8 formatting
* Add licensing to unit test
---------
(cherry picked from commit ff0ed6f912)
Co-authored-by: kjoyce77 <kevin.joyce@outlook.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
kdeconfig: mark end of options before sending value (#10128)
* mark end of options before sending value
* fix linting issue
* fragment update
(cherry picked from commit 626ee3115d)
Co-authored-by: Bob Mroczka <bob@mroczka.com>
pipx: accept python version specs in parameter `name` (#10031)
* pipx: accept python version specs in parameter "name"
* pipx_info: adjustment for backward compatibility
* remove unnecessary comprehension
* remove f-str
* no shebang for module utils
* remove f-str
* fix syntax error
* fix pipx_info
* rollback adjustments in existing tests
* docs & test update
* add debugging tasks to int test
* integration test checks for version of packaging
* move assertion to block
* fix idempotency when using version specifier
* add changelog frag
* fix docs
* dial down the version of tox used in tests
To accommodate old Pythons
* Update plugins/modules/pipx.py
* Apply suggestions from code review
* refactor/rename package requirements code
* fix filename in BOTMETA
* Update plugins/modules/pipx.py
* Update plugins/modules/pipx.py
* pipx mod utils: create make_process_dict and deprecate make_process_list
* pkg_req: make method private
* make_process_dict is simpler and more specialized
* ensure version specifiers are honored when state=install
* fix insanity
* pipx: reformat yaml blocks
* pipx: doc wordsmithing
---------
(cherry picked from commit 2b4cb6dabc)
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Fix#10120. Split key=value where value may comprise = (#10121)
* Fix#10120. Split key=value where value may comprise =
* Added fragment.
* Update plugins/modules/sysrc.py
* Update changelogs/fragments/10121-sysrc-fix-split-first-separator.yml
---------
(cherry picked from commit de60ea1da4)
Co-authored-by: Vladimir Botka <vbotka@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
lxc: fix unit tests (#10115)
Don't compare strings passed through set_option()/get_option() with 'is'.
(cherry picked from commit 86507e8aca)
Co-authored-by: Felix Fontein <felix@fontein.de>
antsibull-nox: use community.crypto 2.x.y for ansible-core < 2.17 (#10106)
Use community.crypto 2.x.y for ansible-core < 2.17.
(cherry picked from commit 94acd18052)
Co-authored-by: Felix Fontein <felix@fontein.de>
CI: Use community.crypto 2.x.y for ansible-core 2.16 and before (#10086)
* Use community.crypto 2.x.y for ansible-core 2.16 and before.
* Also use stable-2 for ubuntu2004 tests.
(cherry picked from commit 60f1169d42)
Co-authored-by: Felix Fontein <felix@fontein.de>
nmcli: fix misspelled option in example (#10075)
Fix misspelled option.
(cherry picked from commit d89a0bbc0e)
Co-authored-by: Felix Fontein <felix@fontein.de>
crypttab: removes jijna delimiters from example using when (#10079)
The current example includes extra jinja delimiters which
result in double-interpretation of the statement.
Fixes: #10078
(cherry picked from commit 1936fe5181)
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
cobbler.inventory: Allow collecting fully rendered facts (#9975)
Add facts_level option to cobbler inventory plugin, cleanpu
Initialize connection in parse()
Handle rendered system data in _get_systems() so it can be cached
(cherry picked from commit 7524e74bb7)
Signed-off-by: Orion Poplawski <orion@nwra.com>
Co-authored-by: Orion Poplawski <orion@nwra.com>
Co-authored-by: Tyler Phillippe <tylerphillippe@tutamail.com>
Add xdg_mime module (#10007)
* Add version of xdg_mime module
* Fix xdg_mime_get since the command is different
* Add query parameter
* Fix order of parameters
* Add myself to BOTMETA
* Add unit tests
* Fix the way we deal when there is no handler set
* Improve documentation
* Remove unused import
* Fix documentation
* Strip xdg-mime from version string
* Fix information about version
* Add error message sample
* Add test to invalid handler
* Add support to multiple mime-types
* Change the output parameter from handlers to handler
* Change tests related to multiple mime-type support
* Small fixes
* Stop using constant to enable changed state
* Add before_handlers and after_handlers
* Change tests to use before and after structures
* Add a stronger message about using a non-installed handler
* Manage some edge cases
* Change error message to match the new value
* Add some fixes
* Change some tests
* Update plugins/modules/xdg_mime.py
* Remove a blank line
* Remove single quote
* Add xdg-mime to the version in the mocks
* Remove after_handlers and make code simpler
* Update tests to work without after_handlers
* Remove diff_params and clean output_params
* Make mime_type plural since it supports multiple items
* Move the handler check to module init
* Use anchors in the test to make yaml simpler
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Update plugins/modules/xdg_mime.py
* Add blank line to separe examples
* Update plugins/modules/xdg_mime.py
* Add a small homage to my late grandma
* Update plugins/modules/xdg_mime.py
* Fix pep8 problem with the homage
* Remove trailing whitespace
* Update plugins/modules/xdg_mime.py
---------
(cherry picked from commit 373334d668)
Co-authored-by: Marcos Alano <mhalano@users.noreply.github.com>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Mark supervisorctl tests as unstable (#10057)
Mark supervisorctl tests as unstable.
(cherry picked from commit a720e99482)
Co-authored-by: Felix Fontein <felix@fontein.de>
Remove FreeBSD 14.0 from CI (#10051)
Remove FreeBSD 14.0 from CI.
In ansible-core it has been replaced with 14.1, but we're already testing against that.
Ref: 3546111f2d
(cherry picked from commit 4a2920b0fd)
Co-authored-by: Felix Fontein <felix@fontein.de>
Add support for addressing subgroups by paths to the keycloak_user module (#9898)
* Add support for addressing subgroups by paths to the keycloak_user module (issue #9647)
* Apply suggestions from code review.
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 6e384a1c6a)
Co-authored-by: Christian Schlichtherle <christian@schlichtherle.de>
Remove blanket skips for Python 3 in CI (#10043)
* Remove blanket skips for Python 3 in CI.
* Try to fix hg tests.
* Disable hg tests.
* Drop restriction of supervisor to <4.0.0.
This was introduced in https://github.com/ansible/ansible/pull/54935.
* Make tests work with supervisorctl 4.0.0.
According to https://supervisord.org/changes.html#id12,
"supervisorctl will now set its exit code to a non-zero value when an error condition occurs."
I'm not sure why a stopped service in 'status' constitutes an error condition,
but whatever 🤷...
* Use correct Python executable.
* Skip RHEL/macOS; diff on config write.
* Skip CentOS 7 and OpenSuSE on ansible-core 2.16.
(cherry picked from commit 2a5abab738)
Co-authored-by: Felix Fontein <felix@fontein.de>
fixed hidden warnings from extra tests - batch 3 (#10029)
* fixed hidden warnings from extra tests - batch 3
* add empty lines to separate sections of the EXAMPLE block
* Apply suggestions from code review
* Update plugins/modules/nmcli.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 73178e3d33)
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Use antsibull-nox instead of extra sanity test runner and extra workflows (#10022)
* Use antsibull-nox instead of extra sanity test runner and extra workflows.
* Avoid sys.argv[0].
(cherry picked from commit 3ee55c6828)
Allowing uppercase tags in proxmox & proxmox_kvm (#10024)
* Allowing uppercase tags in proxmox & proxmox_kvm
* Fix#9895 : fixes the 'not a valid tag' error message when the VM or container tag contains uppercase characters
* Add PR URL to changelog fragment.
---------
Co-authored-by: s1githug <sgithug@free.fr>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ce421dbd7d)
Co-authored-by: s1github <sgithub@free.fr>
fix: github_deploy_key check key exists on 422 (#10011)
* fix: github_deploy_key check key exists on 422
If we get a 422 response code as we add a key, check if it's because the key already exists or for another reason.
fixes: #6718
* chore: add changelog 10011-github_deploy_key-check-key-present
* chore: fix changelog fragment
* chore: fix changelog fragment
* Update changelog fragment.
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit c248073079)
Co-authored-by: Alex Garel <alex@garel.org>
Homebrew: Emit a useful error message if brew info reports a package tap is null. (#10013)
* Fix#10012.
Homebrew: Emit a useful error message if a package tap is null. This can happen if an installed package is subsequently removed from the tap (e.g. it is withdrawn by homebrew).
* Added changelogs fragment for PR 10013
* Do not raise error when tap is null in package_detail
pylint: remove trailing whitespace
* Minor: Update plugins/modules/homebrew.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Minor: Update changelogs/fragments/10012-improve-error-handling-homebrew-missing-tap.yml
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
* Update plugins/modules/homebrew.py
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 4b9373f694)
Co-authored-by: brad2014 <brad2014@users.noreply.github.com>
add the wsl connection plugin (#9795)
* add the wsl connection plugin
* move the banner_timeout required paramiko version to its own line
* document the proxy_command required paramiko version
* document the timeout required paramiko version
* simplify the sending of the become_pass value
* add Connection.__init__ type hints
* add MyAddPolicy.missing_host_key type hints
* normalize the Connection._parse_proxy_command replacers dict values to the str type
* add the user_known_hosts_file option
* modify the private_key_file option type to path
(cherry picked from commit 96b493002c)
Co-authored-by: Rui Lopes <rgl@ruilopes.com>
param pkcs12_alias and cert_alias to be optional in java_cert module (#9970)
* changed pkcs12_alias and cert_alias to be optional when importing pkcs12 certificate in keystore
* Add changelog fragment
* Update changelogs/fragments/9970-pkcs12_alias_cert_alias_optional.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/9970-pkcs12_alias_cert_alias_optional.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 42a161abf5)
Co-authored-by: Emanuele Bernardi <e.berna@gmail.com>
improve ansible_host in proxmox inventory plugin (#9952)
* improve ansible_host in proxmox inventory plugin
I had this issue myself and found out there was already an issue thread:
https://github.com/ansible-collections/community.general/issues/5906
this fixes the issue for hope we can all benefit after this gets merged
* f string styling
* add log line for the successful address selection
* remove white space
* add changelog: 9952-proxmox-inventory-plugin-improve-ansible_host.yml
* Update changelogs/fragments/9952-proxmox-inventory-plugin-improve-ansible_host.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
---------
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1243846c3a)
Co-authored-by: Stein van Broekhoven <stein@aapjeisbaas.nl>
Fix typo in rpm_ostree_pkg documentation example (#9999)
Fix typo in rpm_ostree_pkg examples
The example showing use of a delay to improve resiliency misspelled 'delay'
(cherry picked from commit 216e7dc06b)
Co-authored-by: Jeffrey Borcean <jjborcean@gmail.com>
