ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-04-05 02:00:30 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

improve ansible_host in proxmox inventory plugin

Browse source 
I had this issue myself and found out there was already an issue thread:

https://github.com/ansible-collections/community.general/issues/5906

this fixes the issue for hope we can all benefit after this gets merged
This commit is contained in:
Stein van Broekhoven 2025-04-01 13:52:48 +02:00 • committed by GitHub
parent 70b5e362f9
commit aaa1ac1f60
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
plugins/inventory/proxmox.py
View file

@ -364,13 +364,27 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
return ret['members']
def _get_node_ip(self, node):
ret = self._get_json(f"{self.proxmox_url}/api2/json/nodes/{node}/network")
ret = self._get_json("%s/api2/json/nodes/%s/network" % (self.proxmox_url, node))
# sort interface by iface name to make selection as stable as possible
ret.sort(key=lambda x: x['iface'])
for iface in ret:
try:
# only process interfaces adhering to these rules
if 'active' not in iface:
self.display.vvv("Interface %s on node %s does not have an active state" % (iface['iface'], node))
continue
if 'address' not in iface:
self.display.vvv("Interface %s on node %s does not have an address" % (iface['iface'], node))
continue
if 'gateway' not in iface:
self.display.vvv("Interface %s on node %s does not have a gateway" % (iface['iface'], node))
continue
return iface['address']
except Exception:
return None
continue
return None
def _get_lxc_interfaces(self, properties, node, vmid):
status_key = self._fact('status')