From aaa1ac1f60bfe1f2b96d25a2985b9549cbad4b51 Mon Sep 17 00:00:00 2001 From: Stein van Broekhoven Date: Tue, 1 Apr 2025 13:52:48 +0200 Subject: [PATCH] improve ansible_host in proxmox inventory plugin I had this issue myself and found out there was already an issue thread: https://github.com/ansible-collections/community.general/issues/5906 this fixes the issue for hope we can all benefit after this gets merged --- plugins/inventory/proxmox.py | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/plugins/inventory/proxmox.py b/plugins/inventory/proxmox.py index f2efef9bf8..1fd8abad02 100644 --- a/plugins/inventory/proxmox.py +++ b/plugins/inventory/proxmox.py @@ -364,13 +364,27 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable): return ret['members'] def _get_node_ip(self, node): - ret = self._get_json(f"{self.proxmox_url}/api2/json/nodes/{node}/network") + ret = self._get_json("%s/api2/json/nodes/%s/network" % (self.proxmox_url, node)) + # sort interface by iface name to make selection as stable as possible + ret.sort(key=lambda x: x['iface']) + for iface in ret: try: + # only process interfaces adhering to these rules + if 'active' not in iface: + self.display.vvv("Interface %s on node %s does not have an active state" % (iface['iface'], node)) + continue + if 'address' not in iface: + self.display.vvv("Interface %s on node %s does not have an address" % (iface['iface'], node)) + continue + if 'gateway' not in iface: + self.display.vvv("Interface %s on node %s does not have a gateway" % (iface['iface'], node)) + continue return iface['address'] except Exception: - return None + continue + return None def _get_lxc_interfaces(self, properties, node, vmid): status_key = self._fact('status')