ansible-collections/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2025-08-04 05:04:22 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Disable pipelining for doas and machinectl on ansible-core 2.19+ (#10537)

Browse source 
Disable pipelining for doas and machinectl.
This commit is contained in:
Felix Fontein 2025-08-02 16:41:58 +02:00 • committed by GitHub
commit 9a29622584
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
changelogs/fragments/become-pipelining.yml Normal file
View file

@ -0,0 +1,3 @@
bugfixes:
- "doas become plugin - disable pipelining on ansible-core 2.19+. The plugin does not work with pipelining, and since ansible-core 2.19 become plugins can indicate that they do not work with pipelining (https://github.com/ansible-collections/community.general/issues/9977, https://github.com/ansible-collections/community.general/pull/10537)."
- "machinectl become plugin - disable pipelining on ansible-core 2.19+. The plugin does not work with pipelining, and since ansible-core 2.19 become plugins can indicate that they do not work with pipelining (https://github.com/ansible-collections/community.general/pull/10537)."

7
plugins/become/doas.py
View file

@ -83,6 +83,9 @@ options:
- name: ansible_doas_prompt_l10n - name: ansible_doas_prompt_l10n
env: env:
- name: ANSIBLE_DOAS_PROMPT_L10N - name: ANSIBLE_DOAS_PROMPT_L10N
notes:
- This become plugin does not work when connection pipelining is enabled. With ansible-core 2.19+, using it automatically
disables pipelining. On ansible-core 2.18 and before, pipelining must explicitly be disabled by the user.
""" """
import re import re
@ -99,6 +102,10 @@ class BecomeModule(BecomeBase):
fail = ('Permission denied',) fail = ('Permission denied',)
missing = ('Authorization required',) missing = ('Authorization required',)
# See https://github.com/ansible-collections/community.general/issues/9977,
# https://github.com/ansible/ansible/pull/78111
pipelining = False
def check_password_prompt(self, b_output): def check_password_prompt(self, b_output):
''' checks if the expected password prompt exists in b_output ''' ''' checks if the expected password prompt exists in b_output '''

6
plugins/become/machinectl.py
View file

@ -75,6 +75,8 @@ notes:
of C(machinectl). This rule must alter the prompt behaviour to ask directly for the user credentials, if the user is allowed of C(machinectl). This rule must alter the prompt behaviour to ask directly for the user credentials, if the user is allowed
to perform the action (take a look at the examples section). If such a rule is not present the plugin only works if it to perform the action (take a look at the examples section). If such a rule is not present the plugin only works if it
is used in context with the root user, because then no further prompt is shown by C(machinectl). is used in context with the root user, because then no further prompt is shown by C(machinectl).
- This become plugin does not work when connection pipelining is enabled. With ansible-core 2.19+, using it automatically
disables pipelining. On ansible-core 2.18 and before, pipelining must explicitly be disabled by the user.
""" """
EXAMPLES = r""" EXAMPLES = r"""
@ -107,6 +109,10 @@ class BecomeModule(BecomeBase):
success = ('==== AUTHENTICATION COMPLETE ====',) success = ('==== AUTHENTICATION COMPLETE ====',)
require_tty = True # see https://github.com/ansible-collections/community.general/issues/6932 require_tty = True # see https://github.com/ansible-collections/community.general/issues/6932
# See https://github.com/ansible/ansible/issues/81254,
# https://github.com/ansible/ansible/pull/78111
pipelining = False
@staticmethod @staticmethod
def remove_ansi_codes(line): def remove_ansi_codes(line):
return ansi_color_codes.sub(b"", line) return ansi_color_codes.sub(b"", line)