From f47b949c986d9d497ece8558c8896b1c6f5082a4 Mon Sep 17 00:00:00 2001 From: Ryon Coleman Date: Wed, 22 Jan 2025 16:52:59 -0500 Subject: [PATCH] Remove source links --- .../support/step_definitions/commonSteps.js | 7 +- client/package-lock.json | 5 - client/src/components/J40Footer/J40Footer.tsx | 15 --- .../__snapshots__/J40Footer.spec.tsx.snap | 35 ------- client/src/pages/about.tsx | 19 +--- .../tests/__snapshots__/about.test.tsx.snap | 99 +------------------ .../tests/__snapshots__/contact.test.tsx.snap | 35 ------- .../__snapshots__/downloads.test.tsx.snap | 35 ------- .../freqAskedQuestions.test.tsx.snap | 35 ------- .../__snapshots__/methodology.test.tsx.snap | 35 ------- .../tests/__snapshots__/privacy.test.tsx.snap | 35 ------- .../techSupportDoc.test.tsx.snap | 35 ------- 12 files changed, 9 insertions(+), 381 deletions(-) diff --git a/client/cypress/support/step_definitions/commonSteps.js b/client/cypress/support/step_definitions/commonSteps.js index e1cb9e15..cd14ed42 100644 --- a/client/cypress/support/step_definitions/commonSteps.js +++ b/client/cypress/support/step_definitions/commonSteps.js @@ -30,11 +30,14 @@ When(`I click on the {string} button in the navigation`, (page) => { When(`I look for the {string} CTA`, (ctaString) => { cy.get(`[data-cy="${hyphenizeString(ctaString)}-block"]`).as('CTA_block'); - cy.get('@CTA_block').scrollIntoView().should('be.visible'); + cy.get('@CTA_block').scrollIntoView(); + cy.get('@CTA_block').should('be.visible'); }); When(`I look for the {string}`, (footer) => { - cy.get(`[data-cy="${hyphenizeString(footer)}-primary-block"]`).scrollIntoView().should('be.visible'); + cy.get(`[data-cy="${hyphenizeString(footer)}-primary-block"]`).as('string_block'); + cy.get('@string_block').scrollIntoView(); + cy.get('@string_block').should('be.visible'); }); // Common Thens: diff --git a/client/package-lock.json b/client/package-lock.json index 1ba5cb45..5d4be5d6 100644 --- a/client/package-lock.json +++ b/client/package-lock.json @@ -4,11 +4,6 @@ "lockfileVersion": 1, "requires": true, "dependencies": { - "-": { - "version": "0.0.1", - "resolved": "https://registry.npmjs.org/-/-/--0.0.1.tgz", - "integrity": "sha512-3HfneK3DGAm05fpyj20sT3apkNcvPpCuccOThOPdzz8sY7GgQGe0l93XH9bt+YzibcTIgUAIMoyVJI740RtgyQ==" - }, "@adobe/css-tools": { "version": "4.2.0", "resolved": "https://registry.npmjs.org/@adobe/css-tools/-/css-tools-4.2.0.tgz", diff --git a/client/src/components/J40Footer/J40Footer.tsx b/client/src/components/J40Footer/J40Footer.tsx index 2cf818b1..68f18ad0 100644 --- a/client/src/components/J40Footer/J40Footer.tsx +++ b/client/src/components/J40Footer/J40Footer.tsx @@ -12,9 +12,7 @@ import LinkTypeWrapper from '../LinkTypeWrapper'; import SurveyButton from '../SurveyButton'; // @ts-ignore -import {GITHUB_LINK, GITHUB_LINK_ES} from '../../constants'; import {PAGES_ENDPOINTS} from '../../data/constants'; -import * as ABOUT_COPY from '../../data/copy/about'; import * as COMMON_COPY from '../../data/copy/common'; import whitehouseIcon from '../../images/eop-seal.svg'; @@ -64,19 +62,6 @@ const J40Footer = () => { dataCy={hyphenizeString(COMMON_COPY.FOOTER.FIND_CONTACT.defaultMessage)} />, ], - [ - intl.formatMessage(COMMON_COPY.FOOTER.CONTRIBUTE), - , - ], ]; // see https://designsystem.digital.gov/components/footer/ diff --git a/client/src/components/J40Footer/__snapshots__/J40Footer.spec.tsx.snap b/client/src/components/J40Footer/__snapshots__/J40Footer.spec.tsx.snap index dcd2f459..dcf9b68e 100644 --- a/client/src/components/J40Footer/__snapshots__/J40Footer.spec.tsx.snap +++ b/client/src/components/J40Footer/__snapshots__/J40Footer.spec.tsx.snap @@ -114,41 +114,6 @@ exports[`J40Footer renders correctly 1`] = ` -
-
-
- Want to contribute? -
- -
-
diff --git a/client/src/pages/about.tsx b/client/src/pages/about.tsx index d9907630..4e3e01b5 100644 --- a/client/src/pages/about.tsx +++ b/client/src/pages/about.tsx @@ -11,7 +11,6 @@ import J40MainGridContainer from '../components/J40MainGridContainer'; import Layout from '../components/layout'; import SubPageNav from '../components/SubPageNav'; -import {GITHUB_LINK, GITHUB_LINK_ES} from '../constants'; import {DATA_SURVEY_LINKS, PAGES_ENDPOINTS, USWDS_BREAKPOINTS} from '../data/constants'; import * as ABOUT_COPY from '../data/copy/about'; import {FEEDBACK_EMAIL} from '../data/copy/common'; @@ -20,8 +19,6 @@ import {FEEDBACK_EMAIL} from '../data/copy/common'; import commentIcon from // @ts-ignore '/node_modules/uswds/dist/img/usa-icons/comment.svg'; -import githubIcon from // @ts-ignore - '/node_modules/uswds/dist/img/usa-icons/github.svg'; interface IAboutPageProps { location: Location; @@ -113,19 +110,9 @@ const AboutPage = ({location}: IAboutPageProps) => {

- -

- {intl.formatMessage(ABOUT_COPY.GET_INVOLVED.JOIN_OSC_INFO)} -

- +
+ {/* spacer */} +
diff --git a/client/src/pages/tests/__snapshots__/about.test.tsx.snap b/client/src/pages/tests/__snapshots__/about.test.tsx.snap index 96d8cbac..6d39171c 100644 --- a/client/src/pages/tests/__snapshots__/about.test.tsx.snap +++ b/client/src/pages/tests/__snapshots__/about.test.tsx.snap @@ -558,69 +558,7 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis
-
-
- Join the open source community -
-
-
-

- Join the open source community -

-

- - The tool’s code is open source, which means it is available for the public to view and contribute to it. - -

-
- - Check it out on GitHub - -   - - New Location - -
-
-
-
- -
-
-
+ />
-
-
-
- Want to contribute? -
- -
-
diff --git a/client/src/pages/tests/__snapshots__/contact.test.tsx.snap b/client/src/pages/tests/__snapshots__/contact.test.tsx.snap index cd223705..ab6d97d6 100644 --- a/client/src/pages/tests/__snapshots__/contact.test.tsx.snap +++ b/client/src/pages/tests/__snapshots__/contact.test.tsx.snap @@ -569,41 +569,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis -
-
-
- Want to contribute? -
- -
-
diff --git a/client/src/pages/tests/__snapshots__/downloads.test.tsx.snap b/client/src/pages/tests/__snapshots__/downloads.test.tsx.snap index 67a149f3..171c9313 100644 --- a/client/src/pages/tests/__snapshots__/downloads.test.tsx.snap +++ b/client/src/pages/tests/__snapshots__/downloads.test.tsx.snap @@ -701,41 +701,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis -
-
-
- Want to contribute? -
- -
-
diff --git a/client/src/pages/tests/__snapshots__/freqAskedQuestions.test.tsx.snap b/client/src/pages/tests/__snapshots__/freqAskedQuestions.test.tsx.snap index dafa7040..01ff6a22 100644 --- a/client/src/pages/tests/__snapshots__/freqAskedQuestions.test.tsx.snap +++ b/client/src/pages/tests/__snapshots__/freqAskedQuestions.test.tsx.snap @@ -1231,41 +1231,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis -
-
-
- Want to contribute? -
- -
-
diff --git a/client/src/pages/tests/__snapshots__/methodology.test.tsx.snap b/client/src/pages/tests/__snapshots__/methodology.test.tsx.snap index 741adab3..06ca7ba2 100644 --- a/client/src/pages/tests/__snapshots__/methodology.test.tsx.snap +++ b/client/src/pages/tests/__snapshots__/methodology.test.tsx.snap @@ -3258,41 +3258,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis -
-
-
- Want to contribute? -
- -
-
diff --git a/client/src/pages/tests/__snapshots__/privacy.test.tsx.snap b/client/src/pages/tests/__snapshots__/privacy.test.tsx.snap index 56619389..1801c56b 100644 --- a/client/src/pages/tests/__snapshots__/privacy.test.tsx.snap +++ b/client/src/pages/tests/__snapshots__/privacy.test.tsx.snap @@ -693,41 +693,6 @@ exports[`rendering of the Privacy Policy page matches Privacy Policy page snapsh -
-
-
- Want to contribute? -
- -
-
diff --git a/client/src/pages/tests/__snapshots__/techSupportDoc.test.tsx.snap b/client/src/pages/tests/__snapshots__/techSupportDoc.test.tsx.snap index 572c41e3..9e56c8db 100644 --- a/client/src/pages/tests/__snapshots__/techSupportDoc.test.tsx.snap +++ b/client/src/pages/tests/__snapshots__/techSupportDoc.test.tsx.snap @@ -509,41 +509,6 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis -
-
-
- Want to contribute? -
- -
-