publicdata/j40-cejst-2
1
0
Fork 0
mirror of https://github.com/DOI-DO/j40-cejst-2.git synced 2025-08-14 02:44:19 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions

Open external links in new tabs (#731)

Browse source 
* Open external links in new tabs

- allow contact page mailto link opens in new tab
- allow about page mailto link opens in new tab
- comment against opening external links in same tab

* Update snapshots
This commit is contained in:
Vim 2021-09-23 00:22:15 -07:00 • committed by GitHub
commit 77a5f179a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
client/src/components/LinkTypeWrapper/index.tsx
View file

@ -17,6 +17,11 @@ interface ILinkTypeWrapper {
* instance to choose the type of link along with the props necessary to
* set new tabs, classes.
*
* Note - if the link is an external link and will not open in a new
* browser tab, ensure that hitting the back button works. This has shown to
* have errors on edge cases (ie, launching the gmail client with mailto links)
* and it is the recommendation to not have external links open in the same tab.
*
* @param props
* @returns
*/