mirror of
https://github.com/DOI-DO/j40-cejst-2.git
synced 2025-09-12 06:28:18 -07:00
Issue 105: Configure and run black and other pre-commit hooks (clean branch) (#1962)
* Configure and run `black` and other pre-commit hooks Co-authored-by: matt bowen <matthew.r.bowen@omb.eop.gov>
This commit is contained in:
Lucas Merrill Brown
GitHub
parent
baa34ec038
commit
6e6223cd5e
162 changed files with 716 additions and 602 deletions
|
|
@ -9,4 +9,4 @@ OpenStreetMap embed 1 0 The zoom controls' disabled state cannot be programmati
|
|||
MapBox GL JS API 1 0 The web map's semantic structure as a distinct piece of content cannot be programmatically determined. 1 0 Control to display attribution and feedback links is not keyboard accessible. [Github PR] 1 1 1 ChromeVox "Map" "MapBox logo link" NVDA "clickable map graphic" "MapBox logo link" 0 1 tab stop without focus indicator. [Github PR] 0 2/2 targets are too small. 0 1 0 Mapbox logo link opens in a new tab without warning. 0 The "map component" (<canvas tabindex="0">, which acts as a control to both zoom and pan the map display) is missing role. [Github PR] Control to display attribution and feedback links is missing name and role. [Github PR] 6
|
||||
Leaflet JS API 1 0 The web map's semantic structure as a distinct piece of content cannot be programmatically determined. [Github issue] The zoom controls' disabled state cannot be programmatically determined. [Github issue] 0 Some map labels (i.e. regional/districts) do not meet the minimum contrast ratio (uses OpenStreetMap tiles). 1 1 1 1 ChromeVox "Zoom in zoom out Leaflet map data copyright OpenStreetMap contributors" "Zoom in button" "Zoom out button" "Leaflet link" "OpenStreetMap link" NVDA "clickable Zoom in zoom out Leaflet map data copyright OpenStreetMap contributors zoom in button zoom in zoom out button Zoom out clickable Leaflet link a JS library for interactive maps map data copyright OpenStreetMap link contributors" "Zoom in button zoom in" "Zoom out button zoom out" "clickable Leaflet link a JS library for interactive maps" "OpenStreetMap link" 0 1 tab stop without focus indicator. 4 tab stops where focus indicators aren't persistently visible. [Github issue] 0 2/2 targets are too small. 0 1 1 0 The "map component" (<div tabindex="0">, which acts as a control to both zoom and pan the map display) is missing name and role. [Github issue] 7
|
||||
MapBox Studio embed 1 0 The "Zoom out" control's disabled state cannot be programmatically determined. [Github PR] 1 0 Control to display attribution and feedback links is not keyboard accessible. [Github PR] 1 1 1 ChromeVox "Map" "Search edit text" "Zoom in button" "Zoom out button" "Reset bearing to north button" "MapBox logo link" NVDA "MapBox Studio frame clickable map graphic" "Search edit blank" "Zoom in button zoom in" "Zoom out button zoom out" "Reset bearing to north button reset bearing to north" "MapBox logo link" 0 1 tab stop without focus indicator. [Github PR] 0 7/7 targets are too small. 1 1 0 Mapbox logo link opens in a new tab without warning. 0 The "map component" (<canvas tabindex="0">, which acts as a control to both zoom and pan the map display) is missing role. [Github PR] Control to display attribution and feedback links is missing name and role. [Github PR] 7
|
||||
Bing Maps embed 1 0 Scale bars/rulers are missing contextual information (alternatively should be hidden from ATs). 0 Some map labels (i.e. bodies of water, district labels) do not meet the minimum contrast ratio. 1 1 1 1 ChromeVox "Bing Maps interact to see more" "Current level 1 zoom in button" "Bing Maps link" "Terms link" NVDA "Bing Maps frame clickable Bing Maps interact to see more" "Current level 1 zoom in button zoom in" "Bing Maps link" "Terms link terms" 1 0 3/3 targets are too small. 1 1 0 Both the Bing Maps logo and the "Terms" link open in new windows without warning. 0 The "map component" (<div tabindex="0">, which acts as a control to both zoom and pan the map display) is missing role. 8
|
||||
Bing Maps embed 1 0 Scale bars/rulers are missing contextual information (alternatively should be hidden from ATs). 0 Some map labels (i.e. bodies of water, district labels) do not meet the minimum contrast ratio. 1 1 1 1 ChromeVox "Bing Maps interact to see more" "Current level 1 zoom in button" "Bing Maps link" "Terms link" NVDA "Bing Maps frame clickable Bing Maps interact to see more" "Current level 1 zoom in button zoom in" "Bing Maps link" "Terms link terms" 1 0 3/3 targets are too small. 1 1 0 Both the Bing Maps logo and the "Terms" link open in new windows without warning. 0 The "map component" (<div tabindex="0">, which acts as a control to both zoom and pan the map display) is missing role. 8
|
||||
|
|
|
|||
|
Can't render this file because it contains an unexpected character in line 2 and column 41.
|
|
|
@ -2,4 +2,4 @@
|
|||
Style Loaded,300.22,1195.81,331.85,4460.74,225.97,577.28
|
||||
Map Idle,1039.56,1195.63,1184.71,126.85,3837.53,2146.08
|
||||
DOM Interactive,126.88,137.59,193.75,131.33,154.01,262.01
|
||||
DOM complete,132.70,138.13,193.89,240.13,176.06,353.36
|
||||
DOM complete,132.70,138.13,193.89,240.13,176.06,353.36
|
||||
|
|
|
|||
|
|
|
@ -2,4 +2,4 @@
|
|||
Style Loaded,408.89,383.19,439.83,1782.45,147.41,0.00
|
||||
Map Idle,207.23,1263.27,1318.54,120.00,1970.86,1659.42
|
||||
DOM Interactive,146.15,108.78,171.48,124.38,143.74,269.40
|
||||
DOM complete,146.45,109.33,171.69,160.65,166.53,374.69
|
||||
DOM complete,146.45,109.33,171.69,160.65,166.53,374.69
|
||||
|
|
|
|||
|
File diff suppressed because one or more lines are too long
|
Before Width: | Height: | Size: 17 KiB After Width: | Height: | Size: 17 KiB |
|
|
@ -5,8 +5,8 @@ graph TB
|
|||
C --> |No| A{Concerns Addressed?}
|
||||
A --> |Yes| Merged
|
||||
A --> |No| Discussion
|
||||
Discussion --> O{Voting Outcome}
|
||||
Discussion --> O{Voting Outcome}
|
||||
O --> |Accepted| Merged
|
||||
O --> |Rejected| Merged
|
||||
Merged --> U[Update other Issues]
|
||||
U-->Close
|
||||
U-->Close
|
||||
|
|
|
|||
|
|
@ -5,7 +5,7 @@
|
|||
- Date: 2021-05-19
|
||||
- Tags: front-end, client
|
||||
|
||||
Technical Story: https://github.com/usds/justice40-tool/issues/44
|
||||
Technical Story: https://github.com/usds/justice40-tool/issues/44
|
||||
|
||||
## Context and Problem Statement
|
||||
|
||||
|
|
@ -38,7 +38,7 @@ We need to decide what framework to use for our front end client.
|
|||
|
||||
## Decision Outcome
|
||||
|
||||
Chosen option: Gatsby, because it seems to hit the balance between being simple and static-site focused and having capabilities for scaling up features and eventually evolving to a full stack application should we need it.
|
||||
Chosen option: Gatsby, because it seems to hit the balance between being simple and static-site focused and having capabilities for scaling up features and eventually evolving to a full stack application should we need it.
|
||||
|
||||
### Positive Consequences <!-- optional -->
|
||||
|
||||
|
|
|
|||
|
|
@ -5,7 +5,7 @@
|
|||
- Date: 2021-05-18
|
||||
- Tags: Hosting, Server, Geoplatform
|
||||
|
||||
Technical Story: https://github.com/usds/justice40-tool/issues/18 + https://github.com/usds/justice40-tool/issues/36
|
||||
Technical Story: https://github.com/usds/justice40-tool/issues/18 + https://github.com/usds/justice40-tool/issues/36
|
||||
|
||||
## Context and Problem Statement
|
||||
We need a host for our data pipeline and front end website/app.
|
||||
|
|
@ -15,7 +15,7 @@ We need a host for our data pipeline and front end website/app.
|
|||
- **Speed of launch** - We have a mandate to launch an initial version of our tool by July 27, and we want to get an informational site up much sooner.
|
||||
- **Support for continuous integration and delivery** - We need our hosting provider to support a modern software development lifecycle that includes continuous integration and delivery, such as integration with our Github repository and CI/CD tool such as Github Actions.
|
||||
- **Ease of implementation** - Ideally we can choose a platform that some of the team has experience with, that doesn't have a steep learning curve, and/or that has good support.
|
||||
- **Commitment to open source and process** - Any code used for servers, data processing, or front end hosting must be able to be open source, so there cannot be limitations with regard to where/how code is hosted and shared.
|
||||
- **Commitment to open source and process** - Any code used for servers, data processing, or front end hosting must be able to be open source, so there cannot be limitations with regard to where/how code is hosted and shared.
|
||||
|
||||
|
||||
## Considered Options
|
||||
|
|
@ -25,7 +25,7 @@ We need a host for our data pipeline and front end website/app.
|
|||
|
||||
## Decision Outcome
|
||||
|
||||
We will use Geoplatform.gov for hosting our data pipeline, tile server, and front end client. They have a set of shared service offerings that will enable us to have an open data pipeline from data source to tile API, enabling contributions to data processing at any point as well as enabling data access for users at any point (e.g. whether a user wants to access raw data or GeoJSON or tile format). The diagram below illustrates the proposed system architecture and hosting:
|
||||
We will use Geoplatform.gov for hosting our data pipeline, tile server, and front end client. They have a set of shared service offerings that will enable us to have an open data pipeline from data source to tile API, enabling contributions to data processing at any point as well as enabling data access for users at any point (e.g. whether a user wants to access raw data or GeoJSON or tile format). The diagram below illustrates the proposed system architecture and hosting:
|
||||
|
||||
|
||||
|
||||
|
|
@ -34,11 +34,11 @@ We will use Geoplatform.gov for hosting our data pipeline, tile server, and fron
|
|||
- No need to stand up our own servers for data processing or vending tiles
|
||||
- No need to find separate static site hosting for our front end
|
||||
- Help advance shared geo services for government
|
||||
- Code for data transformations can live on an open Github repo and be collaborated on by the community
|
||||
- Code for data transformations can live on an open Github repo and be collaborated on by the community
|
||||
|
||||
### Negative Consequences
|
||||
|
||||
- Possible delays or additional work: Some features and offerings we may want to use are still a work in progress on Geoplatform's side, so we may have to help build these out or wait for their release.
|
||||
- Possible delays or additional work: Some features and offerings we may want to use are still a work in progress on Geoplatform's side, so we may have to help build these out or wait for their release.
|
||||
|
||||
## Pros and Cons of Other Options
|
||||
|
||||
|
|
@ -56,4 +56,3 @@ Cons:
|
|||
- Would not have the flexibility to easily run serverless functions if we needed to
|
||||
|
||||
## Links <!-- optional -->
|
||||
|
||||
|
|
|
|||
File diff suppressed because one or more lines are too long
|
Before Width: | Height: | Size: 21 KiB After Width: | Height: | Size: 21 KiB |
|
|
@ -8,8 +8,8 @@ graph TB
|
|||
C --> |No| A{Concerns Addressed?}
|
||||
A --> |Yes| PR
|
||||
A --> |No| IP["In Person Discussion"]
|
||||
IP --> O{Voting Outcome}
|
||||
IP --> O{Voting Outcome}
|
||||
O --> |Accepted - add label | PR
|
||||
O --> |Rejected - add label | PR
|
||||
PR --> PRP["Standard PR Process"]
|
||||
PRP --> Close
|
||||
PRP --> Close
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue