Issue 308 python linting (#443)

* Adds flake8, pylint, liccheck, flake8 to dependencies for data-pipeline

* Sets up and runs black autoformatting

* Adds flake8 to tox linting

* Fixes flake8 error F541 f string missing placeholders

* Fixes flake8 E501 line too long

* Fixes flake8 F401 imported but not used

* Adds pylint to tox and disables the following pylint errors:
- C0114: module docstrings
- R0201: method could have been a function
- R0903: too few public methods
- C0103: name case styling
- W0511: fix me
- W1203: f-string interpolation in logging

* Adds utils.py to tox.ini linting, runs black on utils.py

* Fixes import related pylint errors: C0411 and C0412

* Fixes or ignores remaining pylint errors (for discussion later)

* Adds safety and liccheck to tox.ini

data/data-pipeline/etl/sources/census/etl.py

@@ -1,11 +1,12 @@
-import csv
 import os
+import csv
 import json
 from pathlib import Path
+
 import geopandas as gpd
 
-from .etl_utils import get_state_fips_codes
 from utils import unzip_file_from_url, get_module_logger
+from .etl_utils import get_state_fips_codes
 
 logger = get_module_logger(__name__)
 
@@ -29,9 +30,7 @@ def download_census_csvs(data_path: Path) -> None:
 
     for fips in state_fips_codes:
         # check if file exists
-        shp_file_path = (
-            data_path / "census" / "shp" / fips / f"tl_2010_{fips}_bg10.shp"
-        )
+        shp_file_path = data_path / "census" / "shp" / fips / f"tl_2010_{fips}_bg10.shp"
 
         logger.info(f"Checking if {fips} file exists")
         if not os.path.isfile(shp_file_path):
@@ -110,7 +109,7 @@ def download_census_csvs(data_path: Path) -> None:
             )
 
     ## create national geojson
-    logger.info(f"Generating national geojson file")
+    logger.info("Generating national geojson file")
     usa_df = gpd.GeoDataFrame()
 
     for file_name in geojson_dir_path.rglob("*.json"):
@@ -119,7 +118,7 @@ def download_census_csvs(data_path: Path) -> None:
         usa_df = usa_df.append(state_gdf)
 
     usa_df = usa_df.to_crs("+proj=longlat +ellps=WGS84 +datum=WGS84 +no_defs")
-    logger.info(f"Writing national geojson file")
+    logger.info("Writing national geojson file")
     usa_df.to_file(geojson_dir_path / "us.json", driver="GeoJSON")
 
     logger.info("Census block groups downloading complete")

data/data-pipeline/etl/sources/census/etl_utils.py

@@ -1,7 +1,8 @@
-from pathlib import Path
-import csv
-import pandas as pd
 import os
+import csv
+
+from pathlib import Path
+import pandas as pd
 from config import settings
 
 from utils import (
@@ -35,7 +36,7 @@ def get_state_fips_codes(data_path: Path) -> list:
 
     # check if file exists
     if not os.path.isfile(fips_csv_path):
-        logger.info(f"Downloading fips from S3 repository")
+        logger.info("Downloading fips from S3 repository")
         unzip_file_from_url(
             settings.AWS_JUSTICE40_DATA_URL + "/Census/fips_states_2010.zip",
             data_path / "tmp",