updated to fix linting errors (#1818)

Cleans and updates base branch

data/data-pipeline/data_pipeline/etl/score/constants.py

@@ -294,10 +294,10 @@ TILES_SCORE_COLUMNS = {
     # These are the booleans for socioeconomic indicators
     ## this measures low income boolean
     field_names.FPL_200_SERIES: "FPL200S",
-    ## Low high school and low higher ed for t&wd
+    ## Low high school for t&wd
     field_names.WORKFORCE_SOCIO_INDICATORS_EXCEEDED: "M_WKFC_EBSI",
-    ## FPL 200 and low higher ed for all others
-    field_names.FPL_200_SERIES: "M_EBSI",
+    ## FPL 200 and low higher ed for all others should no longer be M_EBSI, but rather
+    ## FPL_200 (there is no higher ed in narwhal)
 }
 
 # columns to round floats to 2 decimals

data/data-pipeline/data_pipeline/etl/score/etl_score.py

@@ -1,6 +1,5 @@
 import functools
 from collections import namedtuple
-from attr import field
 
 import numpy as np
 import pandas as pd

data/data-pipeline/data_pipeline/etl/score/etl_score_geo.py

@@ -289,7 +289,7 @@ class GeoScoreETL(ExtractTransformLoad):
             shapefile_column_field = "shapefile_column"
             internal_column_name_field = "column_name"
             column_description_field = "column_description"
-            
+
             logger.info("Creating a codebook that uses the csv names")
             codebook = (
                 pd.Series(codebook)
@@ -299,7 +299,6 @@ class GeoScoreETL(ExtractTransformLoad):
                         0: internal_column_name_field,
                         "index": shapefile_column_field,
                     }
-
                 )
             )
 

data/data-pipeline/data_pipeline/etl/sources/census_acs/etl.py

@@ -238,6 +238,7 @@ class CensusACSETL(ExtractTransformLoad):
 
         self.df: pd.DataFrame
 
+    # pylint: disable=too-many-arguments
     def _merge_geojson(
         self,
         df: pd.DataFrame,

data/data-pipeline/data_pipeline/etl/sources/census_acs/etl_imputations.py

@@ -1,10 +1,11 @@
 from typing import List, NamedTuple
 import pandas as pd
 import geopandas as gpd
-import numpy as np
 
 from data_pipeline.utils import get_module_logger
 
+# pylint: disable=unsubscriptable-object
+
 logger = get_module_logger(__name__)
 
 

data/data-pipeline/data_pipeline/score/score_narwhal.py

@@ -1,5 +1,4 @@
 from typing import Tuple
-from attr import field
 import numpy as np
 import pandas as pd
 

data/data-pipeline/data_pipeline/score/score_runner.py

@@ -2,7 +2,6 @@ import pandas as pd
 from data_pipeline.score.score_a import ScoreA
 from data_pipeline.score.score_b import ScoreB
 from data_pipeline.score.score_c import ScoreC
-from data_pipeline.score.score_d import ScoreD
 from data_pipeline.score.score_f import ScoreF
 from data_pipeline.score.score_g import ScoreG
 from data_pipeline.score.score_h import ScoreH
@@ -11,7 +10,6 @@ from data_pipeline.score.score_k import ScoreK
 from data_pipeline.score.score_l import ScoreL
 from data_pipeline.score.score_m import ScoreM
 from data_pipeline.score.score_narwhal import ScoreNarwhal
-from data_pipeline.score import field_names
 
 from data_pipeline.utils import get_module_logger
 

data/data-pipeline/data_pipeline/tests/sources/example/test_etl.py

@@ -1,4 +1,4 @@
-# pylint: disable=protected-access,unsubscriptable-object
+# pylint: disable=protected-access, unsubscriptable-object, unnecessary-dunder-call
 import copy
 import os
 import pathlib

data/data-pipeline/pyproject.toml

@@ -68,7 +68,6 @@ requires = ["poetry-core>=1.0.0"]
 [tool.pylint."MESSAGE CONTROL"]
 disable = [
   "C0114", # Disables module docstrings
-  "R0201", # Disables method could have been a function
   "R0903", # Disables too few public methods
   "C0103", # Disables name case styling
   "W0511", # Disables FIXME warning