mirror of
https://github.com/DOI-DO/j40-cejst-2.git
synced 2025-02-22 09:41:26 -08:00
Remove threshold line in side panel (#1666)
* Remove categories * Remove disadvantaged in sidepanel * Add comment
This commit is contained in:
Vim
GitHub
parent
9f0ca1c17d
commit
1681a72045
7 changed files with 28 additions and 41 deletions
14
.github/workflows/deploy_fe_staging.yml
vendored
14
.github/workflows/deploy_fe_staging.yml
vendored
|
|
@ -49,13 +49,13 @@ jobs:
|
|||
run: npm test
|
||||
- name: Check for security vulnerabilities
|
||||
run: npm audit --production
|
||||
# - name: Cypress / Gherkin integration tests 🌃
|
||||
# uses: cypress-io/github-action@v2
|
||||
# with:
|
||||
# working-directory: ${{env.WORKING_DIRECTORY}}
|
||||
# browser: chrome
|
||||
# start: npm start
|
||||
# wait-on: "http://localhost:8000/en"
|
||||
- name: Cypress / Gherkin integration tests 🌃
|
||||
uses: cypress-io/github-action@v2
|
||||
with:
|
||||
working-directory: ${{env.WORKING_DIRECTORY}}
|
||||
browser: chrome
|
||||
start: npm start
|
||||
wait-on: "http://localhost:8000/en"
|
||||
- name: Upload Artifact
|
||||
uses: actions/upload-artifact@v2
|
||||
with:
|
||||
|
|
|
|||
|
|
@ -599,9 +599,9 @@ const AreaDetail = ({properties, hash}: IAreaDetailProps) => {
|
|||
</div>
|
||||
|
||||
{/* Number of thresholds exceeded */}
|
||||
<div className={styles.showThresholdExceed}>
|
||||
{/* <div className={styles.showThresholdExceed}>
|
||||
{EXPLORE_COPY.numberOfThresholdsExceeded(properties[constants.TOTAL_NUMBER_OF_DISADVANTAGE_INDICATORS])}
|
||||
</div>
|
||||
</div> */}
|
||||
{/* Send Feedback button */}
|
||||
<a
|
||||
className={styles.sendFeedbackLink}
|
||||
|
|
|
|||
|
|
@ -47,11 +47,10 @@ $sidePanelLabelFontColor: #171716;
|
|||
@include u-margin-top('05');
|
||||
}
|
||||
|
||||
.showThresholdExceed {
|
||||
font-size: small;
|
||||
@include u-margin-top('05');
|
||||
|
||||
}
|
||||
// .showThresholdExceed {
|
||||
// font-size: small;
|
||||
// @include u-margin-top('05');
|
||||
// }
|
||||
|
||||
.sendFeedbackLink {
|
||||
@include u-margin-top(2);
|
||||
|
|
|
|||
|
|
@ -53,10 +53,7 @@ exports[`rendering of the AreaDetail checks if indicators for ISLAND AREAS are p
|
|||
<div />
|
||||
</div>
|
||||
<div>
|
||||
Disadvantaged in 5 categories
|
||||
</div>
|
||||
<div>
|
||||
At or above 3 thresholds
|
||||
in 5 categories
|
||||
</div>
|
||||
<a
|
||||
href="
|
||||
|
|
@ -417,10 +414,7 @@ exports[`rendering of the AreaDetail checks if indicators for NATION is present
|
|||
<div />
|
||||
</div>
|
||||
<div>
|
||||
Disadvantaged in 5 categories
|
||||
</div>
|
||||
<div>
|
||||
At or above 3 thresholds
|
||||
in 5 categories
|
||||
</div>
|
||||
<a
|
||||
href="
|
||||
|
|
@ -2156,10 +2150,7 @@ exports[`rendering of the AreaDetail checks if indicators for PUERTO RICO are pr
|
|||
<div />
|
||||
</div>
|
||||
<div>
|
||||
Disadvantaged in 5 categories
|
||||
</div>
|
||||
<div>
|
||||
At or above 3 thresholds
|
||||
in 5 categories
|
||||
</div>
|
||||
<a
|
||||
href="
|
||||
|
|
|
|||
|
|
@ -314,21 +314,22 @@ export const COMMUNITY = {
|
|||
|
||||
export const numberOfCategoriesExceeded = (categoryCount:number) => <FormattedMessage
|
||||
id={'explore.map.page.side.panel.num.categories.exceeded'}
|
||||
defaultMessage={`Disadvantaged in {numberOfDisCategories, plural, one {# category} other {# categories}}`}
|
||||
defaultMessage={`in {numberOfDisCategories, plural, one {# category} other {# categories}}`}
|
||||
description={`Navigate to the explore the map page. When the map is in view, click on the map. The side panel will show how many categories are exceeded`}
|
||||
values={{
|
||||
numberOfDisCategories: categoryCount,
|
||||
}}
|
||||
/>;
|
||||
|
||||
export const numberOfThresholdsExceeded = (thresholds:number) => <FormattedMessage
|
||||
id={'explore.map.page.side.panel.num.thresholds.exceeded'}
|
||||
defaultMessage={`At or above {numberOfThresholdExceed, plural, one {# threshold} other {# thresholds}}`}
|
||||
description={`Navigate to the explore the map page. When the map is in view, click on the map. The side panel will show how many thresholds are exceeded`}
|
||||
values={{
|
||||
numberOfThresholdExceed: thresholds,
|
||||
}}
|
||||
/>;
|
||||
// Temporarily commenting out as it may be needed again:
|
||||
// export const numberOfThresholdsExceeded = (thresholds:number) => <FormattedMessage
|
||||
// id={'explore.map.page.side.panel.num.thresholds.exceeded'}
|
||||
// defaultMessage={`At or above {numberOfThresholdExceed, plural, one {# threshold} other {# thresholds}}`}
|
||||
// description={`Navigate to the explore the map page. When the map is in view, click on the map. The side panel will show how many thresholds are exceeded`}
|
||||
// values={{
|
||||
// numberOfThresholdExceed: thresholds,
|
||||
// }}
|
||||
// />;
|
||||
|
||||
export const SEND_FEEDBACK = defineMessages({
|
||||
EMAIL_BODY: {
|
||||
|
|
|
|||
|
|
@ -784,13 +784,9 @@
|
|||
"description": "Navigate to the explore the map page. When the map is in view, click on the map. The side panel will show the communities the score currently is not focused on"
|
||||
},
|
||||
"explore.map.page.side.panel.num.categories.exceeded": {
|
||||
"defaultMessage": "Disadvantaged in {numberOfDisCategories, plural, one {# category} other {# categories}}",
|
||||
"defaultMessage": "in {numberOfDisCategories, plural, one {# category} other {# categories}}",
|
||||
"description": "Navigate to the explore the map page. When the map is in view, click on the map. The side panel will show how many categories are exceeded"
|
||||
},
|
||||
"explore.map.page.side.panel.num.thresholds.exceeded": {
|
||||
"defaultMessage": "At or above {numberOfThresholdExceed, plural, one {# threshold} other {# thresholds}}",
|
||||
"description": "Navigate to the explore the map page. When the map is in view, click on the map. The side panel will show how many thresholds are exceeded"
|
||||
},
|
||||
"explore.map.page.side.panel.send.feedback.alt.img": {
|
||||
"defaultMessage": "Send feedback",
|
||||
"description": "Navigate to the explore the map page. When the map is in view, click on the map. The side panel will show a send feedback icon, this is the images alt tag"
|
||||
|
|
|
|||
|
|
@ -199,7 +199,7 @@
|
|||
"explore.map.page.side.panel.info.title": "Lo que debe saber",
|
||||
"explore.map.page.side.panel.is.community.of.focus": "¿Está identificada como desfavorecida?",
|
||||
"explore.map.page.side.panel.not.community.of.focus": "No",
|
||||
"explore.map.page.side.panel.num.categories.exceeded": "Desfavorecida en {numberOfDisCategories, plural, one {# categoría} other {# categorías}}",
|
||||
"explore.map.page.side.panel.num.categories.exceeded": "en {numberOfDisCategories, plural, one {# categoría} other {# categorías}}",
|
||||
"explore.map.page.side.panel.num.thresholds.exceeded": "Al umbral o lo supera en {numberOfThresholdExceed, plural, one {# umbral} other {# umbrales}}",
|
||||
"explore.map.page.side.panel.send.feedback.alt.img": "Enviar comentarios",
|
||||
"explore.map.page.side.panel.send.feedback.email.body": "Aporte comentarios acerca de este grupo de bloques del censo, incluidos los conjuntos de datos, las categorías de datos proporcionadas para este grupo de bloques del censo, las comunidades que viven en este grupo de bloques del censo y toda la información pertinente que el Consejo sobre la Calidad del Medio Ambiente (CEQ, por sus siglas en inglés) debe saber acerca de este grupo de bloques del censo.",
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue