updates to PR review

This commit is contained in:
Saran Ahluwalia 2022-01-13 14:26:24 -05:00
commit 0176c770c0
2 changed files with 4 additions and 12 deletions

View file

@ -32,8 +32,6 @@ class MarylandEJScreenETL(ExtractTransformLoad):
field_names.MARYLAND_EJSCREEN_TRACT_90_PERCENTILE_FIELD, field_names.MARYLAND_EJSCREEN_TRACT_90_PERCENTILE_FIELD,
field_names.MARYLAND_EJSCREEN_SCORE_FIELD, field_names.MARYLAND_EJSCREEN_SCORE_FIELD,
field_names.MARYLAND_EJSCREEN_BURDENED_THRESHOLD_FIELD, field_names.MARYLAND_EJSCREEN_BURDENED_THRESHOLD_FIELD,
field_names.MARYLAND_EJSCREEN_SCORE_FIELD
+ field_names.PERCENTILE_FIELD_SUFFIX,
] ]
self.df: pd.DataFrame self.df: pd.DataFrame
@ -93,11 +91,8 @@ class MarylandEJScreenETL(ExtractTransformLoad):
inplace=True, inplace=True,
) )
# Interpretation: An EJ score (reported as a percentile) # This computational step will be used to establish a
# has a percentile rank of N for some N between 0 - 100" # threshold for burden (line 104)
# Please see the README and the following linksfor details and context
# 1. https://github.com/usds/justice40-tool/issues/239#issuecomment-1003448074
# 2. https://github.com/usds/justice40-tool/issues/239#issuecomment-995798345
self.df[ self.df[
field_names.MARYLAND_EJSCREEN_SCORE_FIELD field_names.MARYLAND_EJSCREEN_SCORE_FIELD
+ field_names.PERCENTILE_FIELD_SUFFIX + field_names.PERCENTILE_FIELD_SUFFIX
@ -111,7 +106,7 @@ class MarylandEJScreenETL(ExtractTransformLoad):
field_names.MARYLAND_EJSCREEN_SCORE_FIELD field_names.MARYLAND_EJSCREEN_SCORE_FIELD
+ field_names.PERCENTILE_FIELD_SUFFIX + field_names.PERCENTILE_FIELD_SUFFIX
] ]
> 0.75 >= 0.75
) )
# Baseline Comparisons with some quartiles and the 90th percent OF EJ Score # Baseline Comparisons with some quartiles and the 90th percent OF EJ Score

View file

@ -235,11 +235,8 @@ MARYLAND_EJSCREEN_TRACT_90_PERCENTILE_FIELD: str = (
MARYLAND_EJSCREEN_SCORE_FIELD: str = "Maryland Environmental Justice Score" MARYLAND_EJSCREEN_SCORE_FIELD: str = "Maryland Environmental Justice Score"
# this references percentile ranks
# please see here for interpretation: https://github.com/usds/justice40-tool/issues/239#issuecomment-1003567593
# and here: https://github.com/usds/justice40-tool/issues/239#issuecomment-1003448074
MARYLAND_EJSCREEN_BURDENED_THRESHOLD_FIELD: str = ( MARYLAND_EJSCREEN_BURDENED_THRESHOLD_FIELD: str = (
"Tract has a percentile rank above 75 for the EJ Score" "Maryland EJSCREEN Priority Community"
) )
# Child Opportunity Index data # Child Opportunity Index data