`service_account_email` defaults to None if one
is not set. For gcp_compute_instance_info, this results
in an invalid request as the service account is populated
directly in the path.
Populating `default` when a value is not set fixes the error.
fixes#568
The version_added field is documented for a very small set of
fields, specifically in gcp_compute today.
Removing these values as they are specifying the ansible-core version
which is confusing for those who are installing via ansible-galaxy,
and the value is not set for any other module.
fixes#550.
commit ccbde5f93e introduced
a backwards-incompatible change which made ansible-inventory
no longer recognize `gcp_compute` as a valid package name.
This would break users who are use `gcp_compute` (instead of the
new `google.cloud.gcp_compute`). Accepting both until at least
a major version change.
fixes#536.
Updating the maintainers guide with updated intructions from
Ansible engineers.
Fixing linting issues, and adding the linter as a GitHub workflow
to ensure there are no regressions.
gcp_spanner_database erroneously used LRO handling on delete,
rather than a standard synchronous function. One side effect
was not catching 404s as a not found error code.
skip_initial_version_creation previously defaulted to None,
which results in an invalid value in the create call to
gcp_kms_crypto_key.
Defaulting to False fixes the issue.
Incorporating a fix for GKE 1.19+ (See #444).
Inlined:
Google has removed basic-auth method from within GKE starting version 1.19
This lead the output response of the backend API not to provide basic-auth
data (username and password) anymore.
The current implementation of gcp_container_cluster when generating the kubectl
config file, always set basic-auth data w/o checking if there actually are
available or explicitly provided even when the value are not set/provided
from gcp_container_cluster.
In addition, re-enabling some tests that #444 fixed.
Co-authored-by: Xavier Lamien <laxathom@lxtnow.net>
- vpn_gateway required minimal changes (stop using legacy load
balancers)
- compute_vpn_tunnel requires a valid vpn configuration
(several dependent forwarding rules and configuration to set up a
proper tunnel).
compute selflinks return back `wwww.googleapis.com` as the domain,
which was causing a perma-diff. Fixing google.cloud's normalization
fixes that.
Fixing the following tests as well, since creating an instance
now works:
- gcp_compute_instance
- gcp_compute_instance_group
- gcp_compute_instance_group_manager
- gcp_compute_instance_template
- gcp_compute_region_autoscaler
- gcp_compute_region_instance_group_manager
- gcp_compute_target_instance
- gcp_compute_target_pool
Compute_url_map was broken by #509: It also merged in #393, which
has an erroneous understanding that compute_url_map always returns
a diff (integration tests show it does not).
Adding a cleanup script to help with environment hygiene.
Added cleanup to CI to help make tests less flakey.
with #393 merged, it is now possible to enable gcp_compute_backend_test.
Adding a temporary fix for server-normalized value of capacity_scaler,
which is resolving into perma-diff due to "1.0" != "1".
- gcp_spanner_instance works, enabling for CI.
- gcp_resourcemanager_project is running into quota issues for
listing the API to verify state. Adding a to-do as well as
removing some people-specific names.
Fixing some of the existing failing tests in the CI process.
Specifically:
- gcp_appengine_firewall_rule: modified validation to support the
default firewall rule
- gcp_cloudfunctions_cloud_function: bootstrapping the required GS
bucket and files for creating a valid cloud function.
- Slight update to the functionality, which now requires a runtime
specified for new functions.
-
* Unnecessary "else" after "return"
* Handle if service account file is missing with proper user message
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
