Commit graph

664 commits

Author SHA1 Message Date
Jorge Gallegos
6ee6b698ef
Add discard_local_ssd flag to compute instance
If you have an instance with a Local (scratch) SSD attached you need to
specify the behavior for this when changing the status to TERMINATED
i.e. stopping the instance. Without setting this flag you'll get an
error back from the API.
2025-05-28 12:33:59 -07:00
Chris Hawk
5ebc615a48 Fix doc lint errors in gcp_pubsub_subscription 2025-01-10 14:52:33 -08:00
Chris Hawk
25d53ff320 Merge branch 'master' into issue-613 2025-01-10 13:59:02 -08:00
Chris Hawk
5a395e234f
Merge pull request #652 from gomesfernandes/fix/bigquery-clustering-fields
fix: google.cloud.gcp_bigquery_table clustering fields
2024-11-11 17:05:12 -08:00
Chris Hawk
d719b0efaa
Fix a YAML doc parsing error in gcp_pubsub_subscription.py 2024-11-11 16:49:34 -08:00
Chris Hawk
68c9af276c
Update gcp_pubsub_subscription.py
Fix lint errors
2024-11-11 16:40:47 -08:00
Sieradzki, Lukasz
e89571eb91 https://github.com/ansible-collections/google.cloud/issues/657 2024-11-08 23:03:14 +01:00
Sieradzki, Lukasz
2b35fbf404 https://github.com/ansible-collections/google.cloud/issues/657 2024-11-08 23:02:23 +01:00
Sieradzki, Lukasz
8b9a2c70dd https://github.com/ansible-collections/google.cloud/issues/657 2024-11-08 18:46:49 +01:00
Sieradzki, Lukasz
6794d18478 https://github.com/ansible-collections/google.cloud/issues/653 2024-11-07 11:02:53 +01:00
Chris Hawk
537707deef Fix a compute_backend_service permadiff 2024-11-06 16:16:00 -08:00
Chris Hawk
608a8486e3 Fix many documentation lint errors 2024-11-05 14:58:14 -08:00
Chris Hawk
1a7d4e3cda Add many no_log attributes 2024-11-05 14:06:56 -08:00
Sieradzki, Lukasz
0e9c32fcde https://github.com/ansible-collections/google.cloud/issues/653 2024-11-04 21:01:26 +01:00
Caty Gomes Fernandes
30858618e5 fix: gcp_bigquery_table clustering payload 2024-10-31 18:20:15 +01:00
Chris Hawk
bc7313854d Remove an f-string usage for backward compatibility 2024-08-22 15:40:29 -07:00
Ivan Fernandez Calvo
f7140225a8
fix: support more than 10 secrets versions on gcp_secret_manager 2024-05-23 12:31:26 +02:00
Chris Hawk
a9c0624bbd
Merge pull request #578 from dcostakos/gcp_secret_manager
Adding support for Google Secret Manager for issue 543
2024-05-22 14:41:07 -07:00
Chris Hawk
811327bc09 chore: removed unused imports 2023-11-20 11:17:25 -08:00
Chris Hawk
661f114037 chore: fix a line length lint error 2023-11-17 16:47:05 -08:00
Chris Hawk
08ada5354d fix: upgrade ansible version, address test and lint errors 2023-11-17 16:39:42 -08:00
Dave Costakos
40d2c9a7d5
updated plugsins based on feedback, fixed linting and documentation errors. 2023-07-14 10:33:15 -07:00
Dave Costakos
375b317692
Merge branch 'ansible-collections:master' into gcp_secret_manager 2023-07-14 10:29:52 -07:00
Yusuke Tsutsumi
d1277f829b
fix: iam service account key path must not exist (#576)
Update docs to explain that the json secret key must not
already exist, or the module will try to read it.

fixes #370
2023-07-07 15:05:09 -07:00
Dave Costakos
953b06ff05
updated lookuup plugin based on comment https://github.com/ansible-collections/google.cloud/pull/578/files/76eb024c250af3b7ff8adec909bef06667833509# 2023-06-22 14:36:55 -07:00
Dave Costakos
76eb024c25
Adding support for Google Secret Manager for issue 543 2023-06-21 16:24:14 -07:00
Shlomo Shuck
203961b045
feat: add auth support for GCP access tokens (#574)
Introduce choice "accesstoken" for auth_kind for modules
Introduce optional access_token string param that falls back to
  GCP_ACCESS_TOKEN env var
2023-06-10 11:20:57 -07:00
Samir Faci
86e0cef208 Adding support for ip_allocation_policy->stack_type 2023-04-22 12:28:05 -07:00
Samir Faci
cd35f3bce6 Adding DataPlane V2 support.
fix for #566
2023-04-22 12:28:05 -07:00
Yusuke Tsutsumi
12438f9bfb fix: correct gcp_compute_instance_info filter docs
The link for filter documentation was pointing to
gcloud, which isn't correct as gcp_compute_instance_info
communicates with the API.

fixes #549
2023-02-18 12:20:50 -08:00
Yusuke Tsutsumi
c99ecc511f gcp_storage_object asserts for dest on upload
The `dest` field is required for upload and delete. This was not
explicitly documented nor asserted.

Fixes #235.
2023-02-03 16:48:55 -08:00
Yusuke Tsutsumi
2db181d084 fix gcp_iam_role not updating
gcp_iam_role was not updating previously. The API uses a PATCH and
not a PUT.

Also fixing an accidental leftover diff from a bad merge.

fixes #236.
2022-12-15 23:04:47 -08:00
Yusuke Tsutsumi
d063d44b73 fixing gcp_resourcemanager_project delete
gcp_resourcemanager_project was not properly deleting projects.

fixing gcp_resourcemanager_project as well.

fixes #530.
2022-12-12 22:25:24 -08:00
Yusuke Tsutsumi
a9545c77a4 fix linting and updating maintenance guide
Updating the maintainers guide with updated intructions from
Ansible engineers.

Fixing linting issues, and adding the linter as a GitHub workflow
to ensure there are no regressions.
2022-12-07 15:36:21 -08:00
Rebecca Peterson
21c9479ece Update gcp_filestore_instance.py
`filestore/docs/accessing-fileshares` has been removed and replaced with `filestore/docs/csi-driver`
2022-12-02 10:20:13 -08:00
Yusuke Tsutsumi
117224d352 fix gcp_iam_role
gcp_iam_role did not handle the undelete behavior
that is specific to gcp_iam_role.
2022-11-27 08:34:30 -08:00
Yusuke Tsutsumi
6171713572 fix gcp_bigtable_instance
gcp_bigtable_instance scope was using an incorrect scope,
which was causing oauth requests to not complete successfully.
2022-11-27 08:34:30 -08:00
Yusuke Tsutsumi
44eb7c2d29 fix gcp_spanner_database delete
gcp_spanner_database erroneously used LRO handling on delete,
rather than a standard synchronous function. One side effect
was not catching 404s as a not found error code.
2022-11-27 08:34:30 -08:00
Yusuke Tsutsumi
50076e7f36 fix: crypto_key initial_version_creation default
skip_initial_version_creation previously defaulted to None,
which results in an invalid value in the create call to
gcp_kms_crypto_key.

Defaulting to False fixes the issue.
2022-11-27 08:34:30 -08:00
Yusuke Tsutsumi
0e9f2a74b1 fix: gcp_cloudtasks_queue
gcp_cloudtasks_queue was sending a "location" field in the
payload, when the resource did not have such a field.

Removing it fixes the tests.
2022-11-27 08:34:30 -08:00
Yusuke Tsutsumi
d3a7287c37 fix: gcp_container_cluster for GKE 1.19+
Incorporating a fix for GKE 1.19+ (See #444).

Inlined:

Google has removed basic-auth method from within GKE starting version 1.19
This lead the output response of the backend API not to provide basic-auth
data (username and password) anymore.

The current implementation of gcp_container_cluster when generating the kubectl
config file, always set basic-auth data w/o checking if there actually are
available or explicitly provided even when the value are not set/provided
from gcp_container_cluster.

In addition, re-enabling some tests that #444 fixed.

Co-authored-by: Xavier Lamien <laxathom@lxtnow.net>
2022-11-19 21:58:55 -08:00
Yusuke Tsutsumi
ebf095d22d tests: fix gcp_compute_vpn_tunnel
- vpn_gateway required minimal changes (stop using legacy load
  balancers)
- compute_vpn_tunnel requires a valid vpn configuration
  (several dependent forwarding rules and configuration to set up a
  proper tunnel).
2022-11-19 18:40:44 -08:00
Yusuke Tsutsumi
0fc41bbda4 WIP: fix compute instance + several tests
compute selflinks return back `wwww.googleapis.com` as the domain,
which was causing a perma-diff. Fixing google.cloud's normalization
fixes that.

Fixing the following tests as well, since creating an instance
now works:

- gcp_compute_instance
- gcp_compute_instance_group
- gcp_compute_instance_group_manager
- gcp_compute_instance_template
- gcp_compute_region_autoscaler
- gcp_compute_region_instance_group_manager
- gcp_compute_target_instance
- gcp_compute_target_pool
2022-11-13 22:28:40 -08:00
Yusuke Tsutsumi
4816e97719 fixing compute_url_map, add cleanup script
Compute_url_map was broken by #509: It also merged in #393, which
has an erroneous understanding that compute_url_map always returns
a diff (integration tests show it does not).

Adding a cleanup script to help with environment hygiene.

Added cleanup to CI to help make tests less flakey.
2022-11-12 12:12:02 -08:00
Bill Dinger
0cece672cf Added in link to where machineTypes are defined 2022-11-12 11:18:03 -08:00
Tom
2582030e51 Updating gcp_storage_object example
The example contained the non-existent "status" parameter which causes an error with the latest release.
2022-11-12 10:53:08 -08:00
Yusuke Tsutsumi
5ea5ecda34 tests: enabling gcp_compute_backend_service test
with #393 merged, it is now possible to enable gcp_compute_backend_test.

Adding a temporary fix for server-normalized value of capacity_scaler,
which is resolving into perma-diff due to "1.0" != "1".
2022-11-05 15:16:49 -07:00
Lakhan Samani
da28bcb845 fix: fix finger print issue while updating gcp services
Resolves: https://github.com/ansible-collections/google.cloud/issues/342
2022-11-05 15:16:49 -07:00
Nonoctis
5182023c91
Docs: fix typo in gcp_storage_object.py (#507)
While version `1.2..0` might work it does not reflect the desired requirement (`1.2.0`).
2022-11-05 16:55:09 +00:00
Yusuke Tsutsumi
cfbc4d8be5 tests: cleaning up resourcemanager, enabling spanner
- gcp_spanner_instance works, enabling for CI.
- gcp_resourcemanager_project is running into quota issues for
  listing the API to verify state. Adding a to-do as well as
  removing some people-specific names.
2022-10-09 06:08:41 +00:00