GCP Bug Fixes (#49458)

* Bug fixes

* fixes as of 12/5/2018

* changes as of 12/06/2018

plugins/modules/gcp_compute_health_check.py

@@ -124,6 +124,12 @@ options:
         - The default value is /.
         required: false
         default: "/"
+      response:
+        description:
+        - The bytes to match against the beginning of the response data. If left empty
+          (the default value), any response will indicate health. The response data
+          can only be ASCII.
+        required: false
       port:
         description:
         - The TCP port number for the HTTP health check request.
@@ -160,6 +166,12 @@ options:
         - The default value is /.
         required: false
         default: "/"
+      response:
+        description:
+        - The bytes to match against the beginning of the response data. If left empty
+          (the default value), any response will indicate health. The response data
+          can only be ASCII.
+        required: false
       port:
         description:
         - The TCP port number for the HTTPS health check request.
@@ -352,6 +364,13 @@ httpHealthCheck:
       - The default value is /.
       returned: success
       type: str
+    response:
+      description:
+      - The bytes to match against the beginning of the response data. If left empty
+        (the default value), any response will indicate health. The response data
+        can only be ASCII.
+      returned: success
+      type: str
     port:
       description:
       - The TCP port number for the HTTP health check request.
@@ -389,6 +408,13 @@ httpsHealthCheck:
       - The default value is /.
       returned: success
       type: str
+    response:
+      description:
+      - The bytes to match against the beginning of the response data. If left empty
+        (the default value), any response will indicate health. The response data
+        can only be ASCII.
+      returned: success
+      type: str
     port:
       description:
       - The TCP port number for the HTTPS health check request.
@@ -514,6 +540,7 @@ def main():
             http_health_check=dict(type='dict', options=dict(
                 host=dict(type='str'),
                 request_path=dict(default='/', type='str'),
+                response=dict(type='str'),
                 port=dict(type='int'),
                 port_name=dict(type='str'),
                 proxy_header=dict(default='NONE', type='str', choices=['NONE', 'PROXY_V1'])
@@ -521,6 +548,7 @@ def main():
             https_health_check=dict(type='dict', options=dict(
                 host=dict(type='str'),
                 request_path=dict(default='/', type='str'),
+                response=dict(type='str'),
                 port=dict(type='int'),
                 port_name=dict(type='str'),
                 proxy_header=dict(default='NONE', type='str', choices=['NONE', 'PROXY_V1'])
@@ -539,7 +567,8 @@ def main():
                 port_name=dict(type='str'),
                 proxy_header=dict(default='NONE', type='str', choices=['NONE', 'PROXY_V1'])
             ))
-        )
+        ),
+        mutually_exclusive=[['http_health_check', 'https_health_check', 'ssl_health_check', 'tcp_health_check']]
     )
 
     if not module.params['scopes']:
@@ -605,7 +634,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v:
+        if v or v is False:
             return_vals[k] = v
 
     return return_vals
@@ -730,6 +759,7 @@ class HealthCheckHttphealthcheck(object):
         return remove_nones_from_dict({
             u'host': self.request.get('host'),
             u'requestPath': self.request.get('request_path'),
+            u'response': self.request.get('response'),
             u'port': self.request.get('port'),
             u'portName': self.request.get('port_name'),
             u'proxyHeader': self.request.get('proxy_header')
@@ -739,6 +769,7 @@ class HealthCheckHttphealthcheck(object):
         return remove_nones_from_dict({
             u'host': self.request.get(u'host'),
             u'requestPath': self.request.get(u'requestPath'),
+            u'response': self.request.get(u'response'),
             u'port': self.request.get(u'port'),
             u'portName': self.request.get(u'portName'),
             u'proxyHeader': self.request.get(u'proxyHeader')
@@ -757,6 +788,7 @@ class HealthCheckHttpshealthcheck(object):
         return remove_nones_from_dict({
             u'host': self.request.get('host'),
             u'requestPath': self.request.get('request_path'),
+            u'response': self.request.get('response'),
             u'port': self.request.get('port'),
             u'portName': self.request.get('port_name'),
             u'proxyHeader': self.request.get('proxy_header')
@@ -766,6 +798,7 @@ class HealthCheckHttpshealthcheck(object):
         return remove_nones_from_dict({
             u'host': self.request.get(u'host'),
             u'requestPath': self.request.get(u'requestPath'),
+            u'response': self.request.get(u'response'),
             u'port': self.request.get(u'port'),
             u'portName': self.request.get(u'portName'),
             u'proxyHeader': self.request.get(u'proxyHeader')