From d03d7beda201353546ef26d94ef4c0e9c6e90b5b Mon Sep 17 00:00:00 2001
From: Yusuke Tsutsumi <yusuketsutsumi@google.com>
Date: Sun, 9 Oct 2022 06:15:24 +0000
Subject: [PATCH] tests: fix gcp_storage_bucket test

- gcp_storage_bucket had a hard-coded bucket name. Making it based
  on the GCP project name to allow some attribution in the case of garbage
  detection.
---
 tests/integration/targets/gcp_storage_bucket/aliases   |  3 +--
 .../targets/gcp_storage_bucket/defaults/main.yml       |  2 +-
 .../targets/gcp_storage_bucket/tasks/autogen.yml       | 10 +++++-----
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/tests/integration/targets/gcp_storage_bucket/aliases b/tests/integration/targets/gcp_storage_bucket/aliases
index 9812f01..0e4419e 100644
--- a/tests/integration/targets/gcp_storage_bucket/aliases
+++ b/tests/integration/targets/gcp_storage_bucket/aliases
@@ -1,2 +1 @@
-cloud/gcp
-unsupported
+cloud/gcp
\ No newline at end of file
diff --git a/tests/integration/targets/gcp_storage_bucket/defaults/main.yml b/tests/integration/targets/gcp_storage_bucket/defaults/main.yml
index ba66644..10f1ec1 100644
--- a/tests/integration/targets/gcp_storage_bucket/defaults/main.yml
+++ b/tests/integration/targets/gcp_storage_bucket/defaults/main.yml
@@ -1,2 +1,2 @@
 ---
-resource_name: "{{ resource_prefix }}"
+resource_name: "{{ gcp_project }}-ansible-test-bucket"
diff --git a/tests/integration/targets/gcp_storage_bucket/tasks/autogen.yml b/tests/integration/targets/gcp_storage_bucket/tasks/autogen.yml
index c82302e..b6d83e4 100644
--- a/tests/integration/targets/gcp_storage_bucket/tasks/autogen.yml
+++ b/tests/integration/targets/gcp_storage_bucket/tasks/autogen.yml
@@ -15,7 +15,7 @@
 # Pre-test setup
 - name: delete a bucket
   google.cloud.gcp_storage_bucket:
-    name: ansible-storage-module
+    name: "{{ resource_name }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file }}"
@@ -23,7 +23,7 @@
 #----------------------------------------------------------
 - name: create a bucket
   google.cloud.gcp_storage_bucket:
-    name: ansible-storage-module
+    name: "{{ resource_name }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file }}"
@@ -36,7 +36,7 @@
 # ----------------------------------------------------------------------------
 - name: create a bucket that already exists
   google.cloud.gcp_storage_bucket:
-    name: ansible-storage-module
+    name: "{{ resource_name }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file }}"
@@ -49,7 +49,7 @@
 #----------------------------------------------------------
 - name: delete a bucket
   google.cloud.gcp_storage_bucket:
-    name: ansible-storage-module
+    name: "{{ resource_name }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file }}"
@@ -62,7 +62,7 @@
 # ----------------------------------------------------------------------------
 - name: delete a bucket that does not exist
   google.cloud.gcp_storage_bucket:
-    name: ansible-storage-module
+    name: "{{ resource_name }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file }}"