From 0074be1248c86974f9d906e0c047b7af31790038 Mon Sep 17 00:00:00 2001
From: Chris Hawk <hawk@google.com>
Date: Mon, 13 Nov 2023 11:54:09 -0800
Subject: [PATCH] chore: address cleanup script linter warnings
---
scripts/cleanup-project.sh | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/scripts/cleanup-project.sh b/scripts/cleanup-project.sh
index e45ddd5..b05a2f1 100755
--- a/scripts/cleanup-project.sh
+++ b/scripts/cleanup-project.sh
@@ -42,12 +42,13 @@ cleanup_resource() {
if [ -z "$extra_list_arg" ]
then
- resources=( $(gcloud "${resource_group}" "${resource}" list --project="${PROJECT_ID}" --format="csv[no-heading](name)") )
+ mapfile -t resources < <(gcloud "${resource_group}" "${resource}" list --project="${PROJECT_ID}" --format="csv[no-heading](name)")
else
- resources=( $(gcloud "${resource_group}" "${resource}" list --project="${PROJECT_ID}" --format="csv[no-heading](name)" "${extra_list_arg}") )
+ mapfile -t resources < <(gcloud "${resource_group}" "${resource}" list --project="${PROJECT_ID}" --format="csv[no-heading](name)" "${extra_list_arg}")
fi
- for resource_id in $resources; do
+ for resource_id in "${resources[@]}"
+ do
if [ -z "$extra_delete_arg" ]
then
gcloud "${resource_group}" "${resource}" delete "${resource_id}" --project="${PROJECT_ID}" -q