Merge pull request #655 from ansible-collections/issue-613

Fix errors reported by ansible-test sanity

.github/workflows/ansible-integration-tests.yml

@@ -25,8 +25,8 @@ jobs:
         # and test against the minimum version of Python supported by both. If/when we change
         # the integration tests to support parallelism we can revisit.
         ansible_version:
-          - stable-2.16
           - stable-2.17
+          - stable-2.18
     steps:
       - name: check out code
         uses: actions/checkout@v4
@@ -35,7 +35,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v4
         with:
-          python-version: '3.10'  # this is the minimum version required for Ansible 2.16
+          python-version: '3.11'  # this is the minimum version required for Ansible 2.17
       - name: Install dependencies
         run: pip install -r requirements.txt
       - name: Install ansible-base (${{ matrix.ansible_version }})
@@ -70,4 +70,4 @@ jobs:
       # run tests
       - name: Run integration tests
         # Add the -vvv flag to print out more output
-        run: ansible-test integration -v --color --python 3.10 --venv-system-site-packages
+        run: ansible-test integration -v --color --python 3.11 --venv-system-site-packages

.github/workflows/ansible-test.yml

@@ -13,10 +13,9 @@ jobs:
         # of ansible-core and each major version of Python supported by both.
         # https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#ansible-core-support-matrix
         ansible_version:
-          - stable-2.16
           - stable-2.17
+          - stable-2.18
         python_version:
-          - '3.10'
           - '3.11'
           - '3.12'
     steps:
@@ -46,10 +45,9 @@ jobs:
     strategy:
       matrix:
         ansible_version:
-          - stable-2.16
           - stable-2.17
+          - stable-2.18
         python_version:
-          - '3.10'
           - '3.11'
           - '3.12'
     steps:

.github/workflows/gcloud.yml

@@ -31,10 +31,10 @@ jobs:
         with:
           path: ansible_collections/google/cloud
 
-      - name: Set up Python 3.10
+      - name: Set up Python 3.11
         uses: actions/setup-python@v4
         with:
-          python-version: '3.10'
+          python-version: '3.11'
 
       - name: Install dependencies
         run: |

.github/workflows/gcsfuse.yml

@@ -26,10 +26,10 @@ jobs:
         with:
           path: ansible_collections/google/cloud
 
-      - name: Set up Python 3.10
+      - name: Set up Python 3.11
         uses: actions/setup-python@v4
         with:
-          python-version: '3.10'
+          python-version: '3.11'
 
       - name: Install dependencies
         run: |

meta/runtime.yml

@@ -1,5 +1,5 @@
 ---
-requires_ansible: ">=2.16.0"
+requires_ansible: ">=2.17.0"
 
 action_groups:
   gcp:

molecule/gcloud/Dockerfile.j2

@@ -46,7 +46,7 @@ RUN yum -y install python-pip
 {% endif %}
 
 {# Install of Python3 #}
-{% if item.image in ["ubuntu:18.04", "ubuntu:20.04", "debian:10"] %}
+{% if item.image in ["ubuntu:18.04", "ubuntu:20.04", "ubuntu:24.04", "debian:10", "debian:11", "debian:12"] %}
 RUN apt-get update \
     && apt-get install -y --no-install-recommends \
        apt-utils python3-setuptools python3-pip
@@ -99,13 +99,13 @@ RUN locale-gen en_US.UTF-8
 RUN mkdir -p /etc/ansible
 RUN echo "[local]\nlocalhost ansible_connection=local" > /etc/ansible/hosts
 
-{% if item.image in ["centos:7", "centos:8", "debian:9", "debian:10"] %}
+{% if item.image in ["centos:7", "centos:8", "debian:9", "debian:10", "debian:11", "debian:12"] %}
 VOLUME ["/sys/fs/cgroup"]
-{% elif item.image in ["ubuntu:16.04", "ubuntu:18.04", "ubuntu:20.04"] %}
+{% elif item.image in ["ubuntu:16.04", "ubuntu:18.04", "ubuntu:20.04", "ubuntu:24.04"] %}
 VOLUME ["/sys/fs/cgroup", "/tmp", "/run"]
 {% endif %}
 {% if item.image in ["centos:7", "centos:8"] %}
 CMD ["/usr/sbin/init"]
-{% elif item.image in ["ubuntu:16.04", "ubuntu:18.04", "ubuntu:20.04", "debian:9", "debian:10"] %}
+{% elif item.image in ["ubuntu:16.04", "ubuntu:18.04", "ubuntu:20.04", "ubuntu:24.04", "debian:9", "debian:10", "debian:11", "debian:12"] %}
 CMD ["/lib/systemd/systemd"]
 {% endif %}

molecule/gcloud/molecule.yml

@@ -9,13 +9,13 @@ lint: |
   ansible-lint
 platforms:
   - name: instance
-    image: ubuntu:20.04
+    image: ubuntu:24.04
     privileged: true
     ansible.builtin.command: /lib/systemd/systemd
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:ro
   - name: instance
-    image: debian:10
+    image: debian:12
     privileged: true
     ansible.builtin.command: /lib/systemd/systemd
     volumes:

molecule/gcsfuse/Dockerfile.j2

@@ -46,7 +46,7 @@ RUN yum -y install python-pip
 {% endif %}
 
 {# Install of Python3 #}
-{% if item.image in ["ubuntu:18.04", "ubuntu:20.04", "debian:10"] %}
+{% if item.image in ["ubuntu:18.04", "ubuntu:20.04", "ubuntu:24.04", "debian:10", "debian:11", "debian:12"] %}
 RUN apt-get update \
     && apt-get install -y --no-install-recommends \
        apt-utils python3-setuptools python3-pip
@@ -99,13 +99,13 @@ RUN locale-gen en_US.UTF-8
 RUN mkdir -p /etc/ansible
 RUN echo "[local]\nlocalhost ansible_connection=local" > /etc/ansible/hosts
 
-{% if item.image in ["centos:7", "centos:8", "debian:9", "debian:10"] %}
+{% if item.image in ["centos:7", "centos:8", "debian:9", "debian:10", "debian:11", "debian:12"] %}
 VOLUME ["/sys/fs/cgroup"]
-{% elif item.image in ["ubuntu:16.04", "ubuntu:18.04", "ubuntu:20.04"] %}
+{% elif item.image in ["ubuntu:16.04", "ubuntu:18.04", "ubuntu:20.04", "ubuntu:24.04"] %}
 VOLUME ["/sys/fs/cgroup", "/tmp", "/run"]
 {% endif %}
 {% if item.image in ["centos:7", "centos:8"] %}
 CMD ["/usr/sbin/init"]
-{% elif item.image in ["ubuntu:16.04", "ubuntu:18.04", "ubuntu:20.04", "debian:9", "debian:10"] %}
+{% elif item.image in ["ubuntu:16.04", "ubuntu:18.04", "ubuntu:20.04", "ubuntu:24.04", "debian:9", "debian:10", "debian:11", "debian:12"] %}
 CMD ["/lib/systemd/systemd"]
 {% endif %}

molecule/gcsfuse/molecule.yml

@@ -9,13 +9,13 @@ lint: |
   ansible-lint
 platforms:
   - name: instance
-    image: ubuntu:20.04
+    image: ubuntu:24.04
     privileged: true
     ansible.builtin.command: /lib/systemd/systemd
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:ro
   - name: instance
-    image: debian:10
+    image: debian:12
     privileged: true
     ansible.builtin.command: /lib/systemd/systemd
     volumes:

plugins/inventory/gcp_compute.py

@@ -7,7 +7,6 @@ __metaclass__ = type
 
 DOCUMENTATION = """
     name: gcp_compute
-    plugin_type: inventory
     short_description: Google Cloud Compute Engine inventory source
     requirements:
         - requests >= 2.18.4
@@ -27,14 +26,17 @@ DOCUMENTATION = """
           description: A list of regions in which to describe GCE instances.
                        If none provided, it defaults to all zones available to a given project.
           type: list
+          elements: string
         folders:
           description: A folder that contains many projects
           type: list
           required: False
+          elements: string
         projects:
           description: A list of projects in which to describe GCE instances.
           type: list
           required: False
+          elements: string
         filters:
           description: >
             A list of filter value pairs. Available filters are listed here
@@ -42,12 +44,14 @@ DOCUMENTATION = """
             Each additional filter in the list will be added as an AND condition
             (filter1 and filter2)
           type: list
+          elements: string
         hostnames:
           description: A list of options that describe the ordering for which
               hostnames should be assigned. Currently supported hostnames are
               'public_ip', 'private_ip', 'name' or 'labels.vm_name'.
           default: ['public_ip', 'private_ip', 'name']
           type: list
+          elements: string
         name_suffix:
           description: Custom domain suffix. If set, this string will be appended to all hosts.
           default: ""
@@ -63,6 +67,7 @@ DOCUMENTATION = """
         scopes:
             description: list of authentication scopes
             type: list
+            elements: string
             default: ['https://www.googleapis.com/auth/compute']
             env:
                 - name: GCP_SCOPES

plugins/lookup/gcp_secret_manager.py

@@ -5,9 +5,8 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 DOCUMENTATION = '''
-    author:
-    - Dave Costakos <dcostako@redhat.com>
     name: gcp_secret_manager
+    author: Dave Costakos (@davecostakos) <dcostako@redhat.com>
     short_description: Get Secrets from Google Cloud as a Lookup plugin
     description:
     - retrieve secret keys in Secret Manager for use in playbooks
@@ -59,7 +58,7 @@ DOCUMENTATION = '''
             description:
             - JSON Object representing the contents of a service_account_file obtained from Google Cloud
             - defaults to OS env variable GCP_SERVICE_ACCOUNT_INFO if not present
-            type: jsonarg
+            type: str
             required: False
         access_token:
             description:
@@ -84,6 +83,7 @@ DOCUMENTATION = '''
             description:
             - Authenticaiton scopes for Google Secret Manager
             type: list
+            elements: str
             default: ["https://www.googleapis.com/auth/cloud-platform"]
 '''
 

plugins/modules/gcp_appengine_firewall_rule_info.py

@@ -150,7 +150,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict())
+    module = GcpModule(argument_spec=dict(), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_bigquery_dataset_info.py

@@ -311,7 +311,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict())
+    module = GcpModule(argument_spec=dict(), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/bigquery']

plugins/modules/gcp_bigquery_table.py

@@ -253,6 +253,7 @@ options:
           data .
         required: false
         type: int
+        default: 0
       source_format:
         description:
         - The data format.
@@ -328,6 +329,7 @@ options:
               when reading the data.
             required: false
             type: int
+            default: 0
       csv_options:
         description:
         - Additional properties to set if sourceFormat is set to CSV.
@@ -368,6 +370,7 @@ options:
               when reading the data.
             required: false
             type: int
+            default: 0
       bigtable_options:
         description:
         - Additional options if sourceFormat is set to BIGTABLE.

plugins/modules/gcp_bigquery_table_info.py

@@ -590,7 +590,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(dataset=dict(type='str')))
+    module = GcpModule(argument_spec=dict(dataset=dict(type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/bigquery']

plugins/modules/gcp_bigtable_instance_info.py

@@ -188,7 +188,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict())
+    module = GcpModule(argument_spec=dict(), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_cloudbuild_trigger.py

@@ -1536,7 +1536,7 @@ def main():
                 ),
             ),
             pubsub_config=dict(type='dict', options=dict(topic=dict(required=True, type='str'), service_account_email=dict(type='str'))),
-            webhook_config=dict(type='dict', options=dict(secret=dict(required=True, type='str'))),
+            webhook_config=dict(type='dict', options=dict(secret=dict(required=True, type='str', no_log=True))),
             build=dict(
                 type='dict',
                 options=dict(
@@ -1568,7 +1568,11 @@ def main():
                     queue_ttl=dict(type='str'),
                     logs_bucket=dict(type='str'),
                     timeout=dict(default='600s', type='str'),
-                    secrets=dict(type='list', elements='dict', options=dict(kms_key_name=dict(required=True, type='str'), secret_env=dict(type='dict'))),
+                    secrets=dict(
+                        type='list',
+                        elements='dict',
+                        no_log=True,
+                        options=dict(kms_key_name=dict(required=True, type='str'), secret_env=dict(type='dict', no_log=True))),
                     steps=dict(
                         required=True,
                         type='list',
@@ -1580,7 +1584,7 @@ def main():
                             id=dict(type='str'),
                             entrypoint=dict(type='str'),
                             dir=dict(type='str'),
-                            secret_env=dict(type='list', elements='str'),
+                            secret_env=dict(type='list', elements='str', no_log=True),
                             timeout=dict(type='str'),
                             timing=dict(type='str'),
                             volumes=dict(
@@ -1609,7 +1613,7 @@ def main():
                             worker_pool=dict(type='str'),
                             logging=dict(type='str'),
                             env=dict(type='list', elements='str'),
-                            secret_env=dict(type='list', elements='str'),
+                            secret_env=dict(type='list', elements='str', no_log=True),
                             volumes=dict(type='list', elements='dict', options=dict(name=dict(type='str'), path=dict(type='str'))),
                         ),
                     ),

plugins/modules/gcp_cloudbuild_trigger_info.py

@@ -814,7 +814,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict())
+    module = GcpModule(argument_spec=dict(), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_cloudfunctions_cloud_function_info.py

@@ -273,7 +273,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_cloudscheduler_job.py

@@ -681,8 +681,8 @@ def main():
                     http_method=dict(type='str'),
                     body=dict(type='str'),
                     headers=dict(type='dict'),
-                    oauth_token=dict(type='dict', options=dict(service_account_email=dict(required=True, type='str'), scope=dict(type='str'))),
+                    oauth_token=dict(type='dict', no_log=True, options=dict(service_account_email=dict(required=True, type='str'), scope=dict(type='str'))),
-                    oidc_token=dict(type='dict', options=dict(service_account_email=dict(required=True, type='str'), audience=dict(type='str'))),
+                    oidc_token=dict(type='dict', no_log=True, options=dict(service_account_email=dict(required=True, type='str'), audience=dict(type='str'))),
                 ),
             ),
             region=dict(required=True, type='str'),

plugins/modules/gcp_cloudscheduler_job_info.py

@@ -379,7 +379,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_cloudtasks_queue_info.py

@@ -279,7 +279,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_compute_address_info.py

@@ -235,7 +235,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_autoscaler_info.py

@@ -320,7 +320,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_backend_bucket_info.py

@@ -252,7 +252,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_backend_service.py

@@ -88,7 +88,7 @@ options:
           completely drained, offering 0% of its available Capacity. Valid range is
           [0.0,1.0].
         required: false
-        default: '1.0'
+        default: '1'
         type: str
       description:
         description:
@@ -422,6 +422,11 @@ options:
     elements: str
     required: false
     type: list
+  fingerprint:
+    description:
+    - Fingerprint of this resource. A hash of the contents stored in this object. This
+      field is used in optimistic locking.
+    type: str
   description:
     description:
     - An optional description of this resource.
@@ -478,7 +483,7 @@ options:
     - The load balancing algorithm used within the scope of the locality.
     - The possible values are - * ROUND_ROBIN - This is a simple policy in which each
       healthy backend is selected in round robin order.
-    - "* LEAST_REQUEST - An O(1) algorithm which selects two random healthy hosts
+    - "* LEAST_REQUEST - An algorithm which selects two random healthy hosts
       and picks the host which has fewer active requests."
     - "* RING_HASH - The ring/modulo hash load balancer implements consistent hashing
       to backends. The algorithm has the property that the addition/removal of a host
@@ -566,6 +571,7 @@ options:
           be used to disable ejection or to ramp it up slowly. Defaults to 0.
         required: false
         type: int
+        default: 0
       enforcing_success_rate:
         description:
         - The percentage chance that a host will be actually ejected when an outlier
@@ -1210,7 +1216,7 @@ localityLbPolicy:
   - The load balancing algorithm used within the scope of the locality.
   - The possible values are - * ROUND_ROBIN - This is a simple policy in which each
     healthy backend is selected in round robin order.
-  - "* LEAST_REQUEST - An O(1) algorithm which selects two random healthy hosts and
+  - "* LEAST_REQUEST - An algorithm which selects two random healthy hosts and
     picks the host which has fewer active requests."
   - "* RING_HASH - The ring/modulo hash load balancer implements consistent hashing
     to backends. The algorithm has the property that the addition/removal of a host
@@ -1490,6 +1496,7 @@ def main():
                 options=dict(
                     cache_key_policy=dict(
                         type="dict",
+                        no_log=False,
                         options=dict(
                             include_host=dict(type="bool"),
                             include_protocol=dict(type="bool"),

plugins/modules/gcp_compute_backend_service_info.py

@@ -549,7 +549,7 @@ resources:
       - The load balancing algorithm used within the scope of the locality.
       - The possible values are - * ROUND_ROBIN - This is a simple policy in which
         each healthy backend is selected in round robin order.
-      - "* LEAST_REQUEST - An O(1) algorithm which selects two random healthy hosts
+      - "* LEAST_REQUEST - An algorithm which selects two random healthy hosts
         and picks the host which has fewer active requests."
       - "* RING_HASH - The ring/modulo hash load balancer implements consistent hashing
         to backends. The algorithm has the property that the addition/removal of a
@@ -762,7 +762,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_disk.py

@@ -570,14 +570,20 @@ def main():
             provisioned_iops=dict(type='int'),
             zone=dict(required=True, type='str'),
             source_image_encryption_key=dict(
-                type='dict', no_log=True, options=dict(raw_key=dict(type='str'), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
+                type='dict',
+                no_log=True,
+                options=dict(raw_key=dict(type='str', no_log=True), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
             ),
             disk_encryption_key=dict(
-                type='dict', no_log=True, options=dict(raw_key=dict(type='str'), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
+                type='dict',
+                no_log=True,
+                options=dict(raw_key=dict(type='str', no_log=True), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
             ),
             source_snapshot=dict(type='dict', no_log=True),
             source_snapshot_encryption_key=dict(
-                type='dict', no_log=True, options=dict(raw_key=dict(type='str'), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
+                type='dict',
+                no_log=True,
+                options=dict(raw_key=dict(type='str', no_log=True), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
             ),
         )
     )

plugins/modules/gcp_compute_disk_info.py

@@ -375,7 +375,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_external_vpn_gateway_info.py

@@ -175,7 +175,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_firewall_info.py

@@ -322,7 +322,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_forwarding_rule_info.py

@@ -314,7 +314,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_global_address_info.py

@@ -205,7 +205,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_global_forwarding_rule_info.py

@@ -289,7 +289,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_health_check.py

@@ -457,7 +457,6 @@ options:
         - Indicates whether or not to export logs. This is false by default, which
           means no health check logging will be done.
         required: false
-        default: 'false'
         type: bool
   project:
     description:

plugins/modules/gcp_compute_health_check_info.py

@@ -527,7 +527,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_http_health_check_info.py

@@ -204,7 +204,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_https_health_check_info.py

@@ -204,7 +204,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_image.py

@@ -545,13 +545,13 @@ def main():
             disk_size_gb=dict(type='int'),
             family=dict(type='str'),
             guest_os_features=dict(type='list', elements='dict', options=dict(type=dict(required=True, type='str'))),
-            image_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str'))),
+            image_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str', no_log=True))),
             labels=dict(type='dict'),
             licenses=dict(type='list', elements='str'),
             name=dict(required=True, type='str'),
             raw_disk=dict(type='dict', options=dict(container_type=dict(type='str'), sha1_checksum=dict(type='str'), source=dict(required=True, type='str'))),
             source_disk=dict(type='dict'),
-            source_disk_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str'))),
+            source_disk_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str', no_log=True))),
             source_disk_id=dict(type='str'),
             source_image=dict(type='dict'),
             source_snapshot=dict(type='dict'),

plugins/modules/gcp_compute_image_info.py

@@ -351,7 +351,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_instance.py

@@ -1119,7 +1119,9 @@ def main():
                     auto_delete=dict(type='bool'),
                     boot=dict(type='bool'),
                     device_name=dict(type='str'),
-                    disk_encryption_key=dict(type='dict', options=dict(raw_key=dict(type='str'), rsa_encrypted_key=dict(type='str'))),
+                    disk_encryption_key=dict(type='dict',
+                                             no_log=True,
+                                             options=dict(raw_key=dict(type='str', no_log=True), rsa_encrypted_key=dict(type='str', no_log=True))),
                     index=dict(type='int'),
                     initialize_params=dict(
                         type='dict',
@@ -1128,7 +1130,7 @@ def main():
                             disk_size_gb=dict(type='int'),
                             disk_type=dict(type='str'),
                             source_image=dict(type='str', aliases=['image', 'image_family']),
-                            source_image_encryption_key=dict(type='dict', options=dict(raw_key=dict(type='str'))),
+                            source_image_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str', no_log=True))),
                         ),
                     ),
                     interface=dict(type='str'),

plugins/modules/gcp_compute_instance_group_info.py

@@ -213,7 +213,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_instance_group_manager_info.py

@@ -288,7 +288,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_instance_info.py

@@ -621,7 +621,8 @@ def main():
         argument_spec=dict(
             filters=dict(type="list", elements="str"),
             zone=dict(required=True, type="str"),
-        )
+        ),
+        supports_check_mode=True
     )
 
     if not module.params["scopes"]:

plugins/modules/gcp_compute_instance_template.py

@@ -1019,7 +1019,9 @@ def main():
                             auto_delete=dict(type='bool'),
                             boot=dict(type='bool'),
                             device_name=dict(type='str'),
-                            disk_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str'), rsa_encrypted_key=dict(type='str'))),
+                            disk_encryption_key=dict(type='dict',
+                                                     no_log=True,
+                                                     options=dict(raw_key=dict(type='str', no_log=True), rsa_encrypted_key=dict(type='str', no_log=True))),
                             index=dict(type='int'),
                             initialize_params=dict(
                                 type='dict',
@@ -1028,7 +1030,7 @@ def main():
                                     disk_size_gb=dict(type='int'),
                                     disk_type=dict(type='str'),
                                     source_image=dict(type='str'),
-                                    source_image_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str'))),
+                                    source_image_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str', no_log=True))),
                                 ),
                             ),
                             interface=dict(type='str'),

plugins/modules/gcp_compute_instance_template_info.py

@@ -560,7 +560,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_interconnect_attachment_info.py

@@ -320,7 +320,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_network_endpoint_group_info.py

@@ -192,7 +192,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_network_info.py

@@ -202,7 +202,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_node_group_info.py

@@ -219,7 +219,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_node_template_info.py

@@ -220,7 +220,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_region_autoscaler_info.py

@@ -320,7 +320,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_region_backend_service.py

@@ -476,7 +476,7 @@ options:
     - The load balancing algorithm used within the scope of the locality.
     - The possible values are - * ROUND_ROBIN - This is a simple policy in which each
       healthy backend is selected in round robin order.
-    - "* LEAST_REQUEST - An O(1) algorithm which selects two random healthy hosts
+    - "* LEAST_REQUEST - An algorithm which selects two random healthy hosts
       and picks the host which has fewer active requests."
     - "* RING_HASH - The ring/modulo hash load balancer implements consistent hashing
       to backends. The algorithm has the property that the addition/removal of a host
@@ -566,6 +566,7 @@ options:
           be used to disable ejection or to ramp it up slowly. Defaults to 0.
         required: false
         type: int
+        default: 0
       enforcing_success_rate:
         description:
         - The percentage chance that a host will be actually ejected when an outlier
@@ -1222,7 +1223,7 @@ localityLbPolicy:
   - The load balancing algorithm used within the scope of the locality.
   - The possible values are - * ROUND_ROBIN - This is a simple policy in which each
     healthy backend is selected in round robin order.
-  - "* LEAST_REQUEST - An O(1) algorithm which selects two random healthy hosts and
+  - "* LEAST_REQUEST - An algorithm which selects two random healthy hosts and
     picks the host which has fewer active requests."
   - "* RING_HASH - The ring/modulo hash load balancer implements consistent hashing
     to backends. The algorithm has the property that the addition/removal of a host
@@ -1507,6 +1508,7 @@ def main():
                 options=dict(
                     cache_key_policy=dict(
                         type='dict',
+                        no_log=False,
                         options=dict(
                             include_host=dict(type='bool'),
                             include_protocol=dict(type='bool'),

plugins/modules/gcp_compute_region_backend_service_info.py

@@ -559,7 +559,7 @@ resources:
       - The load balancing algorithm used within the scope of the locality.
       - The possible values are - * ROUND_ROBIN - This is a simple policy in which
         each healthy backend is selected in round robin order.
-      - "* LEAST_REQUEST - An O(1) algorithm which selects two random healthy hosts
+      - "* LEAST_REQUEST - An algorithm which selects two random healthy hosts
         and picks the host which has fewer active requests."
       - "* RING_HASH - The ring/modulo hash load balancer implements consistent hashing
         to backends. The algorithm has the property that the addition/removal of a
@@ -787,7 +787,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_region_disk.py

@@ -430,9 +430,9 @@ def main():
             replica_zones=dict(required=True, type='list', elements='str'),
             type=dict(type='str'),
             region=dict(required=True, type='str'),
-            disk_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str'))),
+            disk_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str', no_log=True))),
             source_snapshot=dict(type='dict'),
-            source_snapshot_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str'))),
+            source_snapshot_encryption_key=dict(type='dict', no_log=True, options=dict(raw_key=dict(type='str', no_log=True))),
         )
     )
 

plugins/modules/gcp_compute_region_disk_info.py

@@ -293,7 +293,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_region_health_check.py

@@ -452,7 +452,6 @@ options:
         - Indicates whether or not to export logs. This is false by default, which
           means no health check logging will be done.
         required: false
-        default: 'false'
         type: bool
   region:
     description:

plugins/modules/gcp_compute_region_health_check_info.py

@@ -538,7 +538,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_region_instance_group_manager_info.py

@@ -301,7 +301,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_region_target_http_proxy_info.py

@@ -176,7 +176,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_region_target_https_proxy_info.py

@@ -183,7 +183,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_region_url_map.py

@@ -302,7 +302,6 @@ options:
                       is considered a match if the match criteria above are NOT met.
                       Defaults to false.
                     required: false
-                    default: 'false'
                     type: bool
                   prefix_match:
                     description:
@@ -364,7 +363,6 @@ options:
                 - Specifies that prefixMatch and fullPathMatch matches are case sensitive.
                 - Defaults to false.
                 required: false
-                default: 'false'
                 type: bool
               metadata_filters:
                 description:
@@ -499,7 +497,6 @@ options:
                       to the Access- Control-Allow-Credentials header. Defaults to
                       false.
                     required: false
-                    default: 'false'
                     type: bool
                   allow_headers:
                     description:
@@ -535,7 +532,6 @@ options:
                     - which indicates that the CORS policy is in effect. Defaults
                       to false.
                     required: false
-                    default: 'false'
                     type: bool
                   expose_headers:
                     description:
@@ -882,7 +878,6 @@ options:
                   used in TargetHttpProxys. Setting this true for TargetHttpsProxy
                   is not permitted. The default is set to false.
                 required: false
-                default: 'false'
                 type: bool
               path_redirect:
                 description:
@@ -926,7 +921,6 @@ options:
                   query portion of the original URL is retained. The default value
                   is false.
                 required: false
-                default: 'false'
                 type: bool
       path_rules:
         description:
@@ -993,7 +987,6 @@ options:
                       to the Access- Control-Allow-Credentials header. Defaults to
                       false.
                     required: false
-                    default: 'false'
                     type: bool
                   allow_headers:
                     description:
@@ -1373,7 +1366,6 @@ options:
                   used in TargetHttpProxys. Setting this true for TargetHttpsProxy
                   is not permitted. The default is set to false.
                 required: false
-                default: 'false'
                 type: bool
               path_redirect:
                 description:
@@ -1416,7 +1408,6 @@ options:
                   is removed prior to redirecting the request. If set to false, the
                   query portion of the original URL is retained.
                 required: false
-                default: 'false'
                 type: bool
       default_url_redirect:
         description:
@@ -1441,7 +1432,6 @@ options:
               in TargetHttpProxys. Setting this true for TargetHttpsProxy is not permitted.
               The default is set to false.
             required: false
-            default: 'false'
             type: bool
           path_redirect:
             description:
@@ -1483,7 +1473,6 @@ options:
               removed prior to redirecting the request. If set to false, the query
               portion of the original URL is retained.
             required: false
-            default: 'false'
             type: bool
   tests:
     description:
@@ -1541,7 +1530,6 @@ options:
           Setting this true for TargetHttpsProxy is not permitted. The default is
           set to false.
         required: false
-        default: 'false'
         type: bool
       path_redirect:
         description:
@@ -1582,7 +1570,6 @@ options:
           prior to redirecting the request. If set to false, the query portion of
           the original URL is retained.
         required: false
-        default: 'false'
         type: bool
   region:
     description:

plugins/modules/gcp_compute_region_url_map_info.py

@@ -1604,7 +1604,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_reservation.py

@@ -73,7 +73,6 @@ options:
       this reservation. Otherwise, it can be consumed by VMs with affinity for any
       reservation. Defaults to false.
     required: false
-    default: 'false'
     type: bool
   specific_reservation:
     description:

plugins/modules/gcp_compute_reservation_info.py

@@ -258,7 +258,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_resource_policy_info.py

@@ -346,7 +346,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_route_info.py

@@ -217,7 +217,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_router_info.py

@@ -222,7 +222,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_snapshot.py

@@ -388,10 +388,14 @@ def main():
             source_disk=dict(required=True, type='dict'),
             zone=dict(type='str'),
             snapshot_encryption_key=dict(
-                type='dict', no_log=True, options=dict(raw_key=dict(type='str'), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
+                type='dict',
+                no_log=True,
+                options=dict(raw_key=dict(type='str', no_log=True), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
             ),
             source_disk_encryption_key=dict(
-                type='dict', no_log=True, options=dict(raw_key=dict(type='str'), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
+                type='dict',
+                no_log=True,
+                options=dict(raw_key=dict(type='str', no_log=True), kms_key_name=dict(type='str'), kms_key_service_account=dict(type='str'))
             ),
         )
     )

plugins/modules/gcp_compute_snapshot_info.py

@@ -260,7 +260,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_ssl_certificate_info.py

@@ -171,7 +171,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_ssl_policy_info.py

@@ -207,7 +207,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_subnetwork_info.py

@@ -226,7 +226,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_target_http_proxy_info.py

@@ -171,7 +171,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_target_https_proxy_info.py

@@ -193,7 +193,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_target_instance_info.py

@@ -178,7 +178,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_target_pool_info.py

@@ -224,7 +224,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_target_ssl_proxy_info.py

@@ -183,7 +183,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_target_tcp_proxy_info.py

@@ -175,7 +175,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_target_vpn_gateway_info.py

@@ -186,7 +186,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_url_map.py

@@ -70,6 +70,11 @@ options:
       the resource.
     required: false
     type: str
+  fingerprint:
+    description:
+    - Fingerprint of this resource. A hash of the contents stored in this object. This
+      field is used in optimistic locking.
+    type: str
   header_action:
     description:
     - Specifies changes to request and response headers that need to take effect for
@@ -357,7 +362,6 @@ options:
                       to the Access- Control-Allow-Credentials header. Defaults to
                       false.
                     required: false
-                    default: 'false'
                     type: bool
                   allow_headers:
                     description:
@@ -737,7 +741,6 @@ options:
                   used in TargetHttpProxys. Setting this true for TargetHttpsProxy
                   is not permitted. The default is set to false.
                 required: false
-                default: 'false'
                 type: bool
               path_redirect:
                 description:
@@ -780,7 +783,6 @@ options:
                   is removed prior to redirecting the request. If set to false, the
                   query portion of the original URL is retained.
                 required: false
-                default: 'false'
                 type: bool
       route_rules:
         description:
@@ -948,7 +950,6 @@ options:
                       is considered a match if the match criteria above are NOT met.
                       Defaults to false.
                     required: false
-                    default: 'false'
                     type: bool
                   prefix_match:
                     description:
@@ -1010,7 +1011,6 @@ options:
                 - Specifies that prefixMatch and fullPathMatch matches are case sensitive.
                 - Defaults to false.
                 required: false
-                default: 'false'
                 type: bool
               metadata_filters:
                 description:
@@ -1145,7 +1145,6 @@ options:
                       to the Access- Control-Allow-Credentials header. Defaults to
                       false.
                     required: false
-                    default: 'false'
                     type: bool
                   allow_headers:
                     description:
@@ -1181,7 +1180,6 @@ options:
                     - which indicates that the CORS policy is in effect. Defaults
                       to false.
                     required: false
-                    default: 'false'
                     type: bool
                   expose_headers:
                     description:
@@ -1531,7 +1529,6 @@ options:
                 - Setting this true for TargetHttpsProxy is not permitted. Defaults
                   to false.
                 required: false
-                default: 'false'
                 type: bool
               path_redirect:
                 description:
@@ -1569,7 +1566,6 @@ options:
                   is removed prior to redirecting the request. If set to false, the
                   query portion of the original URL is retained. Defaults to false.
                 required: false
-                default: 'false'
                 type: bool
       default_url_redirect:
         description:
@@ -1594,7 +1590,6 @@ options:
               in TargetHttpProxys. Setting this true for TargetHttpsProxy is not permitted.
               The default is set to false.
             required: false
-            default: 'false'
             type: bool
           path_redirect:
             description:
@@ -1636,7 +1631,6 @@ options:
               removed prior to redirecting the request. If set to false, the query
               portion of the original URL is retained.
             required: false
-            default: 'false'
             type: bool
       default_route_action:
         description:
@@ -1733,7 +1727,6 @@ options:
                         - If true, headerValue is set for the header, discarding any
                           values that were set for that header.
                         required: false
-                        default: 'false'
                         type: bool
                   response_headers_to_remove:
                     description:
@@ -1767,7 +1760,6 @@ options:
                         - If true, headerValue is set for the header, discarding any
                           values that were set for that header.
                         required: false
-                        default: 'false'
                         type: bool
           url_rewrite:
             description:
@@ -1960,14 +1952,12 @@ options:
                   that the actual request can include user credentials.
                 - This translates to the Access-Control-Allow-Credentials header.
                 required: false
-                default: 'false'
                 type: bool
               disabled:
                 description:
                 - If true, specifies the CORS policy is disabled. The default value
                   is false, which indicates that the CORS policy is in effect.
                 required: false
-                default: 'false'
                 type: bool
           fault_injection_policy:
             description:
@@ -2095,7 +2085,6 @@ options:
           Setting this true for TargetHttpsProxy is not permitted. The default is
           set to false.
         required: false
-        default: 'false'
         type: bool
       path_redirect:
         description:
@@ -2136,7 +2125,6 @@ options:
           prior to redirecting the request. If set to false, the query portion of
           the original URL is retained. The default is set to false.
         required: false
-        default: 'false'
         type: bool
   default_route_action:
     description:
@@ -2231,8 +2219,6 @@ options:
                       exist for the header.
                     - If true, headerValue is set for the header, discarding any values
                       that were set for that header.
-                    required: false
-                    default: 'false'
                     type: bool
               response_headers_to_remove:
                 description:
@@ -2266,7 +2252,6 @@ options:
                     - If true, headerValue is set for the header, discarding any values
                       that were set for that header.
                     required: false
-                    default: 'false'
                     type: bool
       url_rewrite:
         description:
@@ -2456,14 +2441,12 @@ options:
               the actual request can include user credentials.
             - This translates to the Access-Control-Allow-Credentials header.
             required: false
-            default: 'false'
             type: bool
           disabled:
             description:
             - If true, specifies the CORS policy is disabled. The default value is
               false, which indicates that the CORS policy is in effect.
             required: false
-            default: 'false'
             type: bool
       fault_injection_policy:
         description:

plugins/modules/gcp_compute_url_map_info.py

@@ -2487,7 +2487,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_compute_vpn_tunnel_info.py

@@ -247,7 +247,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(filters=dict(type='list', elements='str'), region=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/compute']

plugins/modules/gcp_container_cluster.py

@@ -1528,7 +1528,9 @@ def main():
                     accelerators=dict(type='list', elements='dict', options=dict(accelerator_count=dict(type='str'), accelerator_type=dict(type='str'))),
                     disk_type=dict(type='str'),
                     min_cpu_platform=dict(type='str'),
-                    taints=dict(type='list', elements='dict', options=dict(key=dict(type='str'), value=dict(type='str'), effect=dict(type='str'))),
+                    taints=dict(type='list',
+                                elements='dict',
+                                options=dict(key=dict(type='str', no_log=False), value=dict(type='str'), effect=dict(type='str'))),
                     shielded_instance_config=dict(
                         type='dict', options=dict(enable_secure_boot=dict(type='bool'), enable_integrity_monitoring=dict(type='bool'))
                     ),
@@ -1538,7 +1540,7 @@ def main():
                 type='dict',
                 options=dict(
                     username=dict(type='str'),
-                    password=dict(type='str'),
+                    password=dict(type='str', no_log=True),
                     client_certificate_config=dict(type='dict', options=dict(issue_client_certificate=dict(type='bool'))),
                 ),
             ),

plugins/modules/gcp_container_cluster_info.py

@@ -859,7 +859,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str', aliases=['region', 'zone'])))
+    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str', aliases=['region', 'zone'])), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_container_node_pool.py

@@ -764,7 +764,9 @@ def main():
                     accelerators=dict(type='list', elements='dict', options=dict(accelerator_count=dict(type='int'), accelerator_type=dict(type='str'))),
                     disk_type=dict(type='str'),
                     min_cpu_platform=dict(type='str'),
-                    taints=dict(type='list', elements='dict', options=dict(key=dict(type='str'), value=dict(type='str'), effect=dict(type='str'))),
+                    taints=dict(type='list',
+                                elements='dict',
+                                options=dict(key=dict(type='str', no_log=False), value=dict(type='str'), effect=dict(type='str'))),
                     shielded_instance_config=dict(
                         type='dict', options=dict(enable_secure_boot=dict(type='bool'), enable_integrity_monitoring=dict(type='bool'))
                     ),

plugins/modules/gcp_container_node_pool_info.py

@@ -450,7 +450,8 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str', aliases=['region', 'zone']), cluster=dict(required=True, type='dict')))
+    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str', aliases=['region', 'zone']), cluster=dict(required=True, type='dict')),
+                       supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_dns_managed_zone.py

@@ -508,8 +508,12 @@ def main():
                     default_key_specs=dict(
                         type='list',
                         elements='dict',
+                        no_log=False,
                         options=dict(
-                            algorithm=dict(type='str'), key_length=dict(type='int'), key_type=dict(type='str'), kind=dict(default='dns#dnsKeySpec', type='str')
+                            algorithm=dict(type='str'),
+                            key_length=dict(type='int', no_log=False),
+                            key_type=dict(type='str'),
+                            kind=dict(default='dns#dnsKeySpec', type='str')
                         ),
                     ),
                 ),

plugins/modules/gcp_dns_managed_zone_info.py

@@ -308,7 +308,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(dns_name=dict(type='list', elements='str')))
+    module = GcpModule(argument_spec=dict(dns_name=dict(type='list', elements='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/ndev.clouddns.readwrite']

plugins/modules/gcp_dns_resource_record_set_info.py

@@ -160,7 +160,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(managed_zone=dict(required=True, type='dict')))
+    module = GcpModule(argument_spec=dict(managed_zone=dict(required=True, type='dict')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/ndev.clouddns.readwrite']

plugins/modules/gcp_filestore_instance_info.py

@@ -213,7 +213,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(zone=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(zone=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_iam_role_info.py

@@ -156,7 +156,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict())
+    module = GcpModule(argument_spec=dict(), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/iam']

plugins/modules/gcp_iam_service_account_info.py

@@ -155,7 +155,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict())
+    module = GcpModule(argument_spec=dict(), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/iam']

plugins/modules/gcp_kms_crypto_key.py

@@ -104,6 +104,7 @@ options:
     - If set to true, the request will create a CryptoKey without any CryptoKeyVersions.
       You must use the `google_kms_key_ring_import_job` resource to import the CryptoKeyVersion.
     required: false
+    default: false
     type: bool
   project:
     description:
@@ -284,7 +285,7 @@ def main():
             purpose=dict(default='ENCRYPT_DECRYPT', type='str'),
             rotation_period=dict(type='str'),
             version_template=dict(type='dict', options=dict(algorithm=dict(required=True, type='str'), protection_level=dict(type='str'))),
-            key_ring=dict(required=True, type='str'),
+            key_ring=dict(required=True, type='str', no_log=False),
             skip_initial_version_creation=dict(type='bool', default=False),
         )
     )

plugins/modules/gcp_kms_crypto_key_info.py

@@ -198,7 +198,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(key_ring=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(key_ring=dict(required=True, type='str', no_log=False)), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloudkms']

plugins/modules/gcp_kms_key_ring_info.py

@@ -151,7 +151,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str')))
+    module = GcpModule(argument_spec=dict(location=dict(required=True, type='str')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloudkms']

plugins/modules/gcp_logging_metric.py

@@ -528,7 +528,8 @@ def main():
                     labels=dict(
                         type='list',
                         elements='dict',
-                        options=dict(key=dict(required=True, type='str'), description=dict(type='str'), value_type=dict(default='STRING', type='str')),
+                        options=dict(key=dict(required=True, type='str', no_log=False),
+                                     description=dict(type='str'), value_type=dict(default='STRING', type='str')),
                     ),
                     display_name=dict(type='str'),
                 ),

plugins/modules/gcp_logging_metric_info.py

@@ -302,7 +302,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict())
+    module = GcpModule(argument_spec=dict(), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_mlengine_model_info.py

@@ -169,7 +169,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict())
+    module = GcpModule(argument_spec=dict(), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']

plugins/modules/gcp_mlengine_version_info.py

@@ -260,7 +260,7 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(model=dict(required=True, type='dict')))
+    module = GcpModule(argument_spec=dict(model=dict(required=True, type='dict')), supports_check_mode=True)
 
     if not module.params['scopes']:
         module.params['scopes'] = ['https://www.googleapis.com/auth/cloud-platform']