From 83b477f91d0323505bd4ab91bc92b6fd79638c8f Mon Sep 17 00:00:00 2001 From: The Magician Date: Tue, 22 Dec 2020 09:14:11 -0800 Subject: [PATCH] Fix path_matcher in region url maps (#4298) (#353) * Fix path_matcher in region url maps The default_service in path_matcher is actually not required as it should be default_service or default_url_redirect. Further info in https://cloud.google.com/compute/docs/reference/rest/v1/regionUrlMaps > pathMatchers[].defaultService >> Only one of defaultService, defaultUrlRedirect or defaultRouteAction.weightedBackendService must be set. * Add testcase * Update function name Co-authored-by: Gilles Margerie Signed-off-by: Modular Magician Co-authored-by: Gilles Margerie --- plugins/modules/gcp_compute_region_url_map.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/modules/gcp_compute_region_url_map.py b/plugins/modules/gcp_compute_region_url_map.py index f29b128..2e323e5 100644 --- a/plugins/modules/gcp_compute_region_url_map.py +++ b/plugins/modules/gcp_compute_region_url_map.py @@ -124,7 +124,7 @@ options: key ''selfLink'' and value of your resource''s selfLink Alternatively, you can add `register: name-of-resource` to a gcp_compute_region_backend_service task and then set this default_service field to "{{ name-of-resource }}"' - required: true + required: false type: dict description: description: @@ -3143,7 +3143,7 @@ def main(): type='list', elements='dict', options=dict( - default_service=dict(required=True, type='dict'), + default_service=dict(type='dict'), description=dict(type='str'), name=dict(required=True, type='str'), route_rules=dict(