From 881df11844eba55882da1d0a6a96e65ddb12b9be Mon Sep 17 00:00:00 2001 From: Tyler Allen Date: Wed, 24 Nov 2021 10:57:37 -0600 Subject: [PATCH 1/2] add ability to detect and update network tags. --- plugins/modules/gcp_compute_instance.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/plugins/modules/gcp_compute_instance.py b/plugins/modules/gcp_compute_instance.py index b62286d..6966f83 100644 --- a/plugins/modules/gcp_compute_instance.py +++ b/plugins/modules/gcp_compute_instance.py @@ -1229,8 +1229,17 @@ def update_fields(module, request, response): machine_type_update(module, request, response) if response.get('shieldedInstanceConfig') != request.get('shieldedInstanceConfig'): shielded_instance_config_update(module, request, response) + if response.get("tags") != request.get("tags"): + tag_fingerprint_update(module,request,response) +def tag_fingerprint_update(module, request, response): + auth = GcpSession(module, 'compute') + auth.post( + ''.join(["https://compute.googleapis.com/compute/v1/", "projects/{project}/zones/{zone}/instances/{name}/setTags"]).format(**module.params), + {u'fingerprint': response.get('tags',{}).get('fingerprint'), u'items': module.params.get('tags', {}).get('items')}, + ) + def label_fingerprint_update(module, request, response): auth = GcpSession(module, 'compute') auth.post( From 6acff204b20a9422d7d32ff752eef6603e25bba0 Mon Sep 17 00:00:00 2001 From: Tyler Allen Date: Wed, 24 Nov 2021 11:51:17 -0600 Subject: [PATCH 2/2] more robust --- plugins/modules/gcp_compute_instance.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/plugins/modules/gcp_compute_instance.py b/plugins/modules/gcp_compute_instance.py index 6966f83..4bd85d6 100644 --- a/plugins/modules/gcp_compute_instance.py +++ b/plugins/modules/gcp_compute_instance.py @@ -1233,11 +1233,16 @@ def update_fields(module, request, response): tag_fingerprint_update(module,request,response) + + def tag_fingerprint_update(module, request, response): auth = GcpSession(module, 'compute') + if not module.params.get('tags'): + module.params['tags'] = {} + module.params['tags']['fingerprint'] = response.get('tags', {}).get('fingerprint') auth.post( ''.join(["https://compute.googleapis.com/compute/v1/", "projects/{project}/zones/{zone}/instances/{name}/setTags"]).format(**module.params), - {u'fingerprint': response.get('tags',{}).get('fingerprint'), u'items': module.params.get('tags', {}).get('items')}, + InstanceTags(module.params.get('tags', {}), module).to_request(), ) def label_fingerprint_update(module, request, response):