The Last of the Facts Modules

<!-- This change is generated by MagicModules. -->
/cc @rambleraptor

plugins/modules/gcp_sql_database_facts.py

@@ -18,78 +18,83 @@
 # ----------------------------------------------------------------------------
 
 from __future__ import absolute_import, division, print_function
-
 __metaclass__ = type
 
 ################################################################################
 # Documentation
 ################################################################################
 
-ANSIBLE_METADATA = {'metadata_version': '1.1', 'status': ["preview"], 'supported_by': 'community'}
+ANSIBLE_METADATA = {'metadata_version': '1.1',
+                    'status': ["preview"],
+                    'supported_by': 'community'}
 
 DOCUMENTATION = '''
 ---
 module: gcp_sql_database_facts
 description:
-- Gather facts for GCP Database
+  - Gather facts for GCP Database
 short_description: Gather facts for GCP Database
 version_added: 2.8
 author: Google Inc. (@googlecloudplatform)
 requirements:
-- python >= 2.6
-- requests >= 2.18.4
-- google-auth >= 1.3.0
+    - python >= 2.6
+    - requests >= 2.18.4
+    - google-auth >= 1.3.0
 options:
-  instance:
-    description:
-    - The name of the Cloud SQL instance. This does not include the project ID.
-    required: true
+    instance:
+        description:
+            - The name of the Cloud SQL instance. This does not include the project ID.
+            - 'This field represents a link to a Instance resource in GCP. It can be specified
+              in two ways. You can add `register: name-of-resource` to a gcp_sql_instance task
+              and then set this instance field to "{{ name-of-resource }}" Alternatively, you
+              can set this instance to a dictionary with the name key where the value is the name
+              of your Instance.'
+        required: true
 extends_documentation_fragment: gcp
 '''
 
 EXAMPLES = '''
-- name: " a database facts"
+- name:  a database facts
   gcp_sql_database_facts:
-    instance: "{{ instance }}"
-    project: test_project
-    auth_kind: serviceaccount
-    service_account_file: "/tmp/auth.pem"
-    state: facts
+      instance: "{{ instance }}"
+      project: test_project
+      auth_kind: serviceaccount
+      service_account_file: "/tmp/auth.pem"
 '''
 
 RETURN = '''
-resources:
-  description: List of resources
-  returned: always
-  type: complex
-  contains:
-    charset:
-      description:
-      - The MySQL charset value.
-      returned: success
-      type: str
-    collation:
-      description:
-      - The MySQL collation value.
-      returned: success
-      type: str
-    name:
-      description:
-      - The name of the database in the Cloud SQL instance.
-      - This does not include the project ID or instance name.
-      returned: success
-      type: str
-    instance:
-      description:
-      - The name of the Cloud SQL instance. This does not include the project ID.
-      returned: success
-      type: str
+items:
+    description: List of items
+    returned: always
+    type: complex
+    contains:
+        charset:
+            description:
+                - The MySQL charset value.
+            returned: success
+            type: str
+        collation:
+            description:
+                - The MySQL collation value.
+            returned: success
+            type: str
+        name:
+            description:
+                - The name of the database in the Cloud SQL instance.
+                - This does not include the project ID or instance name.
+            returned: success
+            type: str
+        instance:
+            description:
+                - The name of the Cloud SQL instance. This does not include the project ID.
+            returned: success
+            type: dict
 '''
 
 ################################################################################
 # Imports
 ################################################################################
-from ansible.module_utils.gcp_utils import navigate_hash, GcpSession, GcpModule, GcpRequest
+from ansible.module_utils.gcp_utils import navigate_hash, GcpSession, GcpModule, GcpRequest, replace_resource_dict
 import json
 
 ################################################################################
@@ -98,9 +103,13 @@ import json
 
 
 def main():
-    module = GcpModule(argument_spec=dict(instance=dict(required=True, type='str')))
+    module = GcpModule(
+        argument_spec=dict(
+            instance=dict(required=True, type='dict')
+        )
+    )
 
-    if not module.params['scopes']:
+    if 'scopes' not in module.params:
         module.params['scopes'] = ['https://www.googleapis.com/auth/sqlservice.admin']
 
     items = fetch_list(module, collection(module))
@@ -108,12 +117,18 @@ def main():
         items = items.get('items')
     else:
         items = []
-    return_value = {'resources': items}
+    return_value = {
+        'items': items
+    }
     module.exit_json(**return_value)
 
 
 def collection(module):
-    return "https://www.googleapis.com/sql/v1beta4/projects/{project}/instances/{instance}/databases".format(**module.params)
+    res = {
+        'project': module.params['project'],
+        'instance': replace_resource_dict(module.params['instance'], 'name')
+    }
+    return "https://www.googleapis.com/sql/v1beta4/projects/{project}/instances/{instance}/databases".format(**res)
 
 
 def fetch_list(module, link):