GCP MagicModules bug fixes (#47285)

Closes: #46930 #46929 #46928 #46927 #46926 #46925 #46924 #46923 #46922 #46921 #46920 #46919 #46918 #46917 #46916 #46915 #46914 #46913 #46912 #46911 #46910 #46909 #46908 #46907 #46906 #46905 #46903 #46902 #46901 #46900 #46899 #46898 #46897 #46896 #46895 #46894 #46893 #46892 #46891 #46890 #46889 #46888 #46887 #46886 #46885 #46884 #46883 #46882 #46881 #46880 #46879 #46878 #46877 #46876 #46875 #46874 #46873 #46872 #46871 #46870 #46869 #46868 #46867 #46866 #46865 #46864 #46863 #46862 #46861 #46860 #46859 #46858 #46857 #46856 #46855 #46854 #46853 #46852

plugins/modules/gcp_compute_firewall_facts.py

@@ -56,7 +56,7 @@ EXAMPLES = '''
       filters:
       - name = test_object
       project: test_project
-      auth_kind: service_account
+      auth_kind: serviceaccount
       service_account_file: "/tmp/auth.pem"
 '''
 
@@ -88,17 +88,61 @@ items:
                         - 'Example inputs include: ["22"], ["80","443"], and ["12345-12349"].'
                     returned: success
                     type: list
-        creation_timestamp:
+        creationTimestamp:
             description:
                 - Creation timestamp in RFC3339 text format.
             returned: success
             type: str
+        denied:
+            description:
+                - The list of DENY rules specified by this firewall. Each rule specifies a protocol
+                  and port-range tuple that describes a denied connection.
+            returned: success
+            type: complex
+            contains:
+                ip_protocol:
+                    description:
+                        - The IP protocol to which this rule applies. The protocol type is required when creating
+                          a firewall rule. This value can either be one of the following well known protocol
+                          strings (tcp, udp, icmp, esp, ah, sctp), or the IP protocol number.
+                    returned: success
+                    type: str
+                ports:
+                    description:
+                        - An optional list of ports to which this rule applies. This field is only applicable
+                          for UDP or TCP protocol. Each entry must be either an integer or a range. If not
+                          specified, this rule applies to connections through any port.
+                        - 'Example inputs include: ["22"], ["80","443"], and ["12345-12349"].'
+                    returned: success
+                    type: list
         description:
             description:
                 - An optional description of this resource. Provide this property when you create
                   the resource.
             returned: success
             type: str
+        destinationRanges:
+            description:
+                - If destination ranges are specified, the firewall will apply only to traffic that
+                  has destination IP address in these ranges. These ranges must be expressed in CIDR
+                  format. Only IPv4 is supported.
+            returned: success
+            type: list
+        direction:
+            description:
+                - 'Direction of traffic to which this firewall applies; default is INGRESS. Note:
+                  For INGRESS traffic, it is NOT supported to specify destinationRanges; For EGRESS
+                  traffic, it is NOT supported to specify sourceRanges OR sourceTags.'
+            returned: success
+            type: str
+        disabled:
+            description:
+                - Denotes whether the firewall rule is disabled, i.e not applied to the network it
+                  is associated with. When set to true, the firewall rule is not enforced and the
+                  network behaves as if it did not exist. If this is unspecified, the firewall rule
+                  will be enabled.
+            returned: success
+            type: bool
         id:
             description:
                 - The unique identifier for the resource.
@@ -124,8 +168,17 @@ items:
                   networks/my-network projects/myproject/global/networks/my-network
                   global/networks/default .'
             returned: success
-            type: str
-        source_ranges:
+            type: dict
+        priority:
+            description:
+                - Priority for this rule. This is an integer between 0 and 65535, both inclusive.
+                  When not specified, the value assumed is 1000. Relative priorities determine precedence
+                  of conflicting rules. Lower value of priority implies higher precedence (eg, a rule
+                  with priority 0 has higher precedence than a rule with priority 1). DENY rules take
+                  precedence over ALLOW rules having equal priority.
+            returned: success
+            type: int
+        sourceRanges:
             description:
                 - If source ranges are specified, the firewall will apply only to traffic that has
                   source IP address in these ranges. These ranges must be expressed in CIDR format.
@@ -135,7 +188,20 @@ items:
                   does not need to match both properties for the firewall to apply. Only IPv4 is supported.
             returned: success
             type: list
-        source_tags:
+        sourceServiceAccounts:
+            description:
+                - If source service accounts are specified, the firewall will apply only to traffic
+                  originating from an instance with a service account in this list. Source service
+                  accounts cannot be used to control traffic to an instance's external IP address
+                  because service accounts are associated with an instance, not an IP address. sourceRanges
+                  can be set at the same time as sourceServiceAccounts. If both are set, the firewall
+                  will apply to traffic that has source IP address within sourceRanges OR the source
+                  IP belongs to an instance with service account listed in sourceServiceAccount. The
+                  connection does not need to match both properties for the firewall to apply. sourceServiceAccounts
+                  cannot be used at the same time as sourceTags or targetTags.
+            returned: success
+            type: list
+        sourceTags:
             description:
                 - If source tags are specified, the firewall will apply only to traffic with source
                   IP that belongs to a tag listed in source tags. Source tags cannot be used to control
@@ -147,7 +213,16 @@ items:
                   firewall to apply.
             returned: success
             type: list
-        target_tags:
+        targetServiceAccounts:
+            description:
+                - A list of service accounts indicating sets of instances located in the network that
+                  may make network connections as specified in allowed[].
+                - targetServiceAccounts cannot be used at the same time as targetTags or sourceTags.
+                  If neither targetServiceAccounts nor targetTags are specified, the firewall rule
+                  applies to all instances on the specified network.
+            returned: success
+            type: list
+        targetTags:
             description:
                 - A list of instance tags indicating sets of instances located in the network that
                   may make network connections as specified in allowed[].
@@ -171,7 +246,7 @@ import json
 def main():
     module = GcpModule(
         argument_spec=dict(
-            filters=dict(type='list', elements='str'),
+            filters=dict(type='list', elements='str')
         )
     )