Bug fixes for gcp_compute_target_tcp_proxy (#42827)

This commit is contained in:
Alex Stephen 2018-08-14 06:53:46 -07:00
commit 4ef1909aab
2 changed files with 80 additions and 76 deletions

View file

@ -15,18 +15,16 @@
# Pre-test setup
- name: create a instance group
gcp_compute_instance_group:
name: 'instancegroup-targettcpproxy'
zone: 'us-central1-a'
name: "instancegroup-targettcpproxy"
zone: us-central1-a
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: present
register: instancegroup
- name: create a health check
gcp_compute_health_check:
name: 'healthcheck-targettcpproxy'
name: "healthcheck-targettcpproxy"
type: TCP
tcp_health_check:
port_name: service-health
@ -38,47 +36,39 @@
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: present
register: healthcheck
- name: create a backend service
gcp_compute_backend_service:
name: 'backendservice-targettcpproxy'
name: "backendservice-targettcpproxy"
backends:
- group: "{{ instancegroup }}"
- group: "{{ instancegroup }}"
health_checks:
- "{{ healthcheck.selfLink }}"
protocol: 'TCP'
- "{{ healthcheck.selfLink }}"
protocol: TCP
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: present
register: backendservice
- name: delete a target tcp proxy
gcp_compute_target_tcp_proxy:
name: "{{ resource_name }}"
proxy_header: 'PROXY_V1'
proxy_header: PROXY_V1
service: "{{ backendservice }}"
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: absent
#----------------------------------------------------------
- name: create a target tcp proxy
gcp_compute_target_tcp_proxy:
name: "{{ resource_name }}"
proxy_header: 'PROXY_V1'
proxy_header: PROXY_V1
service: "{{ backendservice }}"
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: present
register: result
- name: assert changed is true
@ -86,17 +76,29 @@
that:
- result.changed == true
- "result.kind == 'compute#targetTcpProxy'"
# ----------------------------------------------------------------------------
- name: create a target tcp proxy that already exists
gcp_compute_target_tcp_proxy:
name: "{{ resource_name }}"
proxy_header: 'PROXY_V1'
service: "{{ backendservice }}"
- name: verify that target_tcp_proxy was created
gcp_compute_target_tcp_proxy_facts:
filters:
- name = {{ resource_name }}
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
register: results
- name: verify that command succeeded
assert:
that:
- results['items'] | length == 1
# ----------------------------------------------------------------------------
- name: create a target tcp proxy that already exists
gcp_compute_target_tcp_proxy:
name: "{{ resource_name }}"
proxy_header: PROXY_V1
service: "{{ backendservice }}"
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
state: present
register: result
- name: assert changed is false
@ -108,13 +110,11 @@
- name: delete a target tcp proxy
gcp_compute_target_tcp_proxy:
name: "{{ resource_name }}"
proxy_header: 'PROXY_V1'
proxy_header: PROXY_V1
service: "{{ backendservice }}"
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: absent
register: result
- name: assert changed is true
@ -122,17 +122,29 @@
that:
- result.changed == true
- result.has_key('kind') == False
# ----------------------------------------------------------------------------
- name: delete a target tcp proxy that does not exist
gcp_compute_target_tcp_proxy:
name: "{{ resource_name }}"
proxy_header: 'PROXY_V1'
service: "{{ backendservice }}"
- name: verify that target_tcp_proxy was deleted
gcp_compute_target_tcp_proxy_facts:
filters:
- name = {{ resource_name }}
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
register: results
- name: verify that command succeeded
assert:
that:
- results['items'] | length == 0
# ----------------------------------------------------------------------------
- name: delete a target tcp proxy that does not exist
gcp_compute_target_tcp_proxy:
name: "{{ resource_name }}"
proxy_header: PROXY_V1
service: "{{ backendservice }}"
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
state: absent
register: result
- name: assert changed is false
@ -144,22 +156,20 @@
# Post-test teardown
- name: delete a backend service
gcp_compute_backend_service:
name: 'backendservice-targettcpproxy'
name: "backendservice-targettcpproxy"
backends:
- group: "{{ instancegroup }}"
- group: "{{ instancegroup }}"
health_checks:
- "{{ healthcheck.selfLink }}"
protocol: 'TCP'
- "{{ healthcheck.selfLink }}"
protocol: TCP
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: absent
register: backendservice
- name: delete a health check
gcp_compute_health_check:
name: 'healthcheck-targettcpproxy'
name: "healthcheck-targettcpproxy"
type: TCP
tcp_health_check:
port_name: service-health
@ -171,18 +181,14 @@
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: absent
register: healthcheck
- name: delete a instance group
gcp_compute_instance_group:
name: 'instancegroup-targettcpproxy'
zone: 'us-central1-a'
name: "instancegroup-targettcpproxy"
zone: us-central1-a
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
scopes:
- https://www.googleapis.com/auth/compute
state: absent
register: instancegroup