From 4cd61e66c11c93aa5a8d58bb866fc4d370bd73ab Mon Sep 17 00:00:00 2001
From: Yusuke Tsutsumi <yusuketsutsumi@google.com>
Date: Sun, 27 Nov 2022 06:03:40 +0000
Subject: [PATCH] tests: remove flakey spanner_database_info test

The spanner List API is returning intermittent 404s, which
is resulting in the spanner_database test failing every other
time.

Disabling the API until the test is more stable.
---
 .gitignore                                    |  3 +-
 .../gcp_spanner_database/tasks/autogen.yml    | 30 +++++++++++--------
 2 files changed, 19 insertions(+), 14 deletions(-)

diff --git a/.gitignore b/.gitignore
index 8c03bed..2277278 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,4 +2,5 @@
 tests/integration/cloud-config-gcp.ini
 # running ansible integration tests adds files here.
 tests/integration/inventory
-tests/output/
\ No newline at end of file
+tests/output/
+__pycache__
diff --git a/tests/integration/targets/gcp_spanner_database/tasks/autogen.yml b/tests/integration/targets/gcp_spanner_database/tasks/autogen.yml
index 1f4762d..5287f5d 100644
--- a/tests/integration/targets/gcp_spanner_database/tasks/autogen.yml
+++ b/tests/integration/targets/gcp_spanner_database/tasks/autogen.yml
@@ -89,19 +89,23 @@
   assert:
     that:
       - result.changed == true
-- name: verify that database was deleted
-  google.cloud.gcp_spanner_database_info:
-      instance: "{{ instance }}"
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/spanner.admin
-  register: results
-- name: verify that command succeeded
-  assert:
-    that:
-      - results['resources'] | map(attribute='name') | select("match", ".*webstore.*") | list | length == 0
+# commented out due to a flakey List endpoint
+# on the spanner API. (requests continue to return
+# 404s intermittently).
+# uncomment if it's desired to test the info.
+# - name: verify that database was deleted
+#   google.cloud.gcp_spanner_database_info:
+#       instance: "{{ instance }}"
+#       project: "{{ gcp_project }}"
+#       auth_kind: "{{ gcp_cred_kind }}"
+#       service_account_file: "{{ gcp_cred_file }}"
+#       scopes:
+#         - https://www.googleapis.com/auth/spanner.admin
+#   register: results
+# - name: verify that command succeeded
+#   assert:
+#     that:
+#       - results['resources'] | map(attribute='name') | select("match", ".*webstore.*") | list | length == 0
 # ----------------------------------------------------------------------------
 - name: delete a database that does not exist
   google.cloud.gcp_spanner_database: