Bug fixes for gcp_container_node_pool (#42830)

tests/integration/gcp_container_node_pool/tasks/main.yml

@@ -15,14 +15,12 @@
 # Pre-test setup
 - name: create a cluster
   gcp_container_cluster:
-      name: 'cluster-nodepool'
+      name: "cluster-nodepool"
       initial_node_count: 4
-      zone: 'us-central1-a'
+      zone: us-central1-a
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: present
   register: cluster
 - name: delete a node pool
@@ -30,12 +28,10 @@
       name: "{{ resource_name }}"
       initial_node_count: 4
       cluster: "{{ cluster }}"
-      zone: 'us-central1-a'
+      zone: us-central1-a
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: absent
 #----------------------------------------------------------
 - name: create a node pool
@@ -43,30 +39,42 @@
       name: "{{ resource_name }}"
       initial_node_count: 4
       cluster: "{{ cluster }}"
-      zone: 'us-central1-a'
+      zone: us-central1-a
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: present
   register: result
 - name: assert changed is true
   assert:
     that:
       - result.changed == true
+- name: verify that node_pool was created
+  gcp_container_node_pool_facts:
+      filters:
+         - name = {{ resource_name }}
+      cluster: {{ cluster }}
+      zone: us-central1-a
+      project: "{{ gcp_project }}"
+      auth_kind: "{{ gcp_cred_kind }}"
+      service_account_file: "{{ gcp_cred_file }}"
+      scopes:
+        - https://www.googleapis.com/auth/cloud-platform
+  register: results
+- name: verify that command succeeded
+  assert:
+    that:
+      - results['items'] | length == 1
 # ----------------------------------------------------------------------------
 - name: create a node pool that already exists
   gcp_container_node_pool:
       name: "{{ resource_name }}"
       initial_node_count: 4
       cluster: "{{ cluster }}"
-      zone: 'us-central1-a'
+      zone: us-central1-a
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: present
   register: result
 - name: assert changed is false
@@ -79,30 +87,42 @@
       name: "{{ resource_name }}"
       initial_node_count: 4
       cluster: "{{ cluster }}"
-      zone: 'us-central1-a'
+      zone: us-central1-a
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: absent
   register: result
 - name: assert changed is true
   assert:
     that:
       - result.changed == true
+- name: verify that node_pool was deleted
+  gcp_container_node_pool_facts:
+      filters:
+         - name = {{ resource_name }}
+      cluster: {{ cluster }}
+      zone: us-central1-a
+      project: "{{ gcp_project }}"
+      auth_kind: "{{ gcp_cred_kind }}"
+      service_account_file: "{{ gcp_cred_file }}"
+      scopes:
+        - https://www.googleapis.com/auth/cloud-platform
+  register: results
+- name: verify that command succeeded
+  assert:
+    that:
+      - results['items'] | length == 0
 # ----------------------------------------------------------------------------
 - name: delete a node pool that does not exist
   gcp_container_node_pool:
       name: "{{ resource_name }}"
       initial_node_count: 4
       cluster: "{{ cluster }}"
-      zone: 'us-central1-a'
+      zone: us-central1-a
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: absent
   register: result
 - name: assert changed is false
@@ -113,13 +133,11 @@
 # Post-test teardown
 - name: delete a cluster
   gcp_container_cluster:
-      name: 'cluster-nodepool'
+      name: "cluster-nodepool"
       initial_node_count: 4
-      zone: 'us-central1-a'
+      zone: us-central1-a
       project: "{{ gcp_project }}"
       auth_kind: "{{ gcp_cred_kind }}"
       service_account_file: "{{ gcp_cred_file }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
       state: absent
   register: cluster