ansible-collections/google.cloud
1
0
Fork 0
mirror of https://github.com/ansible-collections/google.cloud.git synced 2025-07-28 23:51:32 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix gcp_iam_role not updating

Browse source 
gcp_iam_role was not updating previously. The API uses a PATCH and
not a PUT.

Also fixing an accidental leftover diff from a bad merge.

fixes #236.
This commit is contained in:
Yusuke Tsutsumi 2022-12-16 00:29:24 +00:00 • committed by Yusuke Tsutsumi
commit 2db181d084
6 changed files with 41 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

34
tests/integration/targets/gcp_iam_role/tasks/autogen.yml
View file

@ -15,7 +15,7 @@
# Pre-test setup
- name: delete a role
google.cloud.gcp_iam_role:
name: role_{{ resource_name.split("-")[-1] }}
name: "{{ resource_prefix[0:30].replace('-', '_') }}"
title: My Custom Role
description: My custom role description
included_permissions:
@ -29,7 +29,7 @@
#----------------------------------------------------------
- name: create a role
google.cloud.gcp_iam_role:
name: role_{{ resource_name.split("-")[-1] }}
name: "{{ resource_prefix[0:30].replace('-', '_') }}"
title: My Custom Role
description: My custom role description
included_permissions:
@ -56,11 +56,11 @@
- name: verify that command succeeded
assert:
that:
- results['resources'] | map(attribute='name') | select("match", ".*role_{{ resource_name.split("-")[-1] }}.*") | list | length == 1
- results['resources'] | map(attribute='name') | select("match", ".*{{ resource_prefix[0:30].replace('-', '_') }}.*") | list | length == 1
# ----------------------------------------------------------------------------
- name: create a role that already exists
google.cloud.gcp_iam_role:
name: role_{{ resource_name.split("-")[-1] }}
name: "{{ resource_prefix[0:30].replace('-', '_') }}"
title: My Custom Role
description: My custom role description
included_permissions:
@ -76,10 +76,30 @@
assert:
that:
- result.changed == false
# ----------------------------------------------------------------------------
- name: modify an IAM role that already exists
google.cloud.gcp_iam_role:
name: "{{ resource_prefix[0:30].replace('-', '_') }}"
title: My Custom Role
description: My custom role description
included_permissions:
- storage.buckets.get
- storage.buckets.list
- storage.objects.get
- storage.objects.list
project: "{{ gcp_project }}"
auth_kind: "{{ gcp_cred_kind }}"
service_account_file: "{{ gcp_cred_file }}"
state: present
register: result
- name: assert changed is true
assert:
that:
- result.changed == true
#----------------------------------------------------------
- name: delete a role
google.cloud.gcp_iam_role:
name: role_{{ resource_name.split("-")[-1] }}
name: "{{ resource_prefix[0:30].replace('-', '_') }}"
title: My Custom Role
description: My custom role description
included_permissions:
@ -106,11 +126,11 @@
- name: verify that command succeeded
assert:
that:
- results['resources'] | map(attribute='name') | select("match", ".*role_{{ resource_name.split("-")[-1] }}.*") | list | length == 0
- results['resources'] | map(attribute='name') | select("match", ".*{{ resource_prefix[0:30].replace('-', '_') }}.*") | list | length == 0
# ----------------------------------------------------------------------------
- name: delete a role that does not exist
google.cloud.gcp_iam_role:
name: role_{{ resource_name.split("-")[-1] }}
name: "{{ resource_prefix[0:30].replace('-', '_') }}"
title: My Custom Role
description: My custom role description
included_permissions: