fix: upgrade ansible version, address test and lint errors

tests/integration/targets/gcp_sql_instance/tasks/autogen.yml

@@ -13,14 +13,14 @@
 #
 # ----------------------------------------------------------------------------
 # Pre-test setup
-- name: delete a instance
+- name: Delete a instance
   google.cloud.gcp_sql_instance:
-    name: "{{resource_name}}-2"
+    name: "{{ resource_name }}-2"
     settings:
       ip_configuration:
         authorized_networks:
-        - name: google dns server
-          value: 8.8.8.8/32
+          - name: google dns server
+            value: 8.8.8.8/32
       tier: db-n1-standard-1
     region: us-central1
     project: "{{ gcp_project }}"
@@ -28,14 +28,14 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
 #----------------------------------------------------------
-- name: create a instance
+- name: Create a instance
   google.cloud.gcp_sql_instance:
-    name: "{{resource_name}}-2"
+    name: "{{ resource_name }}-2"
     settings:
       ip_configuration:
         authorized_networks:
-        - name: google dns server
-          value: 8.8.8.8/32
+          - name: google dns server
+            value: 8.8.8.8/32
       tier: db-n1-standard-1
     region: us-central1
     project: "{{ gcp_project }}"
@@ -43,31 +43,31 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that instance was created
+- name: Verify that instance was created
   google.cloud.gcp_sql_instance_info:
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/sqlservice.admin
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/sqlservice.admin
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
-      - results['resources'] | map(attribute='name') | select("match", ".*{{resource_name}}-2.*") | list | length == 1
+      - results['resources'] | map(attribute='name') | select("match", ".*{{ resource_name }}-2.*") | list | length == 1
 # ----------------------------------------------------------------------------
-- name: create a instance that already exists
+- name: Create a instance that already exists
   google.cloud.gcp_sql_instance:
-    name: "{{resource_name}}-2"
+    name: "{{ resource_name }}-2"
     settings:
       ip_configuration:
         authorized_networks:
-        - name: google dns server
-          value: 8.8.8.8/32
+          - name: google dns server
+            value: 8.8.8.8/32
       tier: db-n1-standard-1
     region: us-central1
     project: "{{ gcp_project }}"
@@ -75,19 +75,19 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #----------------------------------------------------------
-- name: delete a instance
+- name: Delete a instance
   google.cloud.gcp_sql_instance:
-    name: "{{resource_name}}-2"
+    name: "{{ resource_name }}-2"
     settings:
       ip_configuration:
         authorized_networks:
-        - name: google dns server
-          value: 8.8.8.8/32
+          - name: google dns server
+            value: 8.8.8.8/32
       tier: db-n1-standard-1
     region: us-central1
     project: "{{ gcp_project }}"
@@ -95,31 +95,31 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that instance was deleted
+- name: Verify that instance was deleted
   google.cloud.gcp_sql_instance_info:
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/sqlservice.admin
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/sqlservice.admin
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
-      - results['resources'] | map(attribute='name') | select("match", ".*{{resource_name}}-2.*") | list | length == 0
+      - results['resources'] | map(attribute='name') | select("match", ".*{{ resource_name }}-2.*") | list | length == 0
 # ----------------------------------------------------------------------------
-- name: delete a instance that does not exist
+- name: Delete a instance that does not exist
   google.cloud.gcp_sql_instance:
-    name: "{{resource_name}}-2"
+    name: "{{ resource_name }}-2"
     settings:
       ip_configuration:
         authorized_networks:
-        - name: google dns server
-          value: 8.8.8.8/32
+          - name: google dns server
+            value: 8.8.8.8/32
       tier: db-n1-standard-1
     region: us-central1
     project: "{{ gcp_project }}"
@@ -127,7 +127,7 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false

tests/integration/targets/gcp_sql_instance/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: autogen.yml
+- name: Generated tests
+  ansible.builtin.include_tasks: autogen.yml