fix: upgrade ansible version, address test and lint errors

tests/integration/targets/gcp_iam_role/tasks/autogen.yml

@@ -13,136 +13,136 @@
 #
 # ----------------------------------------------------------------------------
 # Pre-test setup
-- name: delete a role
+- name: Delete a role
   google.cloud.gcp_iam_role:
     name: "{{ resource_prefix[0:30].replace('-', '_') }}"
     title: My Custom Role
     description: My custom role description
     included_permissions:
-    - iam.roles.list
-    - iam.roles.create
-    - iam.roles.delete
+      - iam.roles.list
+      - iam.roles.create
+      - iam.roles.delete
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
 #----------------------------------------------------------
-- name: create a role
+- name: Create a role
   google.cloud.gcp_iam_role:
     name: "{{ resource_prefix[0:30].replace('-', '_') }}"
     title: My Custom Role
     description: My custom role description
     included_permissions:
-    - iam.roles.list
-    - iam.roles.create
-    - iam.roles.delete
+      - iam.roles.list
+      - iam.roles.create
+      - iam.roles.delete
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that role was created
+- name: Verify that role was created
   google.cloud.gcp_iam_role_info:
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/iam
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/iam
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | map(attribute='name') | select("match", ".*{{ resource_prefix[0:30].replace('-', '_') }}.*") | list | length == 1
 # ----------------------------------------------------------------------------
-- name: create a role that already exists
+- name: Create a role that already exists
   google.cloud.gcp_iam_role:
     name: "{{ resource_prefix[0:30].replace('-', '_') }}"
     title: My Custom Role
     description: My custom role description
     included_permissions:
-    - iam.roles.list
-    - iam.roles.create
-    - iam.roles.delete
+      - iam.roles.list
+      - iam.roles.create
+      - iam.roles.delete
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 # ----------------------------------------------------------------------------
-- name: modify an IAM role that already exists
+- name: Modify an IAM role that already exists
   google.cloud.gcp_iam_role:
     name: "{{ resource_prefix[0:30].replace('-', '_') }}"
     title: My Custom Role
     description: My custom role description
     included_permissions:
-    - storage.buckets.get
-    - storage.buckets.list
-    - storage.objects.get
-    - storage.objects.list
+      - storage.buckets.get
+      - storage.buckets.list
+      - storage.objects.get
+      - storage.objects.list
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
 #----------------------------------------------------------
-- name: delete a role
+- name: Delete a role
   google.cloud.gcp_iam_role:
     name: "{{ resource_prefix[0:30].replace('-', '_') }}"
     title: My Custom Role
     description: My custom role description
     included_permissions:
-    - iam.roles.list
-    - iam.roles.create
-    - iam.roles.delete
+      - iam.roles.list
+      - iam.roles.create
+      - iam.roles.delete
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that role was deleted
+- name: Verify that role was deleted
   google.cloud.gcp_iam_role_info:
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/iam
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/iam
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | map(attribute='name') | select("match", ".*{{ resource_prefix[0:30].replace('-', '_') }}.*") | list | length == 0
 # ----------------------------------------------------------------------------
-- name: delete a role that does not exist
+- name: Delete a role that does not exist
   google.cloud.gcp_iam_role:
     name: "{{ resource_prefix[0:30].replace('-', '_') }}"
     title: My Custom Role
     description: My custom role description
     included_permissions:
-    - iam.roles.list
-    - iam.roles.create
-    - iam.roles.delete
+      - iam.roles.list
+      - iam.roles.create
+      - iam.roles.delete
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false

tests/integration/targets/gcp_iam_role/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: autogen.yml
+- name: Generated tests
+  ansible.builtin.include_tasks: autogen.yml