fix: upgrade ansible version, address test and lint errors

tests/integration/targets/gcp_filestore_instance/tasks/autogen.yml

@@ -13,133 +13,133 @@
 #
 # ----------------------------------------------------------------------------
 # Pre-test setup
-- name: delete a instance
+- name: Delete a instance
   google.cloud.gcp_filestore_instance:
     name: "{{ resource_name }}"
     zone: us-central1-b
     tier: PREMIUM
     file_shares:
-    - capacity_gb: 2660
-      name: share1
+      - capacity_gb: 2660
+        name: share1
     networks:
-    - network: default
-      modes:
-      - MODE_IPV4
+      - network: default
+        modes:
+          - MODE_IPV4
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
 #----------------------------------------------------------
-- name: create a instance
+- name: Create a instance
   google.cloud.gcp_filestore_instance:
     name: "{{ resource_name }}"
     zone: us-central1-b
     tier: PREMIUM
     file_shares:
-    - capacity_gb: 2660
-      name: share1
+      - capacity_gb: 2660
+        name: share1
     networks:
-    - network: default
-      modes:
-      - MODE_IPV4
+      - network: default
+        modes:
+          - MODE_IPV4
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that instance was created
+- name: Verify that instance was created
   google.cloud.gcp_filestore_instance_info:
-      zone: us-central1-b
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
+    zone: us-central1-b
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/cloud-platform
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | map(attribute='name') | select("match", ".*{{ resource_name }}.*") | list | length == 1
 # ----------------------------------------------------------------------------
-- name: create a instance that already exists
+- name: Create a instance that already exists
   google.cloud.gcp_filestore_instance:
     name: "{{ resource_name }}"
     zone: us-central1-b
     tier: PREMIUM
     file_shares:
-    - capacity_gb: 2660
-      name: share1
+      - capacity_gb: 2660
+        name: share1
     networks:
-    - network: default
-      modes:
-      - MODE_IPV4
+      - network: default
+        modes:
+          - MODE_IPV4
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #----------------------------------------------------------
-- name: delete a instance
+- name: Delete a instance
   google.cloud.gcp_filestore_instance:
     name: "{{ resource_name }}"
     zone: us-central1-b
     tier: PREMIUM
     file_shares:
-    - capacity_gb: 2660
-      name: share1
+      - capacity_gb: 2660
+        name: share1
     networks:
-    - network: default
-      modes:
-      - MODE_IPV4
+      - network: default
+        modes:
+          - MODE_IPV4
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that instance was deleted
+- name: Verify that instance was deleted
   google.cloud.gcp_filestore_instance_info:
-      zone: us-central1-b
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
+    zone: us-central1-b
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/cloud-platform
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | map(attribute='name') | select("match", ".*{{ resource_name }}.*") | list | length == 0
 # ----------------------------------------------------------------------------
-- name: delete a instance that does not exist
+- name: Delete a instance that does not exist
   google.cloud.gcp_filestore_instance:
     name: "{{ resource_name }}"
     zone: us-central1-b
     tier: PREMIUM
     file_shares:
-    - capacity_gb: 2660
-      name: share1
+      - capacity_gb: 2660
+        name: share1
     networks:
-    - network: default
-      modes:
-      - MODE_IPV4
+      - network: default
+        modes:
+          - MODE_IPV4
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false

tests/integration/targets/gcp_filestore_instance/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: autogen.yml
+- name: Generated tests
+  ansible.builtin.include_tasks: autogen.yml