fix: upgrade ansible version, address test and lint errors

tests/integration/targets/gcp_compute_url_map/tasks/autogen.yml

@@ -13,7 +13,7 @@
 #
 # ----------------------------------------------------------------------------
 # Pre-test setup
-- name: create a instance group
+- name: Create a instance group
   google.cloud.gcp_compute_instance_group:
     name: instancegroup-urlmap
     zone: us-central1-a
@@ -22,7 +22,7 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: instancegroup
-- name: create a HTTP health check
+- name: Create a HTTP health check
   google.cloud.gcp_compute_http_health_check:
     name: httphealthcheck-urlmap
     healthy_threshold: 10
@@ -34,20 +34,20 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: healthcheck
-- name: create a backend service
+- name: Create a backend service
   google.cloud.gcp_compute_backend_service:
     name: backendservice-urlmap
     backends:
-    - group: "{{ instancegroup.selfLink }}"
+      - group: "{{ instancegroup.selfLink }}"
     health_checks:
-    - "{{ healthcheck.selfLink }}"
-    enable_cdn: 'true'
+      - "{{ healthcheck.selfLink }}"
+    enable_cdn: "true"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: backendservice
-- name: delete a URL map
+- name: Delete a URL map
   google.cloud.gcp_compute_url_map:
     name: "{{ resource_name }}"
     default_service: "{{ backendservice }}"
@@ -56,7 +56,7 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
 #----------------------------------------------------------
-- name: create a URL map
+- name: Create a URL map
   google.cloud.gcp_compute_url_map:
     name: "{{ resource_name }}"
     default_service: "{{ backendservice }}"
@@ -65,26 +65,26 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that url_map was created
+- name: Verify that url_map was created
   google.cloud.gcp_compute_url_map_info:
-      filters:
-         - name = {{ resource_name }}
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/compute
+    filters:
+      - name = {{ resource_name }}
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/compute
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | length == 1
 # ----------------------------------------------------------------------------
-- name: create a URL map that already exists
+- name: Create a URL map that already exists
   google.cloud.gcp_compute_url_map:
     name: "{{ resource_name }}"
     default_service: "{{ backendservice }}"
@@ -93,12 +93,12 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #----------------------------------------------------------
-- name: delete a URL map
+- name: Delete a URL map
   google.cloud.gcp_compute_url_map:
     name: "{{ resource_name }}"
     default_service: "{{ backendservice }}"
@@ -107,26 +107,26 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that url_map was deleted
+- name: Verify that url_map was deleted
   google.cloud.gcp_compute_url_map_info:
-      filters:
-         - name = {{ resource_name }}
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/compute
+    filters:
+      - name = {{ resource_name }}
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/compute
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | length == 0
 # ----------------------------------------------------------------------------
-- name: delete a URL map that does not exist
+- name: Delete a URL map that does not exist
   google.cloud.gcp_compute_url_map:
     name: "{{ resource_name }}"
     default_service: "{{ backendservice }}"
@@ -135,28 +135,28 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #---------------------------------------------------------
 # Post-test teardown
 # If errors happen, don't crash the playbook!
-- name: delete a backend service
+- name: Delete a backend service
   google.cloud.gcp_compute_backend_service:
     name: backendservice-urlmap
     backends:
-    - group: "{{ instancegroup.selfLink }}"
+      - group: "{{ instancegroup.selfLink }}"
     health_checks:
-    - "{{ healthcheck.selfLink }}"
-    enable_cdn: 'true'
+      - "{{ healthcheck.selfLink }}"
+    enable_cdn: "true"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: backendservice
   ignore_errors: true
-- name: delete a HTTP health check
+- name: Delete a HTTP health check
   google.cloud.gcp_compute_http_health_check:
     name: httphealthcheck-urlmap
     healthy_threshold: 10
@@ -169,7 +169,7 @@
     state: absent
   register: healthcheck
   ignore_errors: true
-- name: delete a instance group
+- name: Delete a instance group
   google.cloud.gcp_compute_instance_group:
     name: instancegroup-urlmap
     zone: us-central1-a

tests/integration/targets/gcp_compute_url_map/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: autogen.yml
+- name: Generated tests
+  ansible.builtin.include_tasks: autogen.yml