fix: upgrade ansible version, address test and lint errors

tests/integration/targets/gcp_compute_target_instance/tasks/autogen.yml

@@ -13,7 +13,7 @@
 #
 # ----------------------------------------------------------------------------
 # Pre-test setup
-- name: create a network
+- name: Create a network
   google.cloud.gcp_compute_network:
     name: network-instance
     project: "{{ gcp_project }}"
@@ -22,26 +22,26 @@
     auto_create_subnetworks: true
     state: present
   register: network
-- name: create a instance
+- name: Create a instance
   google.cloud.gcp_compute_instance:
     name: "{{ resource_name }}"
     machine_type: n1-standard-1
     disks:
-    - auto_delete: 'true'
-      boot: 'true'
-      initialize_params:
-        source_image: projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2204-lts
+      - auto_delete: "true"
+        boot: "true"
+        initialize_params:
+          source_image: projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2204-lts
     labels:
       environment: production
     network_interfaces:
-    - network: "{{ network }}"
+      - network: "{{ network }}"
     zone: us-central1-a
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: instance
-- name: delete a target instance
+- name: Delete a target instance
   google.cloud.gcp_compute_target_instance:
     name: target
     instance: "{{ instance }}"
@@ -51,7 +51,7 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
 #----------------------------------------------------------
-- name: create a target instance
+- name: Create a target instance
   google.cloud.gcp_compute_target_instance:
     name: target
     instance: "{{ instance }}"
@@ -61,27 +61,27 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that target_instance was created
+- name: Verify that target_instance was created
   google.cloud.gcp_compute_target_instance_info:
-      filters:
-         - name = target
-      zone: us-central1-a
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/compute
+    filters:
+      - name = target
+    zone: us-central1-a
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/compute
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | length == 1
 # ----------------------------------------------------------------------------
-- name: create a target instance that already exists
+- name: Create a target instance that already exists
   google.cloud.gcp_compute_target_instance:
     name: target
     instance: "{{ instance }}"
@@ -91,12 +91,12 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #----------------------------------------------------------
-- name: delete a target instance
+- name: Delete a target instance
   google.cloud.gcp_compute_target_instance:
     name: target
     instance: "{{ instance }}"
@@ -106,27 +106,27 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that target_instance was deleted
+- name: Verify that target_instance was deleted
   google.cloud.gcp_compute_target_instance_info:
-      filters:
-         - name = target
-      zone: us-central1-a
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/compute
+    filters:
+      - name = target
+    zone: us-central1-a
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/compute
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | length == 0
 # ----------------------------------------------------------------------------
-- name: delete a target instance that does not exist
+- name: Delete a target instance that does not exist
   google.cloud.gcp_compute_target_instance:
     name: target
     instance: "{{ instance }}"
@@ -136,26 +136,26 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #---------------------------------------------------------
 # Post-test teardown
 # If errors happen, don't crash the playbook!
-- name: delete a instance
+- name: Delete a instance
   google.cloud.gcp_compute_instance:
     name: "{{ resource_name }}"
     machine_type: n1-standard-1
     disks:
-    - auto_delete: 'true'
-      boot: 'true'
-      initialize_params:
-        source_image: projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2204-lts
+      - auto_delete: "true"
+        boot: "true"
+        initialize_params:
+          source_image: projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2204-lts
     labels:
       environment: production
     network_interfaces:
-    - network: "{{ network }}"
+      - network: "{{ network }}"
     zone: us-central1-a
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
@@ -163,7 +163,7 @@
     state: absent
   register: instance
   ignore_errors: true
-- name: delete a network
+- name: Delete a network
   google.cloud.gcp_compute_network:
     name: network-instance
     project: "{{ gcp_project }}"

tests/integration/targets/gcp_compute_target_instance/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: autogen.yml
+- name: Generated tests
+  ansible.builtin.include_tasks: autogen.yml