fix: upgrade ansible version, address test and lint errors

tests/integration/targets/gcp_compute_region_autoscaler/tasks/autogen.yml

@@ -13,7 +13,7 @@
 #
 # ----------------------------------------------------------------------------
 # Pre-test setup
-- name: create a network
+- name: Create a network
   google.cloud.gcp_compute_network:
     name: network-instancetemplate
     project: "{{ gcp_project }}"
@@ -22,7 +22,7 @@
     auto_create_subnetworks: true
     state: present
   register: network
-- name: create a address
+- name: Create a address
   google.cloud.gcp_compute_address:
     name: address-instancetemplate
     region: us-central1
@@ -31,28 +31,28 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: address
-- name: create a instance template
+- name: Create a instance template
   google.cloud.gcp_compute_instance_template:
     name: "{{ resource_name }}"
     properties:
       disks:
-      - auto_delete: 'true'
-        boot: 'true'
-        initialize_params:
-          source_image: projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2204-lts
+        - auto_delete: "true"
+          boot: "true"
+          initialize_params:
+            source_image: projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2204-lts
       machine_type: n1-standard-1
       network_interfaces:
-      - network: "{{ network }}"
-        access_configs:
-        - name: test-config
-          type: ONE_TO_ONE_NAT
-          nat_ip: "{{ address }}"
+        - network: "{{ network }}"
+          access_configs:
+            - name: test-config
+              type: ONE_TO_ONE_NAT
+              nat_ip: "{{ address }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: instancetemplate
-- name: create a region instance group manager
+- name: Create a region instance group manager
   google.cloud.gcp_compute_region_instance_group_manager:
     name: "{{ resource_name }}"
     base_instance_name: test1-child
@@ -64,7 +64,7 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: igrm
-- name: delete a region autoscaler
+- name: Delete a region autoscaler
   google.cloud.gcp_compute_region_autoscaler:
     name: my-region-autoscaler
     region: us-central1
@@ -73,14 +73,14 @@
       max_num_replicas: 5
       cool_down_period_sec: 60
       cpu_utilization:
-        utilization_target: 0.5
-    target: "{{igrm.selfLink}}"
+        utilization_target: !!float "0.5"
+    target: "{{ igrm.selfLink }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
 #----------------------------------------------------------
-- name: create a region autoscaler
+- name: Create a region autoscaler
   google.cloud.gcp_compute_region_autoscaler:
     name: my-region-autoscaler
     region: us-central1
@@ -89,34 +89,34 @@
       max_num_replicas: 5
       cool_down_period_sec: 60
       cpu_utilization:
-        utilization_target: 0.5
-    target: "{{igrm.selfLink}}"
+        utilization_target: !!float "0.5"
+    target: "{{ igrm.selfLink }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that region_autoscaler was created
+- name: Verify that region_autoscaler was created
   google.cloud.gcp_compute_region_autoscaler_info:
-      filters:
-         - name = my-region-autoscaler
-      region: us-central1
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/compute
+    filters:
+      - name = my-region-autoscaler
+    region: us-central1
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/compute
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | length == 1
 # ----------------------------------------------------------------------------
-- name: create a region autoscaler that already exists
+- name: Create a region autoscaler that already exists
   google.cloud.gcp_compute_region_autoscaler:
     name: my-region-autoscaler
     region: us-central1
@@ -125,19 +125,19 @@
       max_num_replicas: 5
       cool_down_period_sec: 60
       cpu_utilization:
-        utilization_target: 0.5
-    target: "{{igrm.selfLink}}"
+        utilization_target: !!float "0.5"
+    target: "{{ igrm.selfLink }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #----------------------------------------------------------
-- name: delete a region autoscaler
+- name: Delete a region autoscaler
   google.cloud.gcp_compute_region_autoscaler:
     name: my-region-autoscaler
     region: us-central1
@@ -146,34 +146,34 @@
       max_num_replicas: 5
       cool_down_period_sec: 60
       cpu_utilization:
-        utilization_target: 0.5
-    target: "{{igrm.selfLink}}"
+        utilization_target: !!float "0.5"
+    target: "{{ igrm.selfLink }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that region_autoscaler was deleted
+- name: Verify that region_autoscaler was deleted
   google.cloud.gcp_compute_region_autoscaler_info:
-      filters:
-         - name = my-region-autoscaler
-      region: us-central1
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/compute
+    filters:
+      - name = my-region-autoscaler
+    region: us-central1
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/compute
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | length == 0
 # ----------------------------------------------------------------------------
-- name: delete a region autoscaler that does not exist
+- name: Delete a region autoscaler that does not exist
   google.cloud.gcp_compute_region_autoscaler:
     name: my-region-autoscaler
     region: us-central1
@@ -182,21 +182,21 @@
       max_num_replicas: 5
       cool_down_period_sec: 60
       cpu_utilization:
-        utilization_target: 0.5
-    target: "{{igrm.selfLink}}"
+        utilization_target: !!float "0.5"
+    target: "{{ igrm.selfLink }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #---------------------------------------------------------
 # Post-test teardown
 # If errors happen, don't crash the playbook!
-- name: delete a region instance group manager
+- name: Delete a region instance group manager
   google.cloud.gcp_compute_region_instance_group_manager:
     name: "{{ resource_name }}"
     base_instance_name: test1-child
@@ -209,29 +209,29 @@
     state: absent
   register: igrm
   ignore_errors: true
-- name: delete a instance template
+- name: Delete a instance template
   google.cloud.gcp_compute_instance_template:
     name: "{{ resource_name }}"
     properties:
       disks:
-      - auto_delete: 'true'
-        boot: 'true'
-        initialize_params:
-          source_image: projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2204-lts
+        - auto_delete: "true"
+          boot: "true"
+          initialize_params:
+            source_image: projects/ubuntu-os-cloud/global/images/family/ubuntu-minimal-2204-lts
       machine_type: n1-standard-1
       network_interfaces:
-      - network: "{{ network }}"
-        access_configs:
-        - name: test-config
-          type: ONE_TO_ONE_NAT
-          nat_ip: "{{ address }}"
+        - network: "{{ network }}"
+          access_configs:
+            - name: test-config
+              type: ONE_TO_ONE_NAT
+              nat_ip: "{{ address }}"
     project: "{{ gcp_project }}"
     auth_kind: "{{ gcp_cred_kind }}"
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: instancetemplate
   ignore_errors: true
-- name: delete a address
+- name: Delete a address
   google.cloud.gcp_compute_address:
     name: address-instancetemplate
     region: us-central1
@@ -241,7 +241,7 @@
     state: absent
   register: address
   ignore_errors: true
-- name: delete a network
+- name: Delete a network
   google.cloud.gcp_compute_network:
     name: network-instancetemplate
     project: "{{ gcp_project }}"

tests/integration/targets/gcp_compute_region_autoscaler/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: autogen.yml
+- name: Generated tests
+  ansible.builtin.include_tasks: autogen.yml