fix: upgrade ansible version, address test and lint errors

tests/integration/targets/gcp_appengine_firewall_rule/defaults/main.yml

@@ -1,2 +1,2 @@
 ---
-resource_name: "{{ resource_prefix }}"
+resource_name: "{{ resource_prefix }}"

tests/integration/targets/gcp_appengine_firewall_rule/tasks/autogen.yml

@@ -13,7 +13,7 @@
 #
 # ----------------------------------------------------------------------------
 # Pre-test setup
-- name: delete a firewall rule
+- name: Delete a firewall rule
   google.cloud.gcp_appengine_firewall_rule:
     priority: 1000
     source_range: 10.0.0.0
@@ -23,7 +23,7 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
 #----------------------------------------------------------
-- name: create a firewall rule
+- name: Create a firewall rule
   google.cloud.gcp_appengine_firewall_rule:
     priority: 1000
     source_range: 10.0.0.0
@@ -33,24 +33,24 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that firewall_rule was created
+- name: Verify that firewall_rule was created
   google.cloud.gcp_appengine_firewall_rule_info:
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/cloud-platform
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       - results['resources'] | length >= 1
 # ----------------------------------------------------------------------------
-- name: create a firewall rule that already exists
+- name: Create a firewall rule that already exists
   google.cloud.gcp_appengine_firewall_rule:
     priority: 1000
     source_range: 10.0.0.0
@@ -60,12 +60,12 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: present
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false
 #----------------------------------------------------------
-- name: delete a firewall rule
+- name: Delete a firewall rule
   google.cloud.gcp_appengine_firewall_rule:
     priority: 1000
     source_range: 10.0.0.0
@@ -75,26 +75,26 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is true
-  assert:
+- name: Assert changed is true
+  ansible.builtin.assert:
     that:
       - result.changed == true
-- name: verify that firewall_rule was deleted
+- name: Verify that firewall_rule was deleted
   google.cloud.gcp_appengine_firewall_rule_info:
-      project: "{{ gcp_project }}"
-      auth_kind: "{{ gcp_cred_kind }}"
-      service_account_file: "{{ gcp_cred_file | default(omit) }}"
-      scopes:
-        - https://www.googleapis.com/auth/cloud-platform
+    project: "{{ gcp_project }}"
+    auth_kind: "{{ gcp_cred_kind }}"
+    service_account_file: "{{ gcp_cred_file | default(omit) }}"
+    scopes:
+      - https://www.googleapis.com/auth/cloud-platform
   register: results
-- name: verify that command succeeded
-  assert:
+- name: Verify that command succeeded
+  ansible.builtin.assert:
     that:
       # there is a default firewall rule that cannot be
       # deleted, so the length should be 1.
       - results['resources'] | length == 1
 # ----------------------------------------------------------------------------
-- name: delete a firewall rule that does not exist
+- name: Delete a firewall rule that does not exist
   google.cloud.gcp_appengine_firewall_rule:
     priority: 1000
     source_range: 10.0.0.0
@@ -104,7 +104,7 @@
     service_account_file: "{{ gcp_cred_file | default(omit) }}"
     state: absent
   register: result
-- name: assert changed is false
-  assert:
+- name: Assert changed is false
+  ansible.builtin.assert:
     that:
       - result.changed == false

tests/integration/targets/gcp_appengine_firewall_rule/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: autogen.yml
+- name: Generated tests
+  ansible.builtin.include_tasks: autogen.yml