Commit graph

94 commits

Author SHA1 Message Date
Jorge Rodriguez (A.K.A. Tiriel)
cf06d1de28
Merge f43676cb1f into a5ee4b3d1a 2021-03-16 08:33:35 +01:00
Sebastian Gumprich
a5ee4b3d1a
add mysql_full_version and suffix return variable (#115)
* add mysql_full_version and suffix return variable

add changelog fragment

* rephrase changelog fragment

* Update plugins/modules/mysql_info.py

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>

* Add changes as per PR review

* Add tests for new suffix output parameter

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
Co-authored-by: Jorge-Rodriguez <jorge.rodriguez@futurice.com>
2021-03-16 09:10:52 +02:00
Daniel Ziegenberg
2254b29178
change deprecated parameter pw and db (#116)
* change deprecated parameter pw to password

* change deprecated parameter db to database

* add changelog fragment
2021-03-16 07:15:12 +02:00
Andrew Klychkov
bd86e249d0
mysql_replication: add a reference to how to encrypted connection options (#118)
* mysql_replication: add a reference to how to encrypted connection options

* Fix sanity
2021-03-15 09:39:14 +01:00
Felix Fontein
884310cf24
Mark master_ssl_key as no_log=False. (#117) 2021-03-15 07:30:53 +01:00
Andrew Klychkov
baea97d24c
mysql_user: Add REPLICA MONITOR privilege to supported (#108)
* mysql_user: Add REPLICA MONITOR privilege to supported

* Add changelog fragment
2021-03-11 16:17:49 +01:00
Andrew Klychkov
fc2dd0079f
Add .keep file to changelog/fragments to make it always present (#113) 2021-03-10 18:16:18 +01:00
Andrew Klychkov
e8cb81b30e Release 1.3.0 commit 2021-03-08 17:22:17 +01:00
Andrew Klychkov
979588e2cd
mysql_user: add proper handling of INSERT, UPDATE, REFERENCES on columns (#107)
* mysql_user: add proper handling of INSERT, UPDATE, REFERENCES on columns

* Add changelog fragment

* fix sanity

* fix CI

* fix sanity

* fix CI

* make the assertion fairer

* Improve
2021-03-08 17:18:04 +01:00
Andrew Klychkov
2694464ffb
mysql_user: when grant select on columns, the module always report the state has changed (#100)
* mysql_user: fix the module is not idempotent when there is SELECT on columns granted

* add changelog fragment

* fix

* Add unit tests for has_select_on_col function

* Add unit tests for sort_column_order function

* Add unit tests for handle_select_on_col function

* Update a comment
2021-03-03 10:58:57 +01:00
Andrew Klychkov
e8dc2f2476
mysql_replication: deprecation of slave related options, adding alternatives (#97)
* mysql_replication: deprecation of slave related options, adding alternatives

* Add changelog fragment

* Integration tests getslave -> getreplica

* Change the rest of offending choices/comments

* Add announcement about replacing SLAVE to REPLICA in messages

* Deprecate offending values
2021-03-01 10:45:35 +01:00
Michael S
faab501326
Update README.md - Update ext. documentation links (#102) 2021-02-25 17:16:44 +02:00
Jorge-Rodriguez
f43676cb1f
Fix command quotes 2021-02-11 18:02:08 +02:00
Jorge-Rodriguez
d3d68e44a0
Include the password update tests in the play. 2021-02-11 09:23:45 +02:00
Jorge-Rodriguez
7bcf810afd
Fix changelog typo 2021-02-11 09:18:18 +02:00
Tom Van Looy
24a4137982
mysql_user: remove duplicate of REPLICATION SLAVE entry from valid privs frozenset (#95) 2021-02-10 09:38:47 +03:00
Andrew Klychkov
09ac98adb8
Fix galaxy.yml (#94) 2021-02-08 18:24:19 +03:00
Jorge-Rodriguez
d7c931f84f
Fix test conditionals 2021-02-07 14:01:53 +02:00
Jorge-Rodriguez
1146f66e09
Fix argument tuple 2021-02-07 13:27:35 +02:00
Jorge-Rodriguez
e9fd1db200
Fix function call 2021-02-07 11:01:56 +02:00
Jorge-Rodriguez
2fed868087
Fix PEP8 error 2021-02-07 10:37:14 +02:00
Jorge-Rodriguez
8f337edbe9
Fix function signature 2021-02-07 10:31:42 +02:00
Jorge-Rodriguez
bb45038ce7
Fix password lock time check 2021-02-07 10:23:31 +02:00
Jorge Rodriguez (A.K.A. Tiriel)
64aae9ba08
Supply empty string to re.match if value is not defined 2021-02-07 10:23:30 +02:00
Jorge-Rodriguez
f41a9ce08b
Fix key error 2021-02-07 10:23:30 +02:00
Jorge-Rodriguez
0502359633
Fix docstring 2021-02-07 10:23:30 +02:00
Jorge-Rodriguez
58d21f6f0e
Remove reference to unused msg 2021-02-07 10:23:29 +02:00
Jorge-Rodriguez
de75697d5f
Check account_locking values 2021-02-07 10:21:45 +02:00
Jorge-Rodriguez
9a303ac55a
Update module documentation 2021-02-07 10:11:24 +02:00
Jorge-Rodriguez
800d9a553b
Update changelog 2021-02-07 10:08:38 +02:00
Jorge-Rodriguez
c2d5b97b7a
Add changelog fragment 2021-02-07 10:08:38 +02:00
Jorge-Rodriguez
9730eeb52c
Log account locking warnings only when locking is requested 2021-02-07 10:08:38 +02:00
Jorge Rodriguez (A.K.A. Tiriel)
aaf70204cb
Fix version added
Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
2021-02-07 10:08:37 +02:00
Jorge-Rodriguez
6d795eab69
Fix assertions for versions that do not support account locking 2021-02-07 10:08:37 +02:00
Jorge-Rodriguez
2f26a6681f
Add account locking warnings on user add 2021-02-07 10:08:36 +02:00
Jorge-Rodriguez
0532ebd6ca
Fix parsing of versions with dashes 2021-02-07 10:08:36 +02:00
Jorge-Rodriguez
da9d82ecc6
Fix version added 2021-02-07 10:08:36 +02:00
Jorge-Rodriguez
46d7f4106e
Make dictionary comprehension 2.6 compatible 2021-02-07 10:08:35 +02:00
Jorge-Rodriguez
5646003189
Fix parsing of versions with dashes 2021-02-07 10:08:35 +02:00
Jorge-Rodriguez
9ffdeb0be3
Fix assertions 2021-02-07 10:08:34 +02:00
Jorge-Rodriguez
be0244e5bc
Introduce account locking functionality 2021-02-07 10:08:06 +02:00
Andrew Klychkov
31bd2b567f Release 1.2.0: add changelog 2021-01-18 09:27:46 +03:00
Steve Teahan
b25fb5974d
mysql_user: refactor to reduce execute() calls (#76)
This module does not currently log the SQL statements that it executes.
A change was proposed to add this functionality, but it would require
modifications in many sections of the code due to how many cursor.execute()
statements there currently are. This change simply consolidates the
number of execute() calls where it is trivial to do so.
2021-01-15 13:44:03 +03:00
Steve Teahan
06907715d7
mysql_user: fixed encrypted option for MySQL 8.0 and test coverage (#79)
* mysql_user: fixed encrypted option for MySQL 8.0 and test coverage

The purpose of this change was originally to expand test coverage to
unblock #76, but an issue was detected with the encrypted parameter on
MySQL 8.0 in the process of writing the tests. Additionally,
user_password_update_test.yml had been disabled at some point, so I
opted to replace it with two new files that will focus on the password
and plugin auth paths.

* Updated tests to cover a couple of missing branches

* Skip tests that rely on sha256_password if pymysql < 0.9

* Cover the case where pymysql isn't installed for plugin tests

* Added better plugin auth checking to tests and other minor changes

* Fixed version detection to explicitly handle MariaDB

* Removed unneeded import from previous change

* Remove whitespace that was introduced by change that was removed

* Added unit tests for missing coverage
2021-01-14 08:27:05 +03:00
Andrew Klychkov
2de3a57021
mysql_user: Add SHOW_ROUTINE privilege support (#87)
* mysql_user: Add SHOW_ROUTINE privilege support

* add changelog fragment

Co-authored-by: Andrew Klychkov <andrew.klychkov@gmail.com>
2021-01-13 09:36:23 +03:00
Andrew Klychkov
9eb007969c Generating changelog for release 1.1.2, remove fragments 2020-12-18 11:29:36 +03:00
Andrew Klychkov
af0811d764 Change release version in galaxy.yml 2020-12-18 11:28:05 +03:00
Andrew Klychkov
2cf7d60976 Add release 1.1.2 changelog fragment 2020-12-18 11:26:24 +03:00
Andrew Klychkov
ebe503823a
mysql_replication: fix crashes caused by deprecated terminology (#71)
* mysql_replication: fix crashes caused by deprecated terminology

* Fix unrelated sanity errors

* Tests: mysql 8.0.21 -> 8.022

* Adjust integration tests

* Add version check to the tests

* Add debug statement

* Adjust mysql version

* Fix tests

* Add unit tests

* Add changelog fragment

* Improve code and coverage

* Get rid of extra blank line

* Improve coverage

* Change suggested
2020-12-18 11:17:18 +03:00
Andrew Klychkov
b7e828a092
mysql_db: fix false warning related to unsafe_login_password (#74) 2020-12-18 10:56:49 +03:00