ansible-collections/community.mysql
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.mysql.git synced 2025-07-30 08:31:29 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix: grant revoked priv (#434)

Browse source 
* Fix: exclude mysql 8 from test_mysql_user's 'Assert that priv did not change' test

* Add tests to verify that GRANT permission is present after user modification

* Fix: do not revoke GRANT permission when it's already allowed and present in priv parameter

* Deduplicate tests name

Easier to debug this way

* Fix assertions named 'GRANT permission is present'

* Only revoke grant option if it exists and absence is requested

* Fix assertion comments

* Fix: Only revoke grant option if it exists and absence is requested

* Avoid pointless revocations when ALL are granted

* Assert that priv did not change on mariadb also

* Fix: sanity and unity tests

* Format long lines

* Add changelog fragment

Co-authored-by: Laurent Indermühle <laurent.indermuehle@pm.me>
This commit is contained in:
R.Sicart 2022-09-02 13:40:06 +02:00 • committed by GitHub
commit cc5cf98368
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 83 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
changelogs/fragments/434-do-not-revoke-grant-option-always.yaml Normal file
View file

@ -0,0 +1,5 @@
---
bugfixes:
- mysql_user - grant option was revoked accidentally when modifying users.
This fix revokes grant option only when privs are setup to do that
(https://github.com/ansible-collections/community.mysql/issues/77#issuecomment-1209693807).