From c242584baeb322bba79b547f28b9403cc2ced2b4 Mon Sep 17 00:00:00 2001 From: Alexander Skiba Date: Tue, 17 Jan 2023 10:34:20 +0100 Subject: [PATCH] mysql_user: enabled autocommit to support MySQL 8 (#483) * mysql_user: enabled autocommit to support MySQL 8 * Add changelog fragment * Link to issue instead of pull request in changelog fragment Co-authored-by: Andrew Klychkov Co-authored-by: Andrew Klychkov --- changelogs/fragments/479_enable_auto_commit.yml | 3 +++ plugins/modules/mysql_user.py | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/479_enable_auto_commit.yml diff --git a/changelogs/fragments/479_enable_auto_commit.yml b/changelogs/fragments/479_enable_auto_commit.yml new file mode 100644 index 0000000..5701f30 --- /dev/null +++ b/changelogs/fragments/479_enable_auto_commit.yml @@ -0,0 +1,3 @@ +--- +minor_changes: + - mysql_user - enable auto_commit to avoid MySQL metadata table lock (https://github.com/ansible-collections/community.mysql/issues/479). diff --git a/plugins/modules/mysql_user.py b/plugins/modules/mysql_user.py index 8acb8a3..bd488b0 100644 --- a/plugins/modules/mysql_user.py +++ b/plugins/modules/mysql_user.py @@ -433,13 +433,13 @@ def main(): if check_implicit_admin: try: cursor, db_conn = mysql_connect(module, "root", "", config_file, ssl_cert, ssl_key, ssl_ca, db, - connect_timeout=connect_timeout, check_hostname=check_hostname) + connect_timeout=connect_timeout, check_hostname=check_hostname, autocommit=True) except Exception: pass if not cursor: cursor, db_conn = mysql_connect(module, login_user, login_password, config_file, ssl_cert, ssl_key, ssl_ca, db, - connect_timeout=connect_timeout, check_hostname=check_hostname) + connect_timeout=connect_timeout, check_hostname=check_hostname, autocommit=True) except Exception as e: module.fail_json(msg="unable to connect to database, check login_user and login_password are correct or %s has the credentials. " "Exception message: %s" % (config_file, to_native(e)))