ansible-collections/community.mysql
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.mysql.git synced 2025-04-05 10:10:32 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

module_utils: to add a destructor, in order to explicitly close the connection when the Connection object is GC'd (#44)

Browse source 
* Monkey patch the Connection class

* Add changelog fragment
This commit is contained in:
Jorge Rodriguez (A.K.A. Tiriel) 2020-10-08 08:24:32 +03:00 • committed by GitHub
parent f6d552d95e
commit 9a377f6d91
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/44-close-connection.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- mysql modules - patch the ``Connection`` class to add a destructor that ensures connections to the server are explicitly closed (https://github.com/ansible-collections/community.mysql/pull/44).

6
plugins/module_utils/mysql.py
View file

@ -89,6 +89,12 @@ def mysql_connect(module, login_user=None, login_password=None, config_file='',
if autocommit:
db_connection.autocommit(True)
# Monkey patch the Connection class to close the connection when garbage collected
def _conn_patch(conn_self):
conn_self.close()
db_connection.__class__.__del__ = _conn_patch
# Patched
if cursor_class == 'DictCursor':
return db_connection.cursor(**{_mysql_cursor_param: mysql_driver.cursors.DictCursor}), db_connection
else: