fix more tests

This commit is contained in:
Sebastian Pfahl 2025-07-14 21:30:15 +02:00
commit 7c376590e7
2 changed files with 8 additions and 20 deletions

View file

@ -43,8 +43,8 @@ def test_uses_replica_terminology(f_output, c_output, c_ret_type):
[ [
(None, None, "START GROUP_REPLICATION "), (None, None, "START GROUP_REPLICATION "),
("repl_user", None, "START GROUP_REPLICATION USER='repl_user'"), ("repl_user", None, "START GROUP_REPLICATION USER='repl_user'"),
(None, "repl_pass", "START GROUP_REPLICATION"), (None, "repl_pass", "START GROUP_REPLICATION PASSWORD='repl_pass'"),
("repl_user", "repl_pass", "START GROUP_REPLICATION USER='repl_user' PASSWORD='repl_pass'"), ("repl_user", "repl_pass", "START GROUP_REPLICATION USER='repl_user', PASSWORD='repl_pass'"),
] ]
) )
def test_start_group_replication(user, password, expected_query): def test_start_group_replication(user, password, expected_query):
@ -66,7 +66,6 @@ def test_start_group_replication(user, password, expected_query):
assert result is True assert result is True
assert cursor.executed_queries[0] == expected_query assert cursor.executed_queries[0] == expected_query
assert cursor.executed_queries[1] == "SHOW STATUS LIKE 'group_replication_status';"
def test_stop_group_replication(): def test_stop_group_replication():
@ -82,7 +81,6 @@ def test_stop_group_replication():
assert result is True assert result is True
assert cursor.executed_queries[0] == "STOP GROUP_REPLICATION" assert cursor.executed_queries[0] == "STOP GROUP_REPLICATION"
assert cursor.executed_queries[1] == "SHOW STATUS LIKE 'group_replication_status';"
def test_start_group_replication_fail(): def test_start_group_replication_fail():

View file

@ -47,8 +47,8 @@ def test_uses_replica_terminology(f_output, c_output, c_ret_type):
[ [
(None, None, "START GROUP_REPLICATION "), (None, None, "START GROUP_REPLICATION "),
("repl_user", None, "START GROUP_REPLICATION USER='repl_user'"), ("repl_user", None, "START GROUP_REPLICATION USER='repl_user'"),
(None, "repl_pass", "START GROUP_REPLICATION"), (None, "repl_pass", "START GROUP_REPLICATION PASSWORD='repl_pass'"),
("repl_user", "repl_pass", "START GROUP_REPLICATION USER='repl_user' PASSWORD='repl_pass'"), ("repl_user", "repl_pass", "START GROUP_REPLICATION USER='repl_user', PASSWORD='repl_pass'"),
] ]
) )
def test_start_group_replication(user, password, expected_query): def test_start_group_replication(user, password, expected_query):
@ -70,7 +70,6 @@ def test_start_group_replication(user, password, expected_query):
assert result is True assert result is True
assert cursor.executed_queries[0] == expected_query assert cursor.executed_queries[0] == expected_query
assert cursor.executed_queries[1] == "SHOW STATUS LIKE 'group_replication_status';"
def test_stop_group_replication(): def test_stop_group_replication():
@ -86,22 +85,17 @@ def test_stop_group_replication():
assert result is True assert result is True
assert cursor.executed_queries[0] == "STOP GROUP_REPLICATION" assert cursor.executed_queries[0] == "STOP GROUP_REPLICATION"
assert cursor.executed_queries[1] == "SHOW STATUS LIKE 'group_replication_status';"
def test_start_group_replication_fail(): def test_start_group_replication_fail():
"""Test startgroupreplication function with failure.""" """Test startgroupreplication function with failure."""
from ansible_collections.community.mysql.plugins.modules.mysql_replication import startgroupreplication from ansible_collections.community.mysql.plugins.modules.mysql_replication import startgroupreplication
import pymysql
cursor = MockCursor(status="ERROR") cursor = MockCursor(status="ERROR")
module = type('obj', (object,), { module = type('obj', (object,), {
'fail_json': lambda msg: None, 'fail_json': lambda msg: None,
}) })
# Mock the Warning exception
pymysql.Warning = Exception
result = startgroupreplication(module, cursor, [], True) result = startgroupreplication(module, cursor, [], True)
assert result is False assert result is False
@ -110,16 +104,12 @@ def test_start_group_replication_fail():
def test_stop_group_replication_fail(): def test_stop_group_replication_fail():
"""Test stopgroupreplication function with failure.""" """Test stopgroupreplication function with failure."""
from ansible_collections.community.mysql.plugins.modules.mysql_replication import stopgroupreplication from ansible_collections.community.mysql.plugins.modules.mysql_replication import stopgroupreplication
import pymysql
cursor = MockCursor(status="ERROR") cursor = MockCursor(status="ERROR")
module = type('obj', (object,), { module = type('obj', (object,), {
'fail_json': lambda msg: None, 'fail_json': lambda msg: None,
}) })
# Mock the Warning exception
pymysql.Warning = Exception
result = stopgroupreplication(module, cursor, True) result = stopgroupreplication(module, cursor, True)
assert result is False assert result is False