From 6adb71a3ea1ac0d4933c7daf4d99a166738b7180 Mon Sep 17 00:00:00 2001 From: Laurent Indermuehle Date: Mon, 9 Jan 2023 15:40:55 +0100 Subject: [PATCH] Linting --- .../targets/setup_controller/tasks/connector.yml | 1 + .../test_mysql_db/tasks/config_overrides_defaults.yml | 10 +++++----- .../test_mysql_db/tasks/encoding_dump_import.yml | 4 ++-- .../targets/test_mysql_db/tasks/state_dump_import.yml | 6 +++--- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/tests/integration/targets/setup_controller/tasks/connector.yml b/tests/integration/targets/setup_controller/tasks/connector.yml index 5c48142..fc760ac 100644 --- a/tests/integration/targets/setup_controller/tasks/connector.yml +++ b/tests/integration/targets/setup_controller/tasks/connector.yml @@ -3,3 +3,4 @@ - name: "{{ role_name }} | Connector | Install python packages" ansible.builtin.pip: name: "{{ connector_name }}" + state: present diff --git a/tests/integration/targets/test_mysql_db/tasks/config_overrides_defaults.yml b/tests/integration/targets/test_mysql_db/tasks/config_overrides_defaults.yml index d4ffe63..c82fc48 100644 --- a/tests/integration/targets/test_mysql_db/tasks/config_overrides_defaults.yml +++ b/tests/integration/targets/test_mysql_db/tasks/config_overrides_defaults.yml @@ -64,8 +64,8 @@ - name: Must fail because login_port default has beed overriden by wrong value from config file assert: that: - - result is failed - - result.msg is search("unable to connect to database") + - result is failed + - result.msg is search("unable to connect to database") - name: Create database using default port mysql_db: @@ -83,7 +83,7 @@ - name: Must not fail because of the default of login_port is correct assert: that: - - result is changed + - result is changed - name: Reinit custom config file shell: 'echo "[client]" > {{ config_file }}' @@ -107,8 +107,8 @@ - name: Must fail because login_host default has beed overriden by wrong value from config file assert: that: - - result is failed - - result.msg is search("Can't connect to MySQL server on '{{ fake_host }}'") or result.msg is search("Unknown MySQL server host '{{ fake_host }}'") + - result is failed + - result.msg is search("Can't connect to MySQL server on '{{ fake_host }}'") or result.msg is search("Unknown MySQL server host '{{ fake_host }}'") # Clean up - name: Remove test db diff --git a/tests/integration/targets/test_mysql_db/tasks/encoding_dump_import.yml b/tests/integration/targets/test_mysql_db/tasks/encoding_dump_import.yml index 4006d7e..7b4159c 100644 --- a/tests/integration/targets/test_mysql_db/tasks/encoding_dump_import.yml +++ b/tests/integration/targets/test_mysql_db/tasks/encoding_dump_import.yml @@ -49,7 +49,7 @@ - assert: that: - - result is changed + - result is changed - name: state dump - file name should exist file: @@ -82,7 +82,7 @@ - assert: that: - - result is changed + - result is changed - name: check encoding of table ansible.builtin.command: diff --git a/tests/integration/targets/test_mysql_db/tasks/state_dump_import.yml b/tests/integration/targets/test_mysql_db/tasks/state_dump_import.yml index c587da8..a7712b7 100644 --- a/tests/integration/targets/test_mysql_db/tasks/state_dump_import.yml +++ b/tests/integration/targets/test_mysql_db/tasks/state_dump_import.yml @@ -444,8 +444,8 @@ register: result - assert: that: - - result is failed - - result.msg is search('Failed to open file') + - result is failed + - result.msg is search('Failed to open file') - name: Restore with chdir argument, must pass mysql_db: @@ -460,7 +460,7 @@ register: result - assert: that: - - result is succeeded + - result is succeeded ########## # Clean up