From 5bc5ed1cee36e1b4486699dc3a01ae41832e1793 Mon Sep 17 00:00:00 2001 From: Laurent Indermuehle Date: Mon, 16 Jan 2023 08:43:57 +0100 Subject: [PATCH] Change tag of test-containers to latest --- .github/workflows/ansible-test-plugins.yml | 4 ++-- CONTRIBUTING.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ansible-test-plugins.yml b/.github/workflows/ansible-test-plugins.yml index aebc7dc..e965423 100644 --- a/.github/workflows/ansible-test-plugins.yml +++ b/.github/workflows/ansible-test-plugins.yml @@ -45,12 +45,12 @@ jobs: db_engine_version: mysql:5.7.40 python: 3.8 connector: pymysql==0.7.11 - docker_container: quay.io/mws/community-mysql-test-containers-my57-py38-mysqlclient201-pymysql0711:0.0.1 + docker_container: quay.io/mws/community-mysql-test-containers-my57-py38-mysqlclient201-pymysql0711:latest - ansible: stable-2.12 db_engine_version: mysql:5.7.40 python: 3.8 connector: pymysql==0.9.3 - docker_container: quay.io/mws/community-mysql-test-containers-my57-py38-pymysql093:0.0.1 + docker_container: quay.io/mws/community-mysql-test-containers-my57-py38-pymysql093:latest # db_engine_version: # - mysql:5.7.40 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6f4ffa0..1b8357c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,7 @@ The Makefile accept the following options: - ansible: Mandatory version of ansible to install in a venv to run ansible-test. - docker_container: The container image to use to run our tests. Those images Dockerfile are in https://github.com/community.mysql-test-containers and then pushed to quay.io: E.G.: - `quay.io/mws/community-mysql-test-containers-my57-py38-mysqlclient201-pymysql0711:0.0.1`. Look in the link above for a complete list of available containers. You can also look into `.github/workflows/ansible-test-plugins.yml` + `quay.io/mws/community-mysql-test-containers-my57-py38-mysqlclient201-pymysql0711:latest`. Look in the link above for a complete list of available containers. You can also look into `.github/workflows/ansible-test-plugins.yml` Unfortunatly you must provide the right container_image yourself. And you still need to provides db_engine_version, python, etc... because ansible-test won't do black magic to try to detect what we expect. Explicit is better than implicit anyway. To minimise the amount of images, pymysql 0.7.11 and mysqlclient are shipped together. - db_engine_version: The name of the container to use for the service containers that will host a primary database and two replicas. Either MYSQL or MariaDB. Use ':' as a separator. Do not use short version, like mysql:8 for instance. Our tests expect a full version to filter tests precisely. For instance: `when: db_version is version ('8.0.22', '>')`.