ansible-collections/community.mysql
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.mysql.git synced 2025-04-06 10:40:36 -07:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Add IF EXISTS clause to DROP USER statement (#307)

Browse source 
* Add IF EXISTS clause to DROP USER statement

* Add a changelog fragment

* Fix exception
This commit is contained in:
Andrew Klychkov 2022-03-15 15:41:55 +03:00 • committed by GitHub
parent 1f16e65dfc
commit 3a452faeb0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/307-mysql_user_add_if_exists_to_drop.yml Normal file
View file

@ -0,0 +1,2 @@
bugfixes:
- "mysql_user - fix the possibility for a race condition that breaks certain (circular) replication configurations when ``DROP USER`` is executed on multiple nodes in the replica set. Adding ``IF EXISTS`` avoids the need to use ``sql_log_bin: no`` making the statement always replication safe (https://github.com/ansible-collections/community.mysql/pull/287)."

5
plugins/module_utils/user.py
View file

@ -368,7 +368,10 @@ def user_delete(cursor, user, host, host_all, check_mode):
hostnames = [host] hostnames = [host]
for hostname in hostnames: for hostname in hostnames:
cursor.execute("DROP USER %s@%s", (user, hostname)) try:
cursor.execute("DROP USER IF EXISTS %s@%s", (user, hostname))
except Exception:
cursor.execute("DROP USER %s@%s", (user, hostname))
return True return True