From 35599a71760e7f9c9dc4dfe61be71270c895c80c Mon Sep 17 00:00:00 2001 From: Laurent Indermuehle Date: Mon, 29 Apr 2024 15:10:23 +0200 Subject: [PATCH] fix case where a failed fetchone() still return a dict for primary --- plugins/modules/mysql_replication.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/plugins/modules/mysql_replication.py b/plugins/modules/mysql_replication.py index fe40446..f4f192a 100644 --- a/plugins/modules/mysql_replication.py +++ b/plugins/modules/mysql_replication.py @@ -550,11 +550,13 @@ def main(): if mode == 'getprimary': status = get_primary_status(cursor) - if not isinstance(status, dict): - status = dict(Is_Primary=False, - msg="Server is not configured as mysql primary") - else: + if status and "File" in status and "Position" in status: status['Is_Primary'] = True + else: + status = dict( + Is_Primary=False, + msg="Server is not configured as mysql primary. " + "Meaning: Binary logs are disabled") module.exit_json(queries=executed_queries, **status)